Maniphest T68943

GP time offset modifier, frame offset value changes to -2147483647 when using the inc/dec icons
Closed, Resolved
Actions

Assigned To
Antonio Vazquez (antoniov)
Authored By
heini (ogonek)
Aug 20 2019, 11:50 PM
Tags
  • BF Blender
  • Grease Pencil
  • User Interface
Subscribers
Antonio Vazquez (antoniov)
heini (ogonek)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 388.13

Blender Version
Broken: version: 2.81 (sub 2), branch: master, commit date: 2019-08-20 07:45, hash: rBf2cab8267f22
Worked: (optional)

Short description of error
Time offset modifier in GP: the value of 'frame offset' changes to -2147483647 when clicking the < and > icons

Exact steps for others to reproduce the error

  • create GP object
  • add time offset modifier
  • click on arrows left and right of the input field
  • -2147483647

Revisions and Commits

rB Blender
rB8f50cdd7d5cb Fix T68943: GPencil Time modifier gets strange value in offset parameter

Related Objects

Event Timeline

heini (ogonek) created this task.Aug 20 2019, 11:50 PM
Philipp Oeser (lichtwerk) assigned this task to Antonio Vazquez (antoniov).Aug 21 2019, 10:01 AM
Philipp Oeser (lichtwerk) added a project: Grease Pencil.
Philipp Oeser (lichtwerk) added subscribers: Antonio Vazquez (antoniov), Philipp Oeser (lichtwerk).

Can confirm, @Antonio Vazquez (antoniov) : mind checking?

Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.Aug 21 2019, 10:01 AM
Philipp Oeser (lichtwerk) added a project: User Interface.
Antonio Vazquez (antoniov) added a comment.Aug 21 2019, 10:04 AM

I have tested these 3 arrows and works for me.

Maybe these are not the arrows to test.

Antonio Vazquez (antoniov) added a comment.Aug 21 2019, 10:07 AM

I can confirm with daily build.

Philipp Oeser (lichtwerk) added a comment.Aug 21 2019, 10:44 AM

note this also happens for shaderfx rim/shadow offset
rim/shadow blur also behave weird (dont increment/decrement using arrows)

Antonio Vazquez (antoniov) changed the task status from Unknown Status to Resolved by committing rB8f50cdd7d5cb: Fix T68943: GPencil Time modifier gets strange value in offset parameter.Aug 21 2019, 11:08 AM
Antonio Vazquez (antoniov) added a commit: rB8f50cdd7d5cb: Fix T68943: GPencil Time modifier gets strange value in offset parameter.
Antonio Vazquez (antoniov) added a comment.Aug 21 2019, 11:10 AM

It looks there is some type of Overflow in the UI code when the range is near of the INT max values. I have replaced by SHRT_MAX because is enough.

Antonio Vazquez (antoniov) mentioned this in T68951: 'Scatter Objects' add-on.Aug 21 2019, 12:39 PM