Maniphest T69148

Import Images as Planes
Closed, ArchivedPATCH
Actions

Assigned To
Philipp Oeser (lichtwerk)
Authored By
Himanshi Kalra (calra)
Aug 25 2019, 3:58 PM
Tags
  • Add-ons (Community)
Subscribers
Bastien Montagne (mont29)
Brendon Murphy (meta-androcto)
Himanshi Kalra (calra)

Description

HI I am a beginner I saw this task and I have made this addon-patch for the task https://developer.blender.org/T66299

newImg2plane.py44 KBDownload

Related Objects

Event Timeline

Himanshi Kalra (calra) created this task.Aug 25 2019, 3:58 PM
Brendon Murphy (meta-androcto) lowered the priority of this task from 90 to 30.Aug 26 2019, 7:58 AM
Brendon Murphy (meta-androcto) added a subscriber: Brendon Murphy (meta-androcto).

hi, what are the benefits of your changes and what do they do?

Philipp Oeser (lichtwerk) added a comment.Aug 26 2019, 10:51 AM

@Brendon Murphy (meta-androcto) : Think this is about replacing the node setup with a principled shader [so it is better suited for exporting (OBJ, FBX, GLTF -- which rely on the Principled Shader to export textures along...)]
This might not be possible for the "shadeless" setup -- would at least need some further checking, but the for the others, using a principled shader should work out, I guess...

Hi @Himanshi Kalra (calra) !
Thx for your contribution!
Would you mind submitting this as a real patch (this would make it much easier for us in the review process)?
Have a look here https://wiki.blender.org/wiki/Process/Contributing_Code and here https://wiki.blender.org/wiki/Tools/Patches
You can just create a differential and attach it to T66299: Addon "Import images as planes". change node system for better exprting to glTF, lets use this task for this since this is open already.

Himanshi Kalra (calra) added a comment.Aug 26 2019, 11:23 AM

Hi thanks for replying I just read the Never do section, I didn't take permission from the authors' of this addon before editing. Should I do that before submitting the patch ?

Bastien Montagne (mont29) changed the task status from Unknown Status to Unknown Status.Aug 26 2019, 4:37 PM
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

For sake of clarity, @Himanshi Kalra (calra) contacted me on blender.chat this morning, and gave the answer that anybody is free to modify that add-ons code within the licenses's conditions, as with any other piece of GPL software. What we forbid is committing changes to someone else's add-on without getting them reviewed first. Submitting patches is the way to go, and most welcomed.

@Himanshi Kalra (calra) will archive that task, we indeed need a proper differential one for review, as described by @Philipp Oeser (lichtwerk) above. Thanks.