Maniphest T69172

texture opacity slider in texture paint mode not working
Closed, Archived
Actions

Assigned To
Philipp Oeser (lichtwerk)
Authored By
grant abbitt (grant.abbitt)
Aug 26 2019, 2:10 PM
Tags
  • BF Blender
  • User Interface
Subscribers
grant abbitt (grant.abbitt)
Philipp Oeser (lichtwerk)
William Reynish (billreynish)
xrg (xrg)
YAFU (YAFU)

Description

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.67

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: rBf6cb5f54494e
Worked: (optional)

Short description of error
the texture opacity slider when in texture paint mode does not seem to work any more in fact it just does nothing

Related Objects

Event Timeline

grant abbitt (grant.abbitt) created this task.Aug 26 2019, 2:10 PM
xrg (xrg) added a subscriber: xrg (xrg).Aug 26 2019, 2:56 PM

It seems to only work with the Mask Brush texture. If that is deliberate, the overlay slider maybe should be renamed.

YAFU (YAFU) added a subscriber: YAFU (YAFU).Aug 26 2019, 3:02 PM

Hi
It is intentional change and it has been renamed to Stencil Opacity in master/buildbot/2.81

Philipp Oeser (lichtwerk) changed the task status from Unknown Status to Unknown Status.Aug 27 2019, 3:38 PM
Philipp Oeser (lichtwerk) claimed this task.
Philipp Oeser (lichtwerk) added a project: User Interface.
Philipp Oeser (lichtwerk) added subscribers: William Reynish (billreynish), Philipp Oeser (lichtwerk).

Afaict, this affects the Mask/Stencil layer (and that seems to be working fine).

However, I am not quite following the naming here (seems a bit inconsistent), in code we are using use_stencil_layer, the image is the Stencil Image, the Overlay option is displayed as Stencil Opacity, however you enable the whole thing with Mask... seems a bit off. Why not do the following?

P1085 T69172 snippet
1
2
3diff --git a/release/scripts/startup/bl_ui/space_view3d_toolbar.py b/release/scripts/startup/bl_ui/space_view3d_toolbar.py
4index 9fd35808b4b..0fb0a9e5542 100644
5--- a/release/scripts/startup/bl_ui/space_view3d_toolbar.py
6+++ b/release/scripts/startup/bl_ui/space_view3d_toolbar.py
7@@ -701,7 +701,7 @@ class VIEW3D_PT_slots_projectpaint(View3DPanel, Panel):
8 class VIEW3D_PT_stencil_projectpaint(View3DPanel, Panel):
9 bl_category = "Tool"
10 bl_context = ".imagepaint" # dot on purpose (access from topbar)
11- bl_label = "Mask"
12+ bl_label = "Stencil"
13 bl_options = {'DEFAULT_CLOSED'}
14
15 @classmethod

That being said, this is not really a bug, (if at all could be a nice improvement for consistency?)
So, will close this as not-a-bug, but maybe there is a reaction from the UI team (could still commit this then...)?
@grant abbitt (grant.abbitt) : feel free to comment again if this is a misunderstanding on my side...
CC @William Reynish (billreynish)

Justin Truelove (gamepad-coder) mentioned this in T80031: UI: Inaccurate Text -- Texture Paint -> Viewport Overlay -> "Stencil Opacity" -- does not affect Stencil, does affect the Stencil Mask Opacity.Aug 23 2020, 3:00 AM