Maniphest T69297

make deps documentation
Closed, ResolvedTO DO

Assigned To
Brecht Van Lommel (brecht)
Authored By
Dalai Felinto (dfelinto)
Aug 29 2019, 3:28 PM
Tags
  • Platforms, Builds, Tests & Devices
Subscribers
Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)
Ray Molenkamp (LazyDodo)

Description

We need to document (online or in the repo/cmake/...) the dependencies of make deps.

For instance, at the moment in Ubuntu if you try to build without tclsh it fails due to sqlite3. But you only get the proper warning in the first time you run it.

This is regardless of whether we should integrate install_deps.sh and make deps in the future.

Revisions and Commits

rB Blender

Event Timeline

Dalai Felinto (dfelinto) lowered the priority of this task from 90 to Normal.Aug 29 2019, 3:28 PM
Dalai Felinto (dfelinto) created this task.
Dalai Felinto (dfelinto) mentioned this in T66306: Platforms, Builds & Tests Module.
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Aug 29 2019, 3:34 PM
Ray Molenkamp (LazyDodo) added a subscriber: Ray Molenkamp (LazyDodo).Aug 29 2019, 3:42 PM

There are a bunch of build time deps that 'make deps' has, like tclsh , nasm,yasm etc, if they are missing when the build starts, it's very hard for the average user to get 'unstuck' after it breaks and dies, and they install the missing deps since you have to remove the build folder for sqllite for instance for it to look for tclsh again.

Also since we do multi threaded builds, the actual error is generally long scrolled out of the screen when cmake decides to call it quits confusing even more users.

It's probably best if we implement a pre-flight check in cmake that checks for the required dependencies and errors out preemptively

Dalai Felinto (dfelinto) updated the task description.Aug 29 2019, 4:24 PM
Dalai Felinto (dfelinto) added a comment.Aug 29 2019, 4:29 PM

Indeed in the CMake files it says: "# Install compiler cmake autoconf automake libtool yasm nasm tcl"
So technically yes the issue here is not documentation per-se.

Maybe a simple solution would be to suggest "users" to look at the CMakeLists.txt file for instructions if CMake exists with error.

Brecht Van Lommel (brecht) changed the task status from Unknown Status to Resolved by committing rBcc496445518d: Build: check necessary software is installed for make deps on macOS and Linux.Aug 30 2019, 11:22 AM
Brecht Van Lommel (brecht) claimed this task.
Brecht Van Lommel (brecht) added a commit: rBcc496445518d: Build: check necessary software is installed for make deps on macOS and Linux.