Maniphest T69332

Crash : attempting to reset a a custom property that has a string value crashes Blender
Closed, Resolved
Actions

Assigned To
Philipp Oeser (lichtwerk)
Authored By
Fin O'Riordan (fin.eskimo)
Aug 30 2019, 3:56 PM
Tags
  • BF Blender
Subscribers
Abid Maqbool (cto.abid)
Alexander Gavrilov (angavrilov)
Fin O'Riordan (fin.eskimo)
Jeroen Bakker (jbakker)
MACHIN3 (MACHIN3)
Philipp Oeser (lichtwerk)
Piotr (radi0n)
Tokens
"Love" token, awarded by fin.eskimo.

Description

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.70

Blender Version
Broken: version: 2.81 (sub 3), branch: master, commit date: 2019-08-20 22:35, hash: rBdaba3e871ff5
Worked: (Possibly never it crashes 2.79 too)

Short description of error
If right click on a custom property that has a string value you will get a "Reset to Default Value" option.... selecting it crashes Blender

Exact steps for others to reproduce the error
I've uploaded a simple file, the cube has a custom property... reset it to default value.

reset for crash.blend625 KBDownload

Revisions and Commits

rB Blender
D6284rB60e817693ce7 Fix T69332: 'Reset to Default Value' on a custom string property crashes
D6284rBcfb7f508ce76 Fix T69332: 'Reset to Default Value' on a custom string property crashes

Related Objects

Mentioned Here
T54899: Custom property -> revert to default value crashes blender
rB61c941f040d3: RNA: support setting default values for custom properties.
P669 T54899 snippet

Event Timeline

Fin O'Riordan (fin.eskimo) created this task.Aug 30 2019, 3:56 PM
Abid Maqbool (cto.abid) added a subscriber: Abid Maqbool (cto.abid).Aug 30 2019, 4:18 PM

Can confirm bug:


Thanks!
Have no idea, is there is why to check logs/error?

Jeroen Bakker (jbakker) lowered the priority of this task from 90 to High.EditedAug 30 2019, 4:35 PM
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).
# Blender 2.81 (sub 4), Unknown revision

# backtrace
b281(BLI_system_backtrace+0x35) [0x5651dd105118]
b281(+0x2bdcd5f) [0x5651dcd5ed5f]
b281(+0x2bdcf3e) [0x5651dcd5ef3e]
/lib/x86_64-linux-gnu/libc.so.6(+0x3ef20) [0x7f3793c5ff20]
/lib/x86_64-linux-gnu/libc.so.6(+0xb1646) [0x7f3793cd2646]
b281(RNA_property_string_default_length+0x8b) [0x5651dd212d5f]
b281(RNA_property_string_get_default_alloc+0x8a) [0x5651dd212c7c]
b281(RNA_property_reset+0x385) [0x5651dd21ec11]
b281(+0x39fc82c) [0x5651ddb7e82c]
b281(+0x329b014) [0x5651dd41d014]
b281(+0x329b81c) [0x5651dd41d81c]
b281(WM_operator_name_call_ptr+0xb0) [0x5651dd41d8d9]
b281(+0x39ca6b6) [0x5651ddb4c6b6]
b281(+0x39e3cbe) [0x5651ddb65cbe]
b281(+0x3298b7b) [0x5651dd41ab7b]
b281(+0x329df91) [0x5651dd41ff91]
b281(+0x329ed66) [0x5651dd420d66]
b281(wm_event_do_handlers+0x7ec) [0x5651dd421ffa]
b281(WM_main+0x30) [0x5651dd414e77]
b281(+0x2bd8624) [0x5651dcd5a624]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7f3793c42b97]
b281(_start+0x2a) [0x5651dcd5a0aa]
  • does not happen when the property was just created. Could be related to saving/loading.

I am see it happening in the file, but I am not able to reproduce it from scratch. Do you know the steps that were taken in order you got the file in this state that crashes?

Jeroen Bakker (jbakker) lowered the priority of this task from High to 30.Aug 30 2019, 4:49 PM
Fin O'Riordan (fin.eskimo) added a comment.Sep 2 2019, 11:05 AM

I literally just create a custom property then try reset it to default.... I'll try get another user to confirm...

Fin O'Riordan (fin.eskimo) added a comment.Sep 2 2019, 11:16 AM

This is in a fresh blend...

Philipp Oeser (lichtwerk) raised the priority of this task from 30 to 50.Sep 2 2019, 11:59 AM
Philipp Oeser (lichtwerk) added subscribers: Alexander Gavrilov (angavrilov), Philipp Oeser (lichtwerk).

Can confirm this, too.
Not sure why I am not getting it all the time (sometimes I have to try twice), but on second try, it always fails.
With a debugger attached, it seems to always fail.

Note this was once reported before T54899: Custom property -> revert to default value crashes blender, I wasnt able to reproduce for a while later, so closed it, but seems to be back (or never fixed...)

@Alexander Gavrilov (angavrilov) : you did rB61c941f040d3: RNA: support setting default values for custom properties., mind checking if P669 is safe enough?

Fin O'Riordan (fin.eskimo) added a comment.Sep 2 2019, 12:00 PM

I can even reproduce this in 2.69... it's a fairly consistent bug ;)

Fin O'Riordan (fin.eskimo) awarded a token.Sep 2 2019, 12:05 PM
Fin O'Riordan (fin.eskimo) added a comment.Sep 17 2019, 12:02 PM

....even the removal of the ability to to run a "Reset to Default Value" for strings would considered a fix.

MACHIN3 (MACHIN3) added a subscriber: MACHIN3 (MACHIN3).Nov 13 2019, 7:40 PM

Yep, can confirm this is happening in the supplied blend.
I can also reproduce it in new blends. I've tried adjusting various settings(like setting or clearing a default value) of the prop before attempting to reset to defaults. Sometimes it would not crash, but I could not find a consistent method to do this.

Piotr (radi0n) added a subscriber: Piotr (radi0n).Nov 14 2019, 2:29 PM

Crash with:

Error : EXCEPTION_ACCESS_VIOLATION
Address : 0x00007FF621666643
Module : H:\Blender\Blender2.81\blender.exe

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.20

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-13 16:25, hash: rB9bd0d8b5505a

Philipp Oeser (lichtwerk) added a revision: D6284: Fix T69332: 'Reset to Default Value' on a custom string property crashes.Nov 21 2019, 2:03 PM
Philipp Oeser (lichtwerk) changed the task status from Unknown Status to Resolved by committing rBcfb7f508ce76: Fix T69332: 'Reset to Default Value' on a custom string property crashes.Nov 22 2019, 12:21 PM
Philipp Oeser (lichtwerk) claimed this task.
Philipp Oeser (lichtwerk) added a commit: rBcfb7f508ce76: Fix T69332: 'Reset to Default Value' on a custom string property crashes.
Fin O'Riordan (fin.eskimo) rescinded a token.Nov 22 2019, 2:59 PM
Fin O'Riordan (fin.eskimo) awarded a token.
Sergey Sharybin (sergey) added a commit: rB60e817693ce7: Fix T69332: 'Reset to Default Value' on a custom string property crashes.Dec 3 2019, 2:29 PM