Maniphest T69486

Reloading 'text' file in 'Scripting' marks the file as modified
Closed, Resolved

Assigned To
Jacques Lucke (JacquesLucke)
Authored By
Richard Musil (risa2000)
Sep 4 2019, 1:20 PM
Tags
  • BF Blender
  • Text Editor
Subscribers
Pedro Reis (veryprofessionaldodo)
Richard Musil (risa2000)

Description

System Information
Operating system: Windows 10
Graphics card: GTX 1080 Ti

Blender Version
Blender 2.80 (sub 75) (hash f6cb5f54494e built 2019-07-29 09:44 AM)

Short description of error
When for example Python script file is linked to Blender workspace as 'text' object, (e.g. by using 'Scripting' -> 'open text') then the original file is modified on the disk outside of Blender, Blender detects it when getting focus and shows a red "book" icon which offers "Reload" | "Make internal" | "Ignore".
When "Reload" is selected, the text object is updated with the new file content, but at the same time marked as modified (asterisk next to the file name in the status bar of the Scripting window).

The only way to "unmodify" it is to save the file back (Alt+S on Windows).

I expect that reloading from the disk should not mark the file with asterisk, which I read as the file has been modified, because the reload should guarantee the opposite - the file in Blender and on the disk are exactly the same.

Exact steps for others to reproduce the error

  • Add text file via Scripting -> open text
  • Modify the file outside Blender
  • Choose "Reload from the disk"
  • Check the status in the status bar.

Revisions and Commits

rB Blender
D5847

Related Objects

Mentioned In
T68061: Text Editor Module
Mentioned Here
rBf6cb5f54494e: Version bump to 2.80 final release

Event Timeline

Richard Musil (risa2000) created this task.Sep 4 2019, 1:20 PM
Dalai Felinto (dfelinto) lowered the priority of this task from 90 to Low.Sep 17 2019, 6:05 PM
Dalai Felinto (dfelinto) added a project: Text Editor.
Dalai Felinto (dfelinto) mentioned this in T68061: Text Editor Module.Sep 17 2019, 6:08 PM
Dalai Felinto (dfelinto) renamed this task from reloading 'text' file in 'Scripting' marks the file as modified to Reloading 'text' file in 'Scripting' marks the file as modified.Sep 17 2019, 6:15 PM
Pedro Reis (veryprofessionaldodo) added a subscriber: Pedro Reis (veryprofessionaldodo).Sep 18 2019, 3:23 PM
Jacques Lucke (JacquesLucke) changed the task status from Unknown Status to Resolved by committing rBfb6ef2ec8d03: Fix T69486: Reloading file in text editor marks file as modified.Sep 20 2019, 12:48 PM
Jacques Lucke (JacquesLucke) claimed this task.
Jacques Lucke (JacquesLucke) added a commit: rBfb6ef2ec8d03: Fix T69486: Reloading file in text editor marks file as modified.