Maniphest T69497

Color Correction node ignores mask when changing any gamma channel.
Closed, ResolvedBUG
Actions

Assigned To
Sergey Sharybin (sergey)
Authored By
ronsn
Sep 4 2019, 5:18 PM
Tags
  • BF Blender
  • Compositing
  • VFX & Video
Subscribers
Dalai Felinto (dfelinto)
Jacques Lucke (JacquesLucke)
Philipp Oeser (lichtwerk)
ronsn

Description

System Information
Operating system: Linux-4.15.0-60-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: Mesa DRI Intel(R) HD Graphics 520 (Skylake GT2) Intel Open Source Technology Center 4.5 (Core Profile) Mesa 19.0.8

Blender Version
Broken: version: 2.81 (sub 5), branch: master, commit date: 2019-09-04 09:55, hash: rB4d995527a9a1
Also broken in 2.79b and 2.80

Worked: (optional)

Short description of error
In the Compositor the Color Correction node ignores masks when changing any gamma channel (i.e. Master, Highlight, Midtones,...).

Exact steps for others to reproduce the error
For example changing the gamma in channel midtones to 1.001 leads to:

  • Saturation, or Contrast value < 1 (any channel) => does respect the mask
  • Saturation, or Contrast value > 1 (any channel) => does not respect the mask

Lift is vice versa

  • Lift value < 1 (any channel) => does not respect the mask
  • Lift value > 1 (any channel) => does respect the mask
  • Gamma (alone) => does respect the mask
  • Gain => does respect the mask

I append the file color_correction_node_r0.blend with an image packed where you can simply try out yourself:

color_correction_node_r0.blend933 KBDownload

Revisions and Commits

rB Blender
D7966rB665acd29039b Fix T69497: Color Correction node ignores mask in certain cases

Related Objects

Event Timeline

ronsn created this task.Sep 4 2019, 5:18 PM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.Sep 5 2019, 10:34 AM
Philipp Oeser (lichtwerk) added a project: Compositing.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Can confirm, checking...

Philipp Oeser (lichtwerk) added a comment.Sep 5 2019, 10:47 AM

T68076 can be tackled hand in hand (might be related even)

Dalai Felinto (dfelinto) added a project: Tracker Curfew.Dec 23 2019, 1:52 PM
Jacques Lucke (JacquesLucke) removed a project: Tracker Curfew.Jan 29 2020, 3:36 PM
Jacques Lucke (JacquesLucke) changed the subtype of this task from "Report" to "Bug".
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).

@Philipp Oeser (lichtwerk), looks like you are right. D6696 seems to fix this as well.

Dalai Felinto (dfelinto) added a project: VFX & Video.May 21 2020, 12:03 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

Confirmed reports should always be tagged to a module, otherwise they don't show up in the queries and workboards.

Philipp Oeser (lichtwerk) added a comment.Jun 5 2020, 5:06 PM

@ronsn : since D6696: Fix T68076: Color Correction node generates NaN has landed, should we consider this fixed?

Philipp Oeser (lichtwerk) added a comment.Jun 5 2020, 5:06 PM

Nope... negative Lift case is still wrong...

ronsn added a comment.Jun 9 2020, 1:17 AM

@Philipp Oeser (lichtwerk) Ja, negative Lift seems to be the only case left which leads to mask-ignoring. 🙂

Philipp Oeser (lichtwerk) added a revision: D7966: Fix T69497: Color Correction node ignores mask in certain cases.Jun 9 2020, 3:50 PM
Sergey Sharybin (sergey) closed this task as Resolved by committing rB665acd29039b: Fix T69497: Color Correction node ignores mask in certain cases.Jun 11 2020, 11:02 AM
Sergey Sharybin (sergey) claimed this task.
Sergey Sharybin (sergey) added a commit: rB665acd29039b: Fix T69497: Color Correction node ignores mask in certain cases.