Maniphest T69509

Quick Smoke is Broken
Closed, Resolved
Actions

Assigned To
Stephen Swaney (stiv)
Authored By
Steve Warner (stevewarner)
Sep 4 2019, 10:54 PM
Tags
  • BF Blender
Subscribers
Brendon Murphy (meta-androcto)
Damien Picard (pioverfour)
Philipp Oeser (lichtwerk)
Stephen Swaney (stiv)
Steve Warner (stevewarner)

Description

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 2.81 (sub 6), branch: master, commit date: 2019-09-04 14:30, hash: rB45d4c925799e
Worked: (optional) 2.80

Short description of error
Quick Smoke is broken in the latest build.

Exact steps for others to reproduce the error
Select the default cube
Go to the Object menu and press Quick Effects > Quick Smoke
A domain object will be created and the smoke effect will be applied to the cube
Press play on the timeline
No smoke will appear to emerge from the cube.
Repeat the same steps in 2.80 and you'll get smoke coming out of the cube.

Revisions and Commits

rBA Blender Add-ons
rBAc3348263dc26 animation_animall: Fix T69509 Quick smoke broken

Related Objects

Mentioned In
T68666: Animated mesh UVs, vertex groups, vertex colors don’t update on time change
rBA0a6d3d725f0b: animation_animall: workaround for data refresh: T68332 T68666
Mentioned Here
rBAc3348263dc26: animation_animall: Fix T69509 Quick smoke broken
rBA0a6d3d725f0b: animation_animall: workaround for data refresh: T68332 T68666
rB4d995527a9a1: UI: Rename Select tool to Tweak tool

Event Timeline

Steve Warner (stevewarner) created this task.Sep 4 2019, 10:54 PM
Stephen Swaney (stiv) added a subscriber: Stephen Swaney (stiv).Sep 4 2019, 11:08 PM

Today's Linux buildbot version seems to work OK.
commit date: 2019-09-04 09:55,
hash: 4d995527a9a1,
build date: 2019-09-04, 13:11:21

Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 30.Sep 5 2019, 10:04 AM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Also cannot reproduce here.

Please check:

  • latest buildbot build
  • Factory Settings
  • is this happening in all viewport shading modes?
Steve Warner (stevewarner) added a comment.Sep 5 2019, 6:14 PM

I've isolated the problem. It's the AnimAll addon. If AnimAll is enabled, QuickSmoke will not be visible in the viewport.

Stephen Swaney (stiv) changed the task status from Unknown Status to Resolved.Sep 5 2019, 6:43 PM
Stephen Swaney (stiv) claimed this task.

Interesting. And good detective work!
Closing as Resolved.

I'm curious as to what AnimAll addon is doing to cause conflict.

Philipp Oeser (lichtwerk) added a comment.Sep 6 2019, 9:22 AM

I think this is due to AnimAll adding a data refresh handler, see rBA0a6d3d725f0b

Philipp Oeser (lichtwerk) mentioned this in rBA0a6d3d725f0b: animation_animall: workaround for data refresh: T68332 T68666.Sep 6 2019, 9:22 AM
Philipp Oeser (lichtwerk) mentioned this in T68666: Animated mesh UVs, vertex groups, vertex colors don’t update on time change.Sep 6 2019, 9:31 AM
Damien Picard (pioverfour) added a subscriber: Damien Picard (pioverfour).Sep 6 2019, 9:55 AM

Sorry about that, I introduced the bug. It is alleviated by rBAc3348263dc26, but it will still happen if the smoke mesh has animation data.

Brendon Murphy (meta-androcto) added a subscriber: Brendon Murphy (meta-androcto).Sep 6 2019, 10:53 AM

that could be a reason that the refresh was not used?

Damien Picard (pioverfour) added a comment.Sep 6 2019, 11:14 AM

Well, if the smoke simulation is broken, there are probably other areas affected as well… For instance, I just tested with a particle system, and the particles stick to the surface instead of falling down. It is fixed by rBAc3348263dc26 as well, though.

Damien Picard (pioverfour) added a commit: rBAc3348263dc26: animation_animall: Fix T69509 Quick smoke broken.Jan 21 2020, 5:27 PM