Maniphest T69742

Build all features when running "make" or manually using CMake
Closed, ResolvedTO DO
Actions

Assigned To
Brecht Van Lommel (brecht)
Authored By
Brecht Van Lommel (brecht)
Sep 11 2019, 10:24 AM
Tags
  • Platforms, Builds, Tests & Devices
Subscribers
Bastien Montagne (mont29)
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Sergey Sharybin (sergey)
Tokens
"Love" token, awarded by sergey.

Description

Currently, a seemingly arbitrary subset of features is enabled by default in our CMake configuration. Most users and developers building Blender want "make full", and I think that should be the default. This not being the case has caused a fair amount of confusion for people building Blender.

If there is a need for a configuration that is somewhere between "lite" and "full", that could be added. However my guess is that the defaults are mostly there for historical reasons. From before we had CMake code to dynamically detect if libraries are found, and before install_deps.sh to automate installing dependencies.

Revisions and Commits

rB Blender
D6306rBbbd5f30ad62c Build: change CMake option defaults to match "make full"

Related Objects

Event Timeline

Brecht Van Lommel (brecht) lowered the priority of this task from 90 to Normal.Sep 11 2019, 10:24 AM
Brecht Van Lommel (brecht) created this task.
Brecht Van Lommel (brecht) updated the task description.Sep 11 2019, 10:26 AM
Brecht Van Lommel (brecht) added subscribers: Bastien Montagne (mont29), Sergey Sharybin (sergey), Campbell Barton (campbellbarton).

Agreed about this with @Sergey Sharybin (sergey) recently, but would like to hear from @Campbell Barton (campbellbarton) or @Bastien Montagne (mont29) if there are reasons not to make this change.

Brecht Van Lommel (brecht) mentioned this in T66306: Platforms, Builds & Tests Module.Sep 11 2019, 10:28 AM
Brecht Van Lommel (brecht) updated the task description.
Bastien Montagne (mont29) added a comment.Sep 11 2019, 10:41 AM

I 100% support building everything by default. If things are still missing on libs/deps side to allow it, then we should address it (but don’t think that’s the case).

We'll also want to enable the --with-all option of install_deps.sh then I guess? Currently default run won't install OpenCollada (and a few other things iirc).

Sergey Sharybin (sergey) awarded a token.Sep 11 2019, 10:42 AM
Brecht Van Lommel (brecht) mentioned this in D6306: Build: change CMake option defaults to match "make full".Nov 25 2019, 6:09 PM
Brecht Van Lommel (brecht) changed the task status from Unknown Status to Resolved by committing rBbbd5f30ad62c: Build: change CMake option defaults to match "make full".Nov 28 2019, 7:22 PM
Brecht Van Lommel (brecht) claimed this task.
Brecht Van Lommel (brecht) added a commit: rBbbd5f30ad62c: Build: change CMake option defaults to match "make full".
Brecht Van Lommel (brecht) added a comment.Nov 28 2019, 8:13 PM

Regarding enabling --with-all in install_deps.sh, that sounds better to me. I don't know the reason behind the defaults there though.