Maniphest T69818

Transform: Rethink the flags used in 't->flag'
Closed, ArchivedTO DO

Assigned To
None
Authored By
Germano Cavalcante (mano-wii)
Sep 12 2019, 10:52 PM
Tags
  • BF Blender
  • Modeling
Subscribers
Germano Cavalcante (mano-wii)

Description

Many of them just indicate the type of object being transformed (T_OBJECT, T_POSE, T_CURSOR) thus repeating what is indicated in t->options.
Because they don't describe what they do, many areas in the code are confusing making exceptions for the object type.
For example:

if (t->flag & (T_OBJECT | T_TEXTURE | T_POSE)) {
  float obsizemat[3][3];
  /* Reorient the size mat to fit the oriented object. */
  mul_m3_m3m3(obsizemat, tmat, td->axismtx);
  /* print_m3("obsizemat", obsizemat); */
  TransMat3ToSize(obsizemat, td->axismtx, fsize);
  /* print_v3("fsize", fsize); */
}

Event Timeline

Germano Cavalcante (mano-wii) lowered the priority of this task from 90 to Normal.Sep 12 2019, 10:52 PM
Germano Cavalcante (mano-wii) created this task.
Germano Cavalcante (mano-wii) mentioned this in T68836: Transform Refactoring.
Aaron Carlisle (Blendify) added projects: BF Blender, Modeling.Feb 10 2020, 6:24 PM
Campbell Barton (campbellbarton) moved this task from Backlog to Todo (Transform) on the Modeling board.Jun 17 2020, 3:13 PM
Germano Cavalcante (mano-wii) closed this task as Archived.Feb 3 2021, 10:18 PM

Although it is interesting to reduce the flags and better separate what is TransInfo.context and what is TransInfo.flag, this does not seem to be something worth re-thinking and redoing at once.
It seems convenient to work on it gradually.
So I don't think you can set a goal for when this will be resolved.