Maniphest T70564

Sculpt Mask not visible (Show mask enabled)
Closed, ResolvedBUG
Actions

Assigned To
Brecht Van Lommel (brecht)
Authored By
Henrik Abreu (kafonah)
Oct 5 2019, 6:24 PM
Tags
  • BF Blender
  • Sculpt, Paint & Texture
  • Modifiers
Subscribers
Brecht Van Lommel (brecht)
Henrik Abreu (kafonah)
Jeroen Bakker (jbakker)
Julien Kaspar (JulienKaspar)
Philipp Oeser (lichtwerk)
Sergey Sharybin (sergey)

Description

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 388.13

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: rBf6cb5f54494e
Worked: (optional)

Short description of error
I can't see the mask when sculpting my mesh, even if Mask is checked in Viewport Overlays and Show Mask is checked in Options. The mask is working but i can't see it.

Exact steps for others to reproduce the error
Just try to mask the CC_Base_Body mesh.

Revisions and Commits

rB Blender
rBd7465c23c749 Fix T70564: sculpt mask display missing with shape keys or deforming modifiers

Related Objects

Mentioned In
T67303: mask visibility in sculpt mode using shape keys
Mentioned Here
rB692891f69ea4: Fix sculpt mode drawing with modifiers still being wrong in some cases
rBd0fb602e2c36: DrawManager: Sculpt Mesh Drawing

Event Timeline

Henrik Abreu (kafonah) renamed this task from **Mask not visible** (Show mask enabled) to Mask not visible (Show mask enabled).Oct 5 2019, 6:24 PM
Henrik Abreu (kafonah) created this task.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Oct 7 2019, 9:54 AM

Hm, I can confirm there is something wrong here, I can only get it to work if I delete all shapekeys and disable all modifiers in the viewport...
Needs more investigation...

Philipp Oeser (lichtwerk) added projects: Sculpt, Paint & Texture, Modifiers.Oct 7 2019, 9:58 AM
Julien Kaspar (JulienKaspar) added subscribers: Sergey Sharybin (sergey), Julien Kaspar (JulienKaspar).Oct 7 2019, 12:36 PM

@Philipp Oeser (lichtwerk) Just for clarification, Blender does tell the user that "Hide, Mask and optimised display is disabled" when modifiers are being used.
But at some point last year, @Sergey Sharybin (sergey) at least implemented that masks are visible when using shapekeys, as far as I remember. This feature seems to be gone now.

Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.Oct 7 2019, 1:10 PM

Will confirm for now, I am bisecting atm... [to at least know when this changed...]

Julien Kaspar (JulienKaspar) added a comment.EditedOct 7 2019, 2:02 PM

@Philipp Oeser (lichtwerk) I talked with sergey and apparently it only got implemented in 2.79 and didn't transition over to 2.8.

Edit: I tried out 2.79 and apparently it was never implemented. Masks are invisible with shapekeys unless they are pinned.

Philipp Oeser (lichtwerk) raised the priority of this task from 50 to High.Oct 7 2019, 2:08 PM
Philipp Oeser (lichtwerk) added a subscriber: Jeroen Bakker (jbakker).

This started getting weird with rBd0fb602e2c36 (here sculpt mask strokes would still be visible while doing the stroke, but chances are high these get invisible when stroke ends, then on a new stroke everything gets visible again, ...)

Still need to check/bisect when this broke "completely"...

CC @Jeroen Bakker (jbakker)

(not completely sure how severe this is, but since it seems a regression, will put on High prio for now...)

Philipp Oeser (lichtwerk) renamed this task from Mask not visible (Show mask enabled) to Sculpt Mask not visible (Show mask enabled).Oct 7 2019, 2:09 PM
Philipp Oeser (lichtwerk) added a subscriber: Brecht Van Lommel (brecht).Oct 7 2019, 2:28 PM

Looks like this was the nail in the coffin rB692891f69ea4
CC @Brecht Van Lommel (brecht)

@Julien Kaspar (JulienKaspar) : not sure about the "sculpt-on-shapekey" thingie, in this file there are shapekeys but non is actually active (they are all zero or you can disable them all)

At least sculpt mask was visible before rBd0fb602e2c36, rB692891f69ea4 in this setup, so maybe others can comment...

Brecht Van Lommel (brecht) changed the task status from Unknown Status to Resolved by committing rBd7465c23c749: Fix T70564: sculpt mask display missing with shape keys or deforming modifiers.Oct 7 2019, 5:39 PM
Brecht Van Lommel (brecht) claimed this task.
Brecht Van Lommel (brecht) added a commit: rBd7465c23c749: Fix T70564: sculpt mask display missing with shape keys or deforming modifiers.
Julien Kaspar (JulienKaspar) mentioned this in T67303: mask visibility in sculpt mode using shape keys.Oct 9 2019, 2:37 PM
Henrik Abreu (kafonah) updated the task description.Nov 9 2019, 11:21 PM