Maniphest T70875

Library Override: Clicking an Library Overriden Object crashes Blender
Closed, Resolved
Actions

Assigned To
Bastien Montagne (mont29)
Authored By
J. Kissel (Masterheavy)
Oct 16 2019, 3:14 PM
Tags
  • BF Blender
  • Datablocks and Libraries
Subscribers
Alex (SpectreFirst)
Bastien Montagne (mont29)
German Casado Fraga (germanobanano)
J. Kissel (Masterheavy)
Jacques Lucke (JacquesLucke)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.15

Blender Version
Broken: version: 2.81 (sub 11), branch: master, commit date: 2019-09-16 21:02, hash: rB76650402f300
Worked: (optional)

Short description of error
When clicking an linked object that is marked as Library Override Blender crashes

Exact steps for others to reproduce the error

  • Open a Fresh Scene
  • link an Collection
  • rightclick in outliner to add library override
  • click object again -> crash

or second variant

  • open a Fresh Scene
  • link Object from different file
  • hit add Library override results in a crash and blender closes

[Based on the default startup or an attached .blend file (as simple as possible)]

Revisions and Commits

rB Blender
rB74af6987699a Fix T70875: Library Override: Clicking an Library Overriden Object crashes…

Related Objects

Event Timeline

J. Kissel (Masterheavy) created this task.Oct 16 2019, 3:14 PM
J. Kissel (Masterheavy) updated the task description.
Jacques Lucke (JacquesLucke) assigned this task to Bastien Montagne (mont29).Oct 16 2019, 4:13 PM
Jacques Lucke (JacquesLucke) lowered the priority of this task from 90 to 50.
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).

I can reproduce it using the second variant.

outliner_add_layer_collection_objects(SpaceOutliner * soops, ListBase * tree, ViewLayer * layer, LayerCollection * lc, TreeElement * ten) (/home/jacques/blender-git/blender/source/blender/editors/space_outliner/outliner_tree.c:1365)
outliner_add_layer_collections_recursive(SpaceOutliner * soops, ListBase * tree, ViewLayer * layer, ListBase * layer_collections, TreeElement * parent_ten, const _Bool show_objects) (/home/jacques/blender-git/blender/source/blender/editors/space_outliner/outliner_tree.c:1409)
outliner_add_view_layer(SpaceOutliner * soops, ListBase * tree, TreeElement * parent, ViewLayer * layer, const _Bool show_objects) (/home/jacques/blender-git/blender/source/blender/editors/space_outliner/outliner_tree.c:1426)
outliner_build_tree(Main * mainvar, Scene * scene, ViewLayer * view_layer, SpaceOutliner * soops, ARegion * ar) (/home/jacques/blender-git/blender/source/blender/editors/space_outliner/outliner_tree.c:2417)
draw_outliner(const bContext * C) (/home/jacques/blender-git/blender/source/blender/editors/space_outliner/outliner_draw.c:3636)
outliner_main_region_draw(const bContext * C, ARegion * ar) (/home/jacques/blender-git/blender/source/blender/editors/space_outliner/space_outliner.c:93)
ED_region_do_draw(bContext * C, ARegion * ar) (/home/jacques/blender-git/blender/source/blender/editors/screen/area.c:534)
wm_draw_window_offscreen(bContext * C, wmWindow * win, _Bool stereo) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:629)
wm_draw_window(bContext * C, wmWindow * win) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:765)
wm_draw_update(bContext * C) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:947)
WM_main(bContext * C) (/home/jacques/blender-git/blender/source/blender/windowmanager/intern/wm.c:423)
main(int argc, const char ** argv) (/home/jacques/blender-git/blender/source/creator/creator.c:491)
Alex (SpectreFirst) added a subscriber: Alex (SpectreFirst).Oct 17 2019, 1:15 PM
Bastien Montagne (mont29) added a comment.Oct 17 2019, 3:15 PM

That is almost certainly a missing ID tagging for the depsgraph/COW, but am still trying to find what’s missing here... :/

Philipp Oeser (lichtwerk) renamed this task from Clicking an Libary Overrided Object crashes Blender to Library Override: Clicking an Library Overriden Object crashes Blender.Oct 23 2019, 3:05 PM
Philipp Oeser (lichtwerk) added a project: Datablocks and Libraries.
Bastien Montagne (mont29) merged a task: T71318: Library Override: Crash - when creating a library override of linked object.Nov 4 2019, 4:05 PM
Bastien Montagne (mont29) added subscribers: German Casado Fraga (germanobanano), Bastien Montagne (mont29), Philipp Oeser (lichtwerk).
Bastien Montagne (mont29) changed the task status from Unknown Status to Resolved by committing rB74af6987699a: Fix T70875: Library Override: Clicking an Library Overriden Object crashes….Nov 7 2019, 4:19 PM
Bastien Montagne (mont29) added a commit: rB74af6987699a: Fix T70875: Library Override: Clicking an Library Overriden Object crashes….
Bastien Montagne (mont29) mentioned this in T71030: Library Override: Lots of operators allow to add objects to overridden collections, which is not currently supported (lost on save).Nov 7 2019, 6:37 PM