Maniphest T71455

Transform: Redo doesn't work properly in Video Sequencer time manipulation
Closed, ResolvedBUG
Actions

Assigned To
Germano Cavalcante (mano-wii)
Authored By
Alessio Monti di Sopra (a.monti)
Nov 9 2019, 6:39 PM
Tags
  • BF Blender
  • Modeling
Subscribers
Alessio Monti di Sopra (a.monti)
Germano Cavalcante (mano-wii)

Description

Blender Version
Broken: 2.82

Description of error(s)
Redo doesn't work properly in Video Sequencer Move/Extend from Playhead (TIME_EXTEND mode).

Exact steps for others to reproduce the error

  1. Position the current frame in the middle of a selected strip
  2. Press E to activate the operator, with the mouse cursor on either side of the strip, to move one of its side
  3. Try to modify the result with the redo panel -> the strip will shift, as if both handles were being modified

Revisions and Commits

rB Blender
rBa4df7f78a881 Fix T75398: Redo with Shift R always uses the previous pivot center
D6852rBa33b261473e9 Fix T71455, T73852, T73860: Transform, Redo doesn't work properly in time…

Related Objects

Mentioned In
rB6ebad22091c0: Transform: fix rotate redo behavior

Event Timeline

Alessio Monti di Sopra (a.monti) created this task.Nov 9 2019, 6:39 PM
Alessio Monti di Sopra (a.monti) assigned this task to Germano Cavalcante (mano-wii).Nov 9 2019, 6:44 PM

Here it is, if you prefer I can make separate reports for each operator, but they seemed quite related to me.

Germano Cavalcante (mano-wii) lowered the priority of this task from 90 to 50.Nov 9 2019, 8:19 PM
Germano Cavalcante (mano-wii) added a project: Modeling.

Well, it's usually better separated.
But I think that's fine, it looks like it can be solved in a single commit.

Dalai Felinto (dfelinto) removed Germano Cavalcante (mano-wii) as the assignee of this task.Dec 23 2019, 1:44 PM
Dalai Felinto (dfelinto) added a project: Tracker Curfew.
Dalai Felinto (dfelinto) added a subscriber: Germano Cavalcante (mano-wii).
Germano Cavalcante (mano-wii) claimed this task.Jan 25 2020, 12:07 AM
Germano Cavalcante (mano-wii) changed the subtype of this task from "Report" to "Bug".
Germano Cavalcante (mano-wii) removed a project: Tracker Curfew.
Germano Cavalcante (mano-wii) added a comment.Feb 14 2020, 6:08 PM

Thansk for the report.
I tried to reproduce each of the problems but I was only able to replicate the "Graph editor Extend (TIME_EXTEND mode)".

So I will remove these other problems from the description, as they are different:

  • Graph editor Extend (TIME_EXTEND mode):
    1. Select a keyframe or a handle and press E to activate the operator
    2. Try to modify the result with the redo panel -> both x and y value are inverted in the panel, resulting in a mirrored transformation
  • NLA Extend (TIME_EXTEND mode):
    1. same steps as for the video sequencer case, but the result will also be mirrored
  • NLA Move :
    1. Select a strip and press G to move it
    2. Try to tweak the result -> the result gets mirrored
  • DopeSheet Extend (TIME_EXTEND mode):
    1. Select two or more keyframes and put the current frame somewhere in between them
    2. Press E to activate the operator
    3. Tweak the operation -> same result as for the vse case, all the keyframes will move

If you are still able to reproduce any of these problems, please create another report.

Germano Cavalcante (mano-wii) renamed this task from Transform operator: Redo doesn't work properly in time manipulation modes to Transform: Redo doesn't work properly in Video Sequencer time manipulation.Feb 14 2020, 6:11 PM
Germano Cavalcante (mano-wii) updated the task description.
Germano Cavalcante (mano-wii) updated the task description.Feb 14 2020, 6:15 PM
Germano Cavalcante (mano-wii) added a revision: D6852: Fix T71455: Redo doesn't work properly in Video Sequencer.
Alessio Monti di Sopra (a.monti) added a comment.Feb 15 2020, 7:55 PM

Hi! Yes, I can reproduce all of them.
I'll make 4 separate reports then, or for the Graph editor one it's not needed?

Germano Cavalcante (mano-wii) added a comment.Feb 15 2020, 8:06 PM
In T71455#872439, @Alessio Monti di Sopra (a.monti) wrote:

Hi! Yes, I can reproduce all of them.
I'll make 4 separate reports then, or for the Graph editor one it's not needed?

If you're sure it's a different bug, I don't see why not.
But please give us more clear instructions on how to reproduce it from scratch.

Alessio Monti di Sopra (a.monti) added a comment.Feb 15 2020, 8:55 PM
In T71455#872447, @Germano Cavalcante (mano-wii) wrote:

If you're sure it's a different bug, I don't see why not.
But please give us more clear instructions on how to reproduce it from scratch.

I'm not sure of anything 🙂
They for sure seem related to each other, so I guess they could be solved in a similar way, but that transform code was a bit too much for me to look into.
I'll try to make the steps clearer in the new reports.

Germano Cavalcante (mano-wii) mentioned this in rB6ebad22091c0: Transform: fix rotate redo behavior.Feb 17 2020, 5:21 PM
Germano Cavalcante (mano-wii) closed this task as Resolved by committing rBa33b261473e9: Fix T71455, T73852, T73860: Transform, Redo doesn't work properly in time….Feb 17 2020, 5:33 PM
Germano Cavalcante (mano-wii) added a commit: rBa33b261473e9: Fix T71455, T73852, T73860: Transform, Redo doesn't work properly in time….
Germano Cavalcante (mano-wii) added a commit: rBa4df7f78a881: Fix T75398: Redo with Shift R always uses the previous pivot center.Apr 27 2020, 5:08 PM