Maniphest T71517

Undo when sculpting with dyntopo ON, turns off dyntopo if brush changed
Closed, Resolved

Assigned To
Dalai Felinto (dfelinto)
Authored By
Ravi Kumar Singh (rkspsm)
Nov 12 2019, 4:25 PM
Tags
  • BF Blender
  • Sculpt, Paint & Texture
Subscribers
Dalai Felinto (dfelinto)
Erick Tukuniata (erickblender)
Philipp Oeser (lichtwerk)
Ravi Kumar Singh (rkspsm)
Stanislav Blinov (radcapricorn)

Description

System Information
Operating system: Linux-5.3.8-arch1-1-x86_64-with-arch 64 Bits
Graphics card: GeForce GTX 960/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-11 18:30, hash: rB8c9e6f123a2b
Worked: 2.80 (sub 75), branch: makepkg, commit date: 2019-07-29 14:47, hash: rBf6cb5f54494e

Short description of error
When sculpting with dyntopo ON, undoing after the first stroke after changing the brush, turns off dyntopo.

Exact steps for others to reproduce the error

  • Go to sculpt mode with any mesh, say a Cube.
  • Turn on dyntopo.
  • Do some sculpting.
  • Change the brush.
  • Make one stroke, can be a long one, but only one stroke.
  • Undo
  • The last stroke is gone, but dyntopo is turned off.

Event Timeline

Ravi Kumar Singh (rkspsm) created this task.Nov 12 2019, 4:25 PM
Stanislav Blinov (radcapricorn) added a subscriber: Stanislav Blinov (radcapricorn).Nov 12 2019, 4:43 PM

Can't reproduce here with the specified Blender version.

Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 30.Nov 12 2019, 4:53 PM
Philipp Oeser (lichtwerk) added a project: Sculpt, Paint & Texture.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Also cannot reproduce.

Does this happen with Factory Defaults as well? (File → Defaults → Load Factory Settings)

Ravi Kumar Singh (rkspsm) added a comment.Nov 12 2019, 11:24 PM
In T71517#809829, @Philipp Oeser (lichtwerk) wrote:

Also cannot reproduce.

Does this happen with Factory Defaults as well? (File → Defaults → Load Factory Settings)

With or without factory settings, its occuring, just checked.

However, it happens only if both brush selection and Undo is done via shortcut keys. It doesnt happen if I select brush from the menu or use the undo from the menu via mouse or tablet.

Ravi Kumar Singh (rkspsm) added a comment.Nov 13 2019, 1:46 AM

Also, just noticed and tested for few minutes. If I assign shortcuts by right clicking on the brushes in the tools sidebar and use those shortcuts, this bug will not occur. Its only occurring if I assign shortcuts from keymap in preferences.

Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Nov 13 2019, 4:21 AM

Which shortcuts you are using to select your brush? If you save the file with the brush selected, open it, then sculpt and undo do you have the problem still?

Ravi Kumar Singh (rkspsm) added a comment.Nov 13 2019, 5:05 AM

In factory mode, I used the default keys. I just tested with :

  • open blender
  • preferences -> load factory settings
  • new file
  • delete everything
  • add new cube
  • go to sculpt mode
  • enable dyntopo
  • picked some brush other than draw (inflate in this case)
  • did some sculpting
  • pressed X to pick draw brush
  • sculpted just one stroke
  • pressed ctrl-z for undo

At this point, the bug occurs. Stroke disappears but dyntopo turns off.

Ravi Kumar Singh (rkspsm) added a comment.Nov 13 2019, 5:08 AM

That also happens if I load the file. I load a file (still in factory settings), pressed X to pick draw brush, made one stroke, ctrl-z for undo. The bug occurred.

Ravi Kumar Singh (rkspsm) added a comment.Nov 13 2019, 5:53 AM

Tested on this version also, which is just released : 2.81 (sub 16), branch: master, commit date: 2019-11-12 13:28, hash: rB125257758007

Furthuremore, I can now reproduce bug in a different way. In undo history, anytime I go back to "brush select" or "radial control", the dyntopo gets disabled, regardless of how many strokes I did.

Erick Tukuniata (erickblender) added a subscriber: Erick Tukuniata (erickblender).Nov 13 2019, 9:54 AM

I can reproduce it in win7 550ti gtx following this instructions:

  • with factories setting loaded
  • activate dyntopo
  • Pick another brush than the default draw
  • with the new brush selected sculpt some
  • here is the main problem: use the shortcut x-key to activate the draw brush sculpt only one stroke and undo. after this dyntopo will be deactivated.

Point to note: if you select the draw brush with mouse selection, you wouldn't see the problem. If you sculpt many stokes with " xkey activated" draw brush, you have to undo all of them before you see Dyntopo deactivated.

Ravi Kumar Singh (rkspsm) added a comment.Nov 13 2019, 10:18 AM
In T71517#810119, @Erick Tukuniata (erickblender) wrote:

Point to note: if you select the draw brush with mouse selection, you wouldn't see the problem. If you sculpt many stokes with " xkey activated" draw brush, you have to undo all of them before you see Dyntopo deactivated.

Yeah, it probably has something to do with this bug triggering only when next thing to undo is something other than a brush stroke. And selecting brush by clicking from mouse is not registered as undoable action. But selecting brush by hotkey setup from preferences does, as can be seen by an entry in undo history. It also happens with radial control, because changing brush size etc by radial control does gets registered as undoable action.

Ravi Kumar Singh (rkspsm) added a comment.Nov 16 2019, 2:27 PM

Checked in version: 2.81 (sub 16), branch: master, commit date: 2019-11-15 16:32, hash: rBeba4a4bd73ba

Seems to be resolved. Changing brush by keys, or changing brush properties via radial control are no longer registering as undoable actions via sculpting, so the issue of dyntopo turning off mid sculpt is gone.

Dalai Felinto (dfelinto) changed the task status from Unknown Status to Resolved.Nov 16 2019, 4:16 PM
Dalai Felinto (dfelinto) claimed this task.
Dalai Felinto (dfelinto) raised the priority of this task from 30 to Normal.