Maniphest T71519

rotating hdri images even very low res ones is really slow in this version
Closed, Archived

Assigned To
Brecht Van Lommel (brecht)
Authored By
michael campbell (3di)
Nov 12 2019, 4:47 PM
Tags
  • BF Blender
Subscribers
Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)
michael campbell (3di)

Description

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.86

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-12 13:28, hash: rB125257758007
Worked: (optional)

Short description of error
rotating hdri images even very low res ones is really slow in this version

Exact steps for others to reproduce the error
go into the world tab and use the mapping node to rotate a 4 k hdri. There's a really long pause compared to the previous daily builds. I haven't noticed this problem before, since intermittently upgrading daily builds from 2.80 upwards. Even happens with textures limited to 128 in the simplify tab. This is using cycles in the viewport render in gpu experimental mode. same for non experimental too. I used to be able to get almost instantaneous feedback in the viewport render, now the wait is too long to be able to interactively see the difference in lighting, just have to enter a number with the keyboard and wait now.

Event Timeline

michael campbell (3di) created this task.Nov 12 2019, 4:47 PM
michael campbell (3di) updated the task description.
michael campbell (3di) added a comment.Nov 12 2019, 5:49 PM

I think the coding of the background shader or environment texture must have changed somehow, because adding new ones seem to be back working as expected....although I did think that the behaviour of the slider used to update the render as you moved, now it seems to only update the render on mouse release which takes away the interactivity somewhat (which is important when tweaking lighting).

Might want to add a bit of code to upgrade the old node to the new node to avoid any more bug reports?

Dalai Felinto (dfelinto) lowered the priority of this task from 90 to 30.Nov 13 2019, 2:59 AM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

Can you confirm that the official 2.80 release does not present this problem?

michael campbell (3di) added a comment.Nov 13 2019, 3:48 AM

2.8 was very fast to update modifications to the hdri rotation, strength etc (the same as 2.81 is now that I deleted and replaced the environment texture node and the background shader). I was mistaken regarding 2.81 not initiating the update until the mouse button is released though, it updates when mouse movement has stopped for a second or two whilst the mouse button is still depressed.

Just to clarify, 2.81 and 2.8 both began the update process at the same time, but 2.81 was taking around 10 seconds to restart viewport rendering, whereas 2.8 restarted the viewport render in under a second.

Not an issue now I deleted and replaced the nodes, so presumably the code for one of those two nodes has changed between versions.

Brecht Van Lommel (brecht) changed the task status from Unknown Status to Unknown Status.Nov 13 2019, 2:28 PM
Brecht Van Lommel (brecht) claimed this task.
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

It's because background multiple importance sampling is now enabled by default, which requires a rebuild when rotating.

We would like to optimize this in the future, but it's not a bug.

michael campbell (3di) added a comment.Nov 13 2019, 2:30 PM
In T71519#810297, @Brecht Van Lommel (brecht) wrote:

It's because background multiple importance sampling is now enabled by default, which requires a rebuild when rotating.

We would like to optimize this in the future, but it's not a bug.

why would recreating the node resolve the issue?

Brecht Van Lommel (brecht) added a comment.Nov 13 2019, 2:45 PM

I'm not sure. But the bug report is missing the actual .blend / image file and steps to reproduce the bug, since only steps to create new nodes are provided and those apparently work ok.

So, we must have that information first to confirm that it's indeed a different issue than just multiple importance sample updating.

michael campbell (3di) added a comment.Nov 13 2019, 2:52 PM

ah ok, I couldnt share the file as it's under NDA,. If you want to replicate, you could create a scene in 2.8 which has a hdri, and then open it the latest daily build. It's definitely not caused by multiple importance sampling now being the default, otherwise new nodes would have had the same issue. I'll leave it with you.

Brecht Van Lommel (brecht) added a comment.EditedNov 13 2019, 3:00 PM

Have you verified that creating a mapping + environment texture node in 2.80 and then loading it in 2.81 actually reproduces the problem? It didn't for me.

We don't require the original file in bug reports, just any .blend file and exact steps to reproduce the problem. Otherwise we waste time guessing what might be the problem.

michael campbell (3di) added a comment.Nov 13 2019, 3:11 PM

The original file may have been created in one of the previous daily builds somewhere between 2.8 and yesterdays daily 2.81 build, I'm not sure which. When I've finished these few projects I'll have a dig around to try and find another file which has the same issue, or hopefully before then someone else will experience the same problem with a file they can share.

Awesome job to everyone over there by the way, I'd marry this program if it was legal :)