Maniphest T71793

[accessibility] Change default cursor color to increase the contrast with background
Closed, Resolved

Assigned To
Harley Acheson (harley)
Authored By
Valentin (Poulpator)
Nov 22 2019, 11:14 PM
Tags
  • BF Blender
  • User Interface
Subscribers
Hans Goudey (HooglyBoogly)
Harley Acheson (harley)
Philipp Oeser (lichtwerk)
ThinkingPolygons (ThinkingPolygons)
Valentin (Poulpator)
William Reynish (billreynish)

Description

System Information
Operating system: Windows
Graphics card:GTX 970

Blender Version
Broken: >2.8
Worked: (optional)

Short description of error

Currently blender use red cursor on background black and dark grey (on both light and dark theme) which is difficult to see
some may think this is just matter of preference but it's not, for people with vision impairment e.g : colorblind people.

Exact steps for others to reproduce the error

Related Objects

Mentioned Here
rBb374b24f1b2d: UI: Widget Text Cursor Color
D6295: UI: Widget Text Cursor Color

Event Timeline

Valentin (Poulpator) created this task.Nov 22 2019, 11:14 PM
Valentin (Poulpator) added a project: User Interface.Nov 22 2019, 11:18 PM
William Reynish (billreynish) lowered the priority of this task from 90 to 30.Nov 23 2019, 1:50 AM
William Reynish (billreynish) added a subscriber: William Reynish (billreynish).

By default the cursor in Blender is just the default system arrow cursor.

Harley Acheson (harley) added a subscriber: Harley Acheson (harley).Nov 23 2019, 3:10 AM

@William Reynish (billreynish) - I think he means the Blender 3D cursor, not the mouse cursor. Could use some love to work better on very dark and very dark backgrounds. And maybe thought through for color blindness too.

Valentin (Poulpator) added a comment.Nov 23 2019, 3:16 AM

Sorry I wasn't specific enought. I mean the text cursor

this one{F8157279}

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).EditedNov 23 2019, 3:22 AM

I'm not sure why the text editor cursor is red anyway. The cursor everywhere else in Blender is colored by the theme to be a blue that goes well with everything else in the interface.

I would think there would be a global text cursor color defined in the theme and it wouldn't be local to different spaces.

Harley Acheson (harley) added a comment.Nov 23 2019, 3:51 AM

But then why not change it in the theme settings?

ThinkingPolygons (ThinkingPolygons) added a subscriber: ThinkingPolygons (ThinkingPolygons).Nov 23 2019, 4:12 AM
In T71793#815693, @Harley Acheson (harley) wrote:

But then why not change it in the theme settings?

I didn't know about that cursor color property. But this is weird. What about the other text cursors in the rest of the application, is there a hidden property too? They seem to be hardcoded. Why can't they all share the same color property?

Harley Acheson (harley) added a comment.Nov 23 2019, 6:03 PM

@ThinkingPolygons (ThinkingPolygons) - What about the other text cursors in the rest of the application, is there a hidden property too? They seem to be hardcoded. Why can't they all share the same color property?

Oh you mean while entering text or a number into a regular UI element, for example in Properties or Preferences? Yes that is hardcoded (0.2, 0.6, 0.9). That could be fixed if I can find a nice central place to put such a theme preference. In the "Styles" section perhaps?

Why can't they all share the same color property?

We give the ability to have different background colors in the Console Editor and the Text Editor so it makes sense that you might need a different color for the text insertion caret for those two.

Valentin (Poulpator) added a comment.Nov 23 2019, 7:16 PM
In T71793#815693, @Harley Acheson (harley) wrote:

But then why not change it in the theme settings?

This is what I did, but I still think that when accessibility come with literally no downside, it should be the default, also well differentiate foreground and background is a bit "web design 101"

ThinkingPolygons (ThinkingPolygons) added a comment.Nov 23 2019, 7:33 PM
In T71793#816028, @Harley Acheson (harley) wrote:

Oh you mean while entering text or a number into a regular UI element, for example in Properties or Preferences?

Yeah, those ones.

In the "Styles" section perhaps?

Why not? ?

But yeah, currently those are literally almost impossible to see, doesn't matter which theme. A theme setting would be a savior lol.

Harley Acheson (harley) added a comment.Nov 23 2019, 7:33 PM

@Valentin (Poulpator) This is what I did, but I still think that when accessibility come with literally no downside, it should be the default, also well differentiate foreground and background is a bit "web design 101"

So this topic is just about the default colors set in the themes that ship with Blender and that can be changed at any time to suit individuals?

And you are asking for some change but have not proposed anything specific. Are you asking us to just make a better guess? Anything but red?

Harley Acheson (harley) added a comment.Nov 23 2019, 7:47 PM

@ThinkingPolygons (ThinkingPolygons) - ...those are literally almost impossible to see, doesn't matter which theme.

Yes, I've got something almost ready. It'll also fix the oversight that the width of the thing does not change with user scale or dpi. So it gets harder to see if you are using a high-dpi display like Retina.

ThinkingPolygons (ThinkingPolygons) added a comment.Nov 23 2019, 8:10 PM

@Harley Acheson (harley) Amazing. ?

Harley Acheson (harley) added a comment.Nov 23 2019, 9:18 PM

This should add ability to change that text insertion cursor color outside of Text Editor and Python console:

https://developer.blender.org/D6295

Philipp Oeser (lichtwerk) assigned this task to Harley Acheson (harley).Dec 5 2019, 3:40 PM
Philipp Oeser (lichtwerk) raised the priority of this task from 30 to Normal.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

@Harley Acheson (harley) : mind if I assign to you?
(just cleaning up tracker status here...)

Harley Acheson (harley) changed the task status from Unknown Status to Resolved.Dec 5 2019, 4:12 PM

Closing and setting to resolved.

With this commit... https://developer.blender.org/rBb374b24f1b2dea4360f318fe3c86bede00bdaae4

Can now set text cursor color for Ui widgets. Could already set theme color for text cursor in text editor and python console so can do that everywhere now.