Maniphest T72130

Wireframe overlay still visible after turning it off
Closed, ResolvedBUG
Actions

Assigned To
Jeroen Bakker (jbakker)
Authored By
Val Acar (valacar)
Dec 2 2019, 11:20 PM
Tags
  • BF Blender
Subscribers
Jeroen Bakker (jbakker)
Maciej Jutrzenka (Kramon)
Val Acar (valacar)

Description

System Information
Operating system: Linux-5.3.11-1-MANJARO-x86_64-with-arch-Manjaro-Linux 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
Broken: version: 2.82 (sub 3), branch: master, commit date: 2019-12-02 18:02, hash: rB1e480840a212
Worked: 2.82 (sub 1), branch: master, commit date: 2019-11-17 21:26, hash: 6d9d24e3d459, type: Release
Worked: 2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash: 26bd5ebd42e3, type: Release

Note: 2.82.3 was compiled by me, so hopefully this isn't the issue. I will test with a fresh download from the Blender website later.

Short description of error
Wireframe overlay is still visible after turning it off, after entering and exiting edit mode.

Exact steps for others to reproduce the error

  1. File > Defaults > Load Factory Settings
  2. In the top right of the 3D viewport, click the Overlay drop down panel and enable Wireframe
  3. Press Tab to enter edit mode
  4. Press Tab to exit edit mode
  5. In the top right of the 3D viewport, click the Overlay drop down panel and disable Wireframe
  6. Deselect the object (Alt-a)

After doing this, the wireframe is still visible. Adding a new object or duplicating the cube will (correctly) result in an object without wireframe, while the original cube will still show it.

Revisions and Commits

rB Blender
D6349rB9c337fcfe2a4 Fix T72130: Wireframe Visible After Disabling

Related Objects

Mentioned In
T80393: Wireframe slider is faded in wireframe shading mode when overlays are off
Mentioned Here
rB26bd5ebd42e3: Update rest of submodules to correct commit for Blender 2.81 release

Event Timeline

Val Acar (valacar) created this task.Dec 2 2019, 11:20 PM
Maciej Jutrzenka (Kramon) added a subscriber: Maciej Jutrzenka (Kramon).EditedDec 3 2019, 4:37 AM

i have this bug all the time when wireframe is staying and u have to go to object mode >> edit mode >> object mode and it disapears.. however it is still visible on all other objects so u have to go every single one or just restart blender. i had it on 2.81 official

ubunu 18.04 LTS

Jeroen Bakker (jbakker) claimed this task.Dec 3 2019, 8:11 AM
Jeroen Bakker (jbakker) lowered the priority of this task from 90 to High.
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).

Thanks for the report, we have refactoring this part last week, so it can be that some of these regressions happen.

Jeroen Bakker (jbakker) added a revision: D6349: Fix T72130: Wireframe Visible After Disabling.Dec 3 2019, 8:34 AM
Jeroen Bakker (jbakker) added a comment.Dec 3 2019, 2:31 PM

Ok, issue seems to be that ibo.lines is filled so isn't requested. As it isn't requested the ibo contains all lines.
my solution would be to add a separate ibo.loose_lines that will be constructed of the existing ibo.lines.

This will keep the performance the same as we currently have, but might need an architectural exception as we construct an ibo based on another ibo.
Will first test if this will work....

Jeroen Bakker (jbakker) changed the task status from Unknown Status to Resolved by committing rB9c337fcfe2a4: Fix T72130: Wireframe Visible After Disabling.Dec 4 2019, 3:17 PM
Jeroen Bakker (jbakker) added a commit: rB9c337fcfe2a4: Fix T72130: Wireframe Visible After Disabling.
Richard Antalik (ISS) mentioned this in T80393: Wireframe slider is faded in wireframe shading mode when overlays are off.Sep 8 2020, 5:18 AM