Maniphest T72351

File explorer - box select selects more files than intended
Confirmed, NormalKNOWN ISSUE

Assigned To
William Reynish (billreynish)
Authored By
Vas (Alumx)
Dec 11 2019, 12:14 PM
Tags
  • BF Blender
  • User Interface
Subscribers
Garek (Garek)
Harley Acheson (harley)
Jacques Lucke (JacquesLucke)
Vas (Alumx)
William Reynish (billreynish)

Description

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.28

Blender Version
Broken: version: 2.82 (sub 4), branch: master, commit date: 2019-12-10 23:56, hash: rB63d521432e93
Worked: (optional)

Short description of error
If you use box select tool, with view set to thumbnails, extra elements are selected from a bottom row (as demonstrated in video)

Exact steps for others to reproduce the error
-open File browser
-Set icons to Thumbnails mode
-go to any folder that has an incomplete bottom row
-attempt make a box selection with mouse starting on bottom empty area
-notice that unintended extra files were selected

Event Timeline

Vas (Alumx) created this task.Dec 11 2019, 12:14 PM
Germano Cavalcante (mano-wii) added a project: User Interface.Dec 16 2019, 12:24 PM
Jacques Lucke (JacquesLucke) changed the task status from Needs Triage to Confirmed.Dec 29 2019, 4:03 PM
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).

I can reproduce that.

William Reynish (billreynish) added a subscriber: William Reynish (billreynish).Dec 29 2019, 4:11 PM

Don't think this is technically a bug. Blender's thumbnail view always worked like this, as though it was a list view. It selects everything in between the start and end point of the selection.

I think it's a reasonable idea to change it, but this is really just quirky/different behaviour rather than an actual bug.

Jacques Lucke (JacquesLucke) added a comment.Dec 29 2019, 4:15 PM

I see. Well I think it is weird when box select selects something that is not actually in the box. Feel free to close this if you think it is not a bug.

William Reynish (billreynish) closed this task as Archived.Dec 29 2019, 4:20 PM
William Reynish (billreynish) claimed this task.

ok closing then. I think it's reasonable to look at changing this, but since this isn't new and not really a bug, it should not be an open bug report.

Harley Acheson (harley) added a subscriber: Harley Acheson (harley).Dec 29 2019, 4:21 PM

This might seem like a simple complaint about a simple problem, but is not.

First examine what is happening. Where is the end of the list? It is certainly below the last items, but is also to the right of those stragglers. So the selections shown in the video start at the end of the list, go to some part inside the list, and then therefore encompass everything in between.

To do to it more intuitively requires a very different set of behaviours when in thumbnail mode. Imagine that the selection shown worked as requested. You would, in fact, want to drag from that right corner up more than one row. It’s not just about not including those stragglers at the left, but more about selecting discontinuous groupings. For example, selecting up the left column of the example list would select a group of every fifth element.

Garek (Garek) reopened this task as Confirmed.Jan 18 2022, 2:52 PM
Garek (Garek) changed the subtype of this task from "Report" to "Known Issue".
Garek (Garek) added a subscriber: Garek (Garek).

This task was closed before Known Issue was defined and used. I reopen it as this is typical case of that and should be open for better access and clarification for those looking up this issue (as I initially did).

I discussed doing this with UI members in a chat.

Harley Acheson (harley) added a comment.Jan 22 2022, 10:59 PM

I'd love to see this worked on. The only small concern I have is that this task's description and "steps to reproduce" don't adequately describe the actual problem to fix.

The current code is selecting a beginning and ending position and including everything in between. This works great in a simple list, but not when there are multiple items per row. This instead has to be changed so that individual items are selected (as if you ctrl-clicked them) if they are touched by the selection rectangle. The target behavior should be the ability to start at the bottom-right of the list, drag to the top-right of the list and have it selected everything in the right-side column - so every 5th element in a list that is showing 5 items per row.

Hans Goudey (HooglyBoogly) moved this task from Backlog to Known Issues on the User Interface board.Mar 30 2022, 8:45 PM