Maniphest T72696

'Reset to Default Value' for Theme colors sets to the incorrect value
Closed, Archived
Actions

Assigned To
Germano Cavalcante (mano-wii)
Authored By
Ethan Simon (razed)
Dec 26 2019, 12:59 AM
Tags
  • BF Blender
  • User Interface
Subscribers
Ben (Elmazz)
dupoxy (dupoxy)
Ethan Simon (razed)
Germano Cavalcante (mano-wii)
ogierm

Description

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.28

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-12-04 11:32, hash: rBf1aa4d18d49d

Short description of error
This may not be a bug and may be the intended result but regardless I still feel like the functionality is handled incorrectly. Personally I would assume the button would set the value to the stock HSV rather than just setting it to 0 , 0 , 0 (which is what it does). Anyone can go pure black, but it is much harder to replicate the stock value without copying it, resetting (everything) to default or looking it up online.

I have included a gif of how to recreate the issue.

Exact steps for others to reproduce the error
https://imgur.com/a/2HIoq6c

Related Objects

Event Timeline

Ethan Simon (razed) created this task.Dec 26 2019, 12:59 AM
Ethan Simon (razed) updated the task description.Dec 26 2019, 1:04 AM
Germano Cavalcante (mano-wii) added a project: User Interface.Dec 30 2019, 6:36 PM
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

I think this is on the borderline between what is considered a bug and what is not.

On the one hand, the default value of each property of a theme is 0,0,0,0
On the other hand the default theme already sets the "default" values.

I think the ideal would be to set the default values at the time a predefined theme is chosen.
Not sure if this is really a bug or if it's a feature worth implementing, I'll let the User Interface team decide.

Germano Cavalcante (mano-wii) closed this task as Archived.Dec 30 2019, 6:59 PM
Germano Cavalcante (mano-wii) claimed this task.

Looking at the code, this would not be simple to implement.
It would be necessary to cache the whole theme so that it could be queried each time the default value of a property is called.
Or reread the .py or .xml file. But that would need saveguards and would not be efficient.

Although a useful feature, the interface team should be aware of this limitation. But unfortunately we cannot invest much time in feature requests without an action plan.
And this bug tracker is only for bugs and errors.

For user requests and feedback, other channels are more appropriate: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

dupoxy (dupoxy) mentioned this in T76146: Reset value for all themes is black.Apr 27 2020, 1:36 PM
Ankit Meel (ankitm) merged a task: T76146: Reset value for all themes is black.Apr 27 2020, 3:02 PM
Ankit Meel (ankitm) added subscribers: Ben (Elmazz), dupoxy (dupoxy), ogierm.