Maniphest T73882

Node wrangler's node previewer not working with ProRender
Closed, ResolvedKNOWN ISSUE
Actions

Assigned To
Brecht Van Lommel (brecht)
Authored By
Le Giang (jangst.1024)
Feb 16 2020, 2:33 PM
Tags
  • Add-ons (Community)
  • Render & Cycles
Subscribers
Bartek Skorupa (bartekskorupa)
Brecht Van Lommel (brecht)
Greg Zaal (gregzaal)
Le Giang (jangst.1024)
Philipp Oeser (lichtwerk)
Sebastian Koenig (sebastian_k)

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: Radeon (TM) RX 470 Graphics ATI Technologies Inc. 4.5.13586 Core Profile Context 20.1.3 26.20.15015.1007

Blender Version
Broken: version: 2.82 (sub 7), branch: master, commit date: 2020-02-12 16:20, hash: rB77d23b0bd76f
Worked: (optional)

Addon Information
Name: Node Wrangler (3, 36)
Author: Bartek Skorupa, Greg Zaal, Sebastian Koenig, Christian Brinkmann, Florian Meyer

Short description of error
Materials previewer not working with ProRender

Exact steps for others to reproduce the error

Revisions and Commits

rBA Blender Add-ons
rBA9896bbdb4e2f Fix T73882, T74420: node wrangler operations only working for Cycles and Eevee

Related Objects

Event Timeline

Le Giang (jangst.1024) created this task.Feb 16 2020, 2:33 PM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Needs Information from Developers.Feb 17 2020, 11:42 AM
Philipp Oeser (lichtwerk) added a project: Render & Cycles.
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Known Issue".
Philipp Oeser (lichtwerk) added subscribers: Greg Zaal (gregzaal), Bartek Skorupa (bartekskorupa), Sebastian Koenig (sebastian_k) and 2 others.

Well, nodewrangler is explicitly checking for Cycles or Eevee in a couple of places (for example this exact operator has it in its poll() function, so wont do anything here if not Cycles or Eevee).
Not sure if we should open up for other render engines here?
Could be that they dont support ShaderNodeEmission, what then?

Maybe we can check https://docs.blender.org/api/master/bpy.types.RenderEngine.html#bpy.types.RenderEngine.bl_use_shading_nodes_custom here, but I recall this is not used consistently, see T68473: Custom RenderEngine: Shader Editor issues

Assume this is is not considered a bug, but would like other opinions here...
CC @Brecht Van Lommel (brecht)
CC @Bartek Skorupa (bartekskorupa)
CC @Sebastian Koenig (sebastian_k)
CC @Greg Zaal (gregzaal)

Brecht Van Lommel (brecht) closed this task as Resolved by committing rBA9896bbdb4e2f: Fix T73882, T74420: node wrangler operations only working for Cycles and Eevee.Mar 4 2020, 8:59 AM
Brecht Van Lommel (brecht) claimed this task.
Brecht Van Lommel (brecht) added a commit: rBA9896bbdb4e2f: Fix T73882, T74420: node wrangler operations only working for Cycles and Eevee.