Maniphest T74605

Key Indicator for motion paths not updating for objects
Closed, ResolvedBUG

Assigned To
Sybren A. Stüvel (sybren)
Authored By
CobraA (CobraA)
Mar 10 2020, 5:38 AM
Tags
  • BF Blender
  • Dependency Graph
  • Animation & Rigging
Subscribers
CobraA (CobraA)
Philipp Oeser (lichtwerk)
Sergey Sharybin (sergey)
Sybren A. Stüvel (sybren)

Description

System Information
Windows 10 64 Bits.
Graphics card GeForce GTX 1080 Ti.

Blender Version
Broken: version: 2.82.7 and 2.83.7 hash: 04e9ba7169c0
Worked: 2.81 & 2.80

Short description of error
Key indicator or whatever it's called doesn't update realtime for none armature objects, I remembered that it worked in 2.81 & 2.80 for most objects,if you have Autokey on and set motion paths then you can move the indicator of that key and preview where it could be in the next position.


Exact steps for others to reproduce the error
Open the file and move the sphere and see that the key indicator doesn't come along, only after mouse release.
But when you move the bone the indicator comes along in the correct way.

I tested the file in 2.80,2.81,.2.82 and 2.83 and the last two versions seems the behavior has changed.
Bug or not that's the question.

Revisions and Commits

rB Blender

Related Objects

Mentioned Here
rB4db2a08281f8: Motion paths: Refactor, make update range more explicit
T68901: Motion path viewport editing
T68905: Motion path revamp
rB04e9ba7169c0: UI: add menus for preferences editor

Event Timeline

CobraA (CobraA) created this task.Mar 10 2020, 5:38 AM
CobraA (CobraA) updated the task description.
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Mar 10 2020, 1:43 PM
Philipp Oeser (lichtwerk) added projects: Dependency Graph, Animation & Rigging.
Philipp Oeser (lichtwerk) added subscribers: Sergey Sharybin (sergey), Sybren A. Stüvel (sybren), Philipp Oeser (lichtwerk).

Can confirm (for me, 2.80 works, 2.81 already has this issue though).

Not sure if we keep this report open (or how to classify), since we have this on the list (and for bones this 'live' preview only affects the current frame -- which seems of limited use anyways?):

CC @Sybren A. Stüvel (sybren)
CC @Sergey Sharybin (sergey)

Sybren A. Stüvel (sybren) added a comment.Mar 12 2020, 10:28 AM

@CobraA (CobraA) Thanks for testing with various versions of Blender, that makes it much easier to pinpoint the issue.

Testing the file in 2.80, it shows different motion path problems, so my guess is that the reported behaviour was introduced in a change that actually fixed other issues.

I did some digging, and it seems that this is caused by rB4db2a08281f8495421938e0b2f6a802420afba36. That changed the parameter current_frame_only=true to range=xxxxx_CURRENT_FRAME for bones but range=xxxxx_CHANGED for objects. As animviz_calc_motionpaths() only updates the motion path for the current frame if range=xxxxx_CURRENT_FRAME, this introduced the observed difference between the handling of bones and objects.

This issue can be fixed by this change:

diff --git a/source/blender/editors/transform/transform_generics.c b/source/blender/editors/transform/transform_generics.c
index bb4d50fcf54..716df24f195 100644
--- a/source/blender/editors/transform/transform_generics.c
+++ b/source/blender/editors/transform/transform_generics.c
@@ -1102,7 +1102,7 @@ static void recalcData_objects(TransInfo *t)
 
     if (motionpath_update) {
       /* Update motion paths once for all transformed objects. */
-      ED_objects_recalculate_paths(t->context, t->scene, OBJECT_PATH_CALC_RANGE_CHANGED);
+      ED_objects_recalculate_paths(t->context, t->scene, OBJECT_PATH_CALC_RANGE_CURRENT_FRAME);
     }
 
     if (t->options & CTX_OBMODE_XFORM_SKIP_CHILDREN) {

I'll discuss with @Sergey Sharybin (sergey) to see if this is the appropriate fix.

Sergey Sharybin (sergey) added a comment.Mar 12 2020, 10:50 AM

@Sybren A. Stüvel (sybren), good find! Just commit it ;)

Sybren A. Stüvel (sybren) renamed this task from Key Indicator for motion paths not updating for non-armature objects. to Key Indicator for motion paths not updating for objects.Mar 12 2020, 11:07 AM
Sybren A. Stüvel (sybren) claimed this task.
Sybren A. Stüvel (sybren) closed this task as Resolved by committing rB6c707aad6a2e: Fix T74605 Key Indicator for motion paths not updating for objects.Mar 12 2020, 11:09 AM
Sybren A. Stüvel (sybren) added a commit: rB6c707aad6a2e: Fix T74605 Key Indicator for motion paths not updating for objects.
Sybren A. Stüvel (sybren) changed the subtype of this task from "Report" to "Bug".Mar 12 2020, 11:13 AM
CobraA (CobraA) added a comment.Mar 12 2020, 4:56 PM

@Sybren A. Stüvel (sybren) My pleasure, Thank you for taking the time to take a look at it.