Maniphest T76033

Video Sequence Editor crash with prefetch and meta strips
Closed, ResolvedBUG
Actions

Assigned To
Richard Antalik (ISS)
Authored By
Dario Abatianni (Eisfuchs)
Apr 24 2020, 1:12 AM
Tags
  • BF Blender
  • VFX & Video
Subscribers
Ankit Meel (ankitm)
Dario Abatianni (Eisfuchs)
Richard Antalik (ISS)

Description

System Information
Operating system: Linux-5.2.14-1-default-x86_64-with-glibc2.17 64 Bits
Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
Broken: version: 2.83 (sub 14), branch: master, commit date: 2020-04-23 08:25, hash: rB8dedbb174783
Worked: version: 2.83 'rBa322b43e3d08'

Short description of error
VSE crashes when prefetching is enabled and a meta strip is on the timeline.

Exact steps for others to reproduce the error
Not sure how I managed to finally trigger it in a small example file, but I can't open it anymore to look, because it crashes Blender instantly :-D It probably has to do with disk caching, enabling all cache types (raw, preprocessed ...) and then creating a meta strip. I hope the attached blend file shows the behavior.

lockdown2020_crash_colors_smallest_file.blend491 KBDownload

Revisions and Commits

rB Blender
D7597rB98990f6ba439 Fix T76033: VSE crash with prefetch, disk cache and meta strips

Related Objects

Mentioned In
T76320: Video Editor: seq_prefetch_cache_is_full while undoing
T76274: Program crashes when editing a video file, corrupted it.
Mentioned Here
T76274: Program crashes when editing a video file, corrupted it.
rBd4ffd1d91f84: Cleanup: declare values for enum types
rBa322b43e3d08: Cleanup: remove unused wmWindow.monitor

Event Timeline

Dario Abatianni (Eisfuchs) created this task.Apr 24 2020, 1:12 AM
Ankit Meel (ankitm) added a project: VFX & Video.Apr 24 2020, 10:01 AM
Ankit Meel (ankitm) added a subscriber: Ankit Meel (ankitm).

I can open the file in rBd4ffd1d91f84e956c1f9832700b0f42cd150c2f1. Though the playback is all black.

Dario Abatianni (Eisfuchs) added a comment.Apr 24 2020, 11:13 AM
In T76033#916618, @Ankit Meel (ankitm) wrote:

I can open the file in rBd4ffd1d91f84e956c1f9832700b0f42cd150c2f1. Though the playback is all black.

Yes, it's just two black strips inside a meta strip. If it doesn't crash, I assume it's cache related. Is there a way for me to capture a meaningful backtrace without going all out and compiling the whole thing?

Ankit Meel (ankitm) changed the task status from Needs Triage to Needs Information from User.Apr 24 2020, 3:01 PM

... to do with disk caching, enabling all cache types (raw, preprocessed ...) ...

even if you complete & share the trace, the developer still needs to redo the case on their system to test it. So if you can find a way to reliably redo it, share the steps, that would be great.

Dario Abatianni (Eisfuchs) added a comment.Apr 24 2020, 3:14 PM

I just reproduced it from scratch:

  • File / New / Video Editing
  • View / Cache / Raw Images
  • View / Cache / Preprocessed Images
  • View / Cache / Composite Images
  • Add / Color
  • Duplicate added color strip (shift+d), place it on the next channel on top
  • Preview / N-Panel / View / Prefetch frames
  • IMPORTANT: Save the file now, or it won't crash
  • Select both color strips
  • ctrl+g
  • *CRASH*

lockdown2020_crash_colors_smallest_file_2.blend489 KBDownload

Ankit Meel (ankitm) changed the task status from Needs Information from User to Confirmed.EditedApr 25 2020, 11:18 AM

Umm it doesn't crash with the steps you did. Someone else would have to try it.
But I do some undo/redo cycles & it crashes. So after ctrl + g, Undo some steps (cmd + Z), redo some steps (cmd + shift + Z), after 3-4 such cycles it crashes.

#0	 seq_prefetch_is_cache_full at source/blender/blenkernel/intern/seqprefetch.c:164
#1	 seq_prefetch_frames at source/blender/blenkernel/intern/seqprefetch.c:358
#2	 tslot_thread_start at source/blender/blenlib/intern/threads.c:258
Dario Abatianni (Eisfuchs) added a comment.Apr 25 2020, 4:02 PM

Do you have disk caching enabled in Preferences / System / Video Sequencer / Use Disk Cache and saved the blend file before creating the meta?

If I disable Disk Caching, the crash goes away. But with disk cache enabled, creating a meta strip crashes.

disk_cache_prefetch_crash.mkv22 MBDownload

Ankit Meel (ankitm) mentioned this in T76274: Program crashes when editing a video file, corrupted it..May 1 2020, 7:54 AM
Richard Antalik (ISS) added a subscriber: Richard Antalik (ISS).May 1 2020, 2:59 PM
In T76033#917604, @Dario Abatianni (Eisfuchs) wrote:

Do you have disk caching enabled in Preferences / System / Video Sequencer / Use Disk Cache and saved the blend file before creating the meta?

If I disable Disk Caching, the crash goes away. But with disk cache enabled, creating a meta strip crashes.

disk_cache_prefetch_crash.mkv22 MBDownload

Thanks for report.
Can you please upload created file /tmp/untitled.crash.txt?

Dario Abatianni (Eisfuchs) added a comment.May 1 2020, 4:09 PM

untitled.crash.txt1 KBDownload

Ah, sorry! I forgot that one! Here it is :-)

Richard Antalik (ISS) added a revision: D7597: Fix T76033: VSE crash with prefetch, disk cache and meta strips.May 1 2020, 4:22 PM
Richard Antalik (ISS) triaged this task as High priority.May 1 2020, 4:25 PM
Richard Antalik (ISS) changed the subtype of this task from "Report" to "Bug".
In T76033#921649, @Dario Abatianni (Eisfuchs) wrote:

untitled.crash.txt1 KBDownload

Ah, sorry! I forgot that one! Here it is :-)

Thanks.

For a moment I thought I finally caught T76274, but nope, this is different issue. But thanks for report anyway.

Richard Antalik (ISS) closed this task as Resolved by committing rB98990f6ba439: Fix T76033: VSE crash with prefetch, disk cache and meta strips.May 1 2020, 9:24 PM
Richard Antalik (ISS) claimed this task.
Richard Antalik (ISS) added a commit: rB98990f6ba439: Fix T76033: VSE crash with prefetch, disk cache and meta strips.
Ankit Meel (ankitm) mentioned this in T76320: Video Editor: seq_prefetch_cache_is_full while undoing.May 2 2020, 10:11 AM