Maniphest T76216

Object disappared and glichted when switching between normal view and quad views
Closed, ResolvedBUG

Assigned To
Clément Foucault (fclem)
Authored By
Le Giang (jangst.1024)
Apr 29 2020, 9:15 AM
Tags
  • BF Blender
  • EEVEE & Viewport
Subscribers
Ankit Meel (ankitm)
Clément Foucault (fclem)
Jeroen Bakker (jbakker)
Le Giang (jangst.1024)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: Radeon (TM) RX 470 Graphics ATI Technologies Inc. 4.5.13587 Core Profile Context 20.4.1 26.20.15029.20013

Blender Version
Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-04-28 20:40, hash: rB05274ca82971
Worked: 2.82a

Short description of error
Object disappared when switching between normal view and quad views, doing this repeatedly can cause:

  • selection outline always draws
  • sometimes geometry disappears
  • sometimes other overlays disappear [grid, lights, camera, ...]
  • sometimes geometry draws as if in xray

Object glichted sometimes when switching between normal view and quad views in the view port if viewport aa set to 32

Exact steps for others to reproduce the error
Object disappared

Object glichted

Debug logs
Object disappared


Object glichted


Revisions and Commits

rB Blender

Related Objects

Mentioned Here
P1363 T76216_snippet
rBc476c36e4008: Workbench Simplification Refactor
rBa6dd22d4311c: Fix T74957: Matcap flip not updating
rBed44bb902d6b: Fix T74872: Clipping Region not updating
rB02f7a6b2bdea: Fix T74744: Studio Lights editor not updating in realtime when tweaking the…
rB133bf05b184b: Fix T75736 Viewport update problem when switching between view layers

Event Timeline

Le Giang (jangst.1024) created this task.Apr 29 2020, 9:15 AM
Ankit Meel (ankitm) added a subscriber: Ankit Meel (ankitm).Apr 29 2020, 9:26 AM
Le Giang (jangst.1024) added a comment.Apr 29 2020, 10:17 AM
In T76216#919862, @Ankit Meel (ankitm) wrote:

it's still happens in the lastest driver

Ankit Meel (ankitm) changed the task status from Needs Triage to Needs Information from User.Apr 29 2020, 2:15 PM

Please run Blender_debug_gpu.cmd, get the glitch & upload the two files it mentions.

Le Giang (jangst.1024) updated the task description.Apr 29 2020, 3:03 PM
In T76216#920072, @Ankit Meel (ankitm) wrote:

Please run Blender_debug_gpu.cmd, get the glitch & upload the two files it mentions.

i attached the debug file in the task

Ankit Meel (ankitm) changed the task status from Needs Information from User to Needs Triage.Apr 29 2020, 3:22 PM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Apr 30 2020, 1:07 PM
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".
Philipp Oeser (lichtwerk) added a project: EEVEE & Viewport.
Philipp Oeser (lichtwerk) added subscribers: Clément Foucault (fclem), Philipp Oeser (lichtwerk).

Can confirm.

Caused by rBc476c36e4008: Workbench Simplification Refactor

Might need a kick to wpd->view_updated = true (similar to rB133bf05b184b, rBa6dd22d4311c, rBed44bb902d6b, rB02f7a6b2bdea ...)

CC @Clément Foucault (fclem)

Philipp Oeser (lichtwerk) added a comment.May 1 2020, 10:39 AM

What I mean is:

1
2
3diff --git a/source/blender/draw/engines/workbench/workbench_data.c b/source/blender/draw/engines/workbench/workbench_data.c
4index 2e8119fca2f..c71676d24b1 100644
5--- a/source/blender/draw/engines/workbench/workbench_data.c
6+++ b/source/blender/draw/engines/workbench/workbench_data.c
7@@ -214,6 +214,13 @@ void workbench_private_data_init(WORKBENCH_PrivateData *wpd)
8 rv3d->rflag &= ~RV3D_GPULIGHT_UPDATE;
9 }
10
11+ /* FIXME: This reproduce old behavior when workbench was separated in 2 engines.
12+ * But this is a workaround for a missing update tagging. */
13+ if ((rv3d != NULL) && (rv3d->viewlock_quad & RV3D_VIEWLOCK_INIT)) {
14+ wpd->view_updated = true;
15+ rv3d->viewlock_quad &= ~RV3D_VIEWLOCK_INIT;
16+ }
17+
18 if (!v3d || (v3d->shading.type == OB_RENDER && BKE_scene_uses_blender_workbench(scene))) {
19 /* FIXME: This reproduce old behavior when workbench was separated in 2 engines.
20 * But this is a workaround for a missing update tagging from operators. */

(but of course, we shouldnt be messing with RV3D_VIEWLOCK_INIT like that...)

Brecht Van Lommel (brecht) triaged this task as High priority.May 1 2020, 7:15 PM
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).May 8 2020, 9:45 AM

Seems like 2 tickets in one. The glitch has been reported already so I assume this ticket is about the tagging...

I wasn't able to reproduce the quad view tagging issue on latest build. @Philipp Oeser (lichtwerk) do think this is a platform specific problem? If so I can try building this configuration. Just wanna check before spending much time building the configuration.

Tested myself on Linux AMD Vega64 and Windows Intel

Philipp Oeser (lichtwerk) added a comment.May 8 2020, 10:54 AM
In T76216#926675, @Jeroen Bakker (jbakker) wrote:

Seems like 2 tickets in one. The glitch has been reported already so I assume this ticket is about the tagging...

Mind sharing which the other report is?

I wasn't able to reproduce the quad view tagging issue on latest build. @Philipp Oeser (lichtwerk) do think this is a platform specific problem? If so I can try building this configuration. Just wanna check before spending much time building the configuration.

Cannot tell (I only have access to this one machine...) And I still have it on
System Information
Operating system: Linux-5.5.13-200.fc31.x86_64-x86_64-with-fedora-31-Thirty_One 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.64
version: 2.90 (sub 0), branch: master, commit date: 2020-05-08 03:43, hash: rBb4d50d3f07bb

Philipp Oeser (lichtwerk) updated the task description.May 8 2020, 10:57 AM
Jeroen Bakker (jbakker) added a comment.May 8 2020, 11:07 AM

@Philipp Oeser (lichtwerk), seem that other tickets are for Intel and NVidia. perhaps we just split these tickets.

Philipp Oeser (lichtwerk) added a comment.May 8 2020, 11:12 AM

But other tickets are specifically about quadview? Which other reports are these? [I have no other glitches]

Jeroen Bakker (jbakker) added a comment.May 8 2020, 11:58 AM

I was able to reproduce this issue but only on Windows. I did reproduce it on Intel and multiple AMD cards.

Clément Foucault (fclem) added a comment.May 11 2020, 3:52 PM

I was able to reproduce on Nvidia GTX960 + Windows.

Clément Foucault (fclem) closed this task as Resolved by committing rBa1363f74bf16: Fix T76216 Workbench: Glicht when switching from quad views to normal view.May 11 2020, 5:54 PM
Clément Foucault (fclem) claimed this task.
Clément Foucault (fclem) added a commit: rBa1363f74bf16: Fix T76216 Workbench: Glicht when switching from quad views to normal view.