Maniphest T76302

Multires Rebuild Subdivision shrinks shape
Closed, Archived
Actions

Assigned To
Pablo Dobarro (pablodp606)
Authored By
Sergey (borschberry)
May 1 2020, 6:06 PM
Tags
  • BF Blender
  • Sculpt, Paint & Texture
  • Modifiers
  • Modeling
Subscribers
Andrey (andruxa696)
Ankit Meel (ankitm)
Debuk (Debuk)
Enrique Barranco (ebarranco)
Kenn Nyström (Frozen_Death_Knight)
Pablo Dobarro (pablodp606)
Regnas (Regnas)
1 More Subscribers

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.92

Blender Version
Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-05-01 14:06, hash: rB60741cfe181c
Worked: (newest version of Blender that worked as expected)

**Short description of error*
Multires Rebuild Subdivision shrinks shape

Exact steps for others to reproduce the error
Create cube
Create multires with 2 levels and apply
Create multires and Rebuild subdivision
Start and rebuild shapes are different

Same for simple subdivision modifier

Related Objects

Event Timeline

Sergey (borschberry) created this task.May 1 2020, 6:06 PM
Eitan Traurig (EitanSomething) added a project: Sculpt, Paint & Texture.May 1 2020, 6:07 PM
Regnas (Regnas) added a subscriber: Regnas (Regnas).May 1 2020, 11:39 PM

Indeed.

Ankit Meel (ankitm) added subscribers: Ankit Meel (ankitm), Pablo Dobarro (pablodp606).May 2 2020, 10:45 AM
Ankit Meel (ankitm) changed the task status from Needs Triage to Confirmed.May 2 2020, 11:57 AM
Ankit Meel (ankitm) added projects: Modifiers, Modeling.May 2 2020, 12:04 PM
Ankit Meel (ankitm) mentioned this in T76457: Subdivide algorithm differs from the industry standard.May 5 2020, 11:16 PM
Evan Wilson (EAW) updated the task description.May 6 2020, 5:47 AM
Ronny G (nutel) added a subscriber: Ronny G (nutel).May 6 2020, 2:11 PM

press "apply base" after that operation the new base mesh should roughly be the same as the previous one (its not 100% perfect..)

Sergey (borschberry) added a comment.May 6 2020, 4:57 PM

Much better, but the differences are still significant. Moreover, this is a cube example where everything should work well

Thanks a lot for the tip though.

Andrey (andruxa696) added a subscriber: Andrey (andruxa696).May 6 2020, 8:27 PM

I think it is not correct to look as an example always on cube. Here is I did some comparison on more real examples.
For me in 90% rebuild subdivision works better then apply base , it try to be more close to high poly model then apply base. For example look on lips - in apply base lips getting too much close to each other and overlapping too much.


on hard surface rebuild subdivision also works a little bit better, but in more specific some cases apply base works better.
@Sergey (borschberry) rebuild subdivision task is to make level 0 and other levels as close to highpoly as possible, not to make original cube. I am artist, not developer, but in my opinion it is works as it should, the same way as it works in Zbrush.

Sergey (borschberry) added a comment.May 6 2020, 9:31 PM

It's not about examples at all. The question is whether the algorithm works correctly or not. The cube is the simplest example, so I use it as a volume preservation marker (it's not about saving the shape, it's about saving the volume first).

@Andrey (andruxa696) As an artist, you may be satisfied with the result, but I am not, it does not matter. If the algorithm is not working correctly, a small error can accumulate and lead to unpredictable results.

Enrique Barranco (ebarranco) added a subscriber: Enrique Barranco (ebarranco).May 6 2020, 9:36 PM
Sergey (borschberry) added a comment.May 6 2020, 9:45 PM

it looks like the problem may be in the new "limit surface" feature in the subdivision algorithm.

Debuk (Debuk) added a subscriber: Debuk (Debuk).May 6 2020, 10:53 PM

This is no bug and there is no danger that this is introducing problems. If the algorithm finds patches that can be evenly unsubivided it simply takes the position of the "remaining points" of the finegrained mesh itself. This is just the simplest solution for positioning the basemeshes points. Technically this is as valid as any other position and is rather a safe choice. The only thing that decides here about right or wrong is if the baseshape and the displacement combine to be the original smooth input surface.

It might be worth to think about if this should not have the bigger dimensions of a plain subdiv basemesh/controlcage though.
But it's no bug.

Kenn Nyström (Frozen_Death_Knight) added a subscriber: Kenn Nyström (Frozen_Death_Knight).May 6 2020, 11:03 PM

@Sergey (borschberry) This is definitely not a bug and @Andrey (andruxa696) is completely right about Rebuild Subdivisions producing the most correct results for sculpting.

Pablo Dobarro just uploaded a patch where he changed the Apply Base algorithm to the Rebuild Subdivisions/Unsubdivide algorithm and made the current algorithm into a separate button called Refit Base. After having tested 2.90 for the last week and having previous ZBrush experience, this is the way forward as far as I'm concerned. Current Apply Base is bad for what sculptors need in the vast majority of cases and I hope the new Pablo patch gets added asap.

Pablo Dobarro (pablodp606) closed this task as Archived.May 6 2020, 11:07 PM
Pablo Dobarro (pablodp606) claimed this task.

I also don't think this is a bug. I made unsubdivide work this way to make the Delete Lower operator. This way the resulting base mesh will always match the positions of the displacement. To improve this it is necessary to do a refit step after calculating the new base mesh and it will work like the current Apply Base. To make this more clear, I made a patch to split Apply Base into two separate buttons, one that refits (which inflates the mesh) and one that does not refit, matching the vertex positions of the displacement (like rebuild subdivisions) D7644