Maniphest T76471

Crash on BLI_assert(sfile->previews_timer == NULL);
Closed, Resolved

Assigned To
Brecht Van Lommel (brecht)
Authored By
Richard Antalik (ISS)
May 6 2020, 11:55 AM
Tags
  • BF Blender
Subscribers
Ankit Meel (ankitm)
Brecht Van Lommel (brecht)
Germano Cavalcante (mano-wii)
Harley Acheson (harley)
Richard Antalik (ISS)

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: Radeon RX550/550 Series ATI Technologies Inc. 4.5.13587 Core Profile Context 20.4.1 26.20.15029.20013

Blender Version
Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-05-03 22:25, hash: rB33bdd91fb825
Worked: (newest version of Blender that worked as expected)

Short description of error
Crash on BLI_assert(sfile->previews_timer == NULL);

>	blender.exe!BLI_system_backtrace(_iobuf * fp) Line 353	C
 	blender.exe!file_free(SpaceLink * sl) Line 142	C
 	blender.exe!BKE_spacedata_freelist(ListBase * lb) Line 222	C
 	blender.exe!BKE_screen_area_free(ScrArea * area) Line 501	C
 	blender.exe!BKE_screen_area_map_free(ScrAreaMap * area_map) Line 509	C
 	blender.exe!screen_free_data(ID * id) Line 69	C
 	blender.exe!BKE_libblock_free_datablock(ID * id, const int UNUSED_flag) Line 74	C
 	blender.exe!BKE_id_free_ex(Main * bmain, void * idv, int flag, const bool use_flag_from_idtag) Line 150	C
 	blender.exe!BKE_main_free(Main * mainvar) Line 189	C
 	blender.exe!BKE_blender_globals_clear() Line 149	C
 	blender.exe!setup_app_data(bContext * C, BlendFileData * bfd, const unsigned char * filepath, const BlendFileReadParams * params, ReportList * reports) Line 282	C
 	blender.exe!setup_app_blend_file_data(bContext * C, BlendFileData * bfd, const unsigned char * filepath, const BlendFileReadParams * params, ReportList * reports) Line 414	C
 	blender.exe!BKE_blendfile_read(bContext * C, const unsigned char * filepath, const BlendFileReadParams * params, ReportList * reports) Line 452	C
 	blender.exe!WM_file_read(bContext * C, const unsigned char * filepath, ReportList * reports) Line 639	C
 	blender.exe!wm_file_read_opwrap(bContext * C, const unsigned char * filepath, ReportList * reports, const bool autoexec_init) Line 2110	C
 	blender.exe!wm_open_mainfile__open(bContext * C, wmOperator * op) Line 2252	C
 	blender.exe!wm_open_mainfile_exec(bContext * C, wmOperator * op) Line 2289	C
 	blender.exe!wm_handler_fileselect_do(bContext * C, ListBase * handlers, wmEventHandler_Op * handler, int val) Line 2275	C
 	blender.exe!wm_handler_fileselect_call(bContext * C, ListBase * handlers, wmEventHandler_Op * handler, const wmEvent * event) Line 2374	C
 	blender.exe!wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2784	C
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2836	C
 	blender.exe!wm_event_do_handlers(bContext * C) Line 3231	C
 	blender.exe!WM_main(bContext * C) Line 453	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 530	C
 	[External Code]

Exact steps for others to reproduce the error

  1. Open Video Editing template
  2. Change file browser area to graph editor
  3. Close Blender or load new file

Should crash now.

Revisions and Commits

rB Blender

Related Objects

Mentioned Here
rB8b10e1b45798: Fix T61780: Crash when trying to access screen areas through the outliner.
rBb7f86ff72273: Fix Area.ui_type invalid during area change
rB33bdd91fb825: Windows: Move tbb to being dynamic library
rB9b7754883b3d: Merge branch 'blender-v2.83-release'

Event Timeline

Richard Antalik (ISS) created this task.May 6 2020, 11:55 AM
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).May 7 2020, 3:13 PM

I cannot reproduce this with either the latest stable or current development versions of Blender.


Operating system: Windows-10-10.0.18941 64 Bits
Graphics card: Radeon (TM) RX 480 Graphics ATI Technologies Inc. 4.5.13586 Core Profile Context 19.50.01.05 26.20.15001.5006

Ankit Meel (ankitm) added a subscriber: Ankit Meel (ankitm).EditedMay 7 2020, 3:30 PM

Just tested, neither mentioned rB33bdd91fb825, nor rB9b7754883b3d41d41cd2df3b079cc1fce78c044a get the assert. I was opening new file (cmd + N )

Richard Antalik (ISS) added a comment.May 7 2020, 3:32 PM

This still happens for me.
Did you test with debug or relwithdebinfo? I should specify this.

Ankit Meel (ankitm) added a comment.May 7 2020, 3:34 PM

I tested Debug.

Germano Cavalcante (mano-wii) added a comment.May 7 2020, 3:44 PM
In T76471#926137, @Richard Antalik (ISS) wrote:

This still happens for me.
Did you test with debug or relwithdebinfo? I should specify this.

Debug

Richard Antalik (ISS) added a subscriber: Harley Acheson (harley).May 8 2020, 1:02 AM

That's strange. I am not sure what to check if the freeing sequence is correct exactly. I was looking into this for a bit and haven't found anything strange.

Perhaps @Harley Acheson (harley) would know more?

Harley Acheson (harley) added a comment.May 8 2020, 1:17 AM

I can certainly take a look. But wondering if you've asked me just because I've generally poked around in there or was it because of some specific thing that I could have broken? Just in case that narrows things down.

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).May 8 2020, 1:55 AM

I'll commit a fix for this. It's a rather subtle problem caused by rB8b10e1b45798: Fix T61780: Crash when trying to access screen areas through the outliner. and rBb7f86ff72273: Fix Area.ui_type invalid during area change.

Brecht Van Lommel (brecht) closed this task as Resolved by committing rB2a8ba9c08ec9: Fix T76471: timer not removed after changing file browser to another type.May 8 2020, 1:55 AM
Brecht Van Lommel (brecht) claimed this task.
Brecht Van Lommel (brecht) added a commit: rB2a8ba9c08ec9: Fix T76471: timer not removed after changing file browser to another type.
Richard Antalik (ISS) added a comment.May 8 2020, 2:50 AM
In T76471#926506, @Harley Acheson (harley) wrote:

I can certainly take a look. But wondering if you've asked me just because I've generally poked around in there or was it because of some specific thing that I could have broken? Just in case that narrows things down.

I just thought, that you are file browser guru, so you would be good person to ask :)

Harley Acheson (harley) added a comment.EditedMay 8 2020, 3:29 AM

@Richard Antalik (ISS) - I just thought, that you are file browser guru, so you would be good person to ask :)

Well thanks! Although I thought it more likely you were trying to remind me of some dumb thing I forgot that I had done in there.

I did look at that error and thought I was on the right track with that previews task, but then I saw Brecht's fix and I was nowhere near. LOL