Maniphest T76522

GPencil: Transform fill and Adjust Last Operation panel do not work
Closed, ResolvedBUG
Actions

Assigned To
Antonio Vazquez (antoniov)
Authored By
dupoxy (dupoxy)
May 7 2020, 11:04 PM
Tags
  • BF Blender
  • Grease Pencil
Subscribers
Antonio Vazquez (antoniov)
dupoxy (dupoxy)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Darwin-17.7.0-x86_64-i386-64bit 64 Bits
Graphics card: NVIDIA GeForce GTX 680MX OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-10.32.0 355.11.10.10.40.102

Blender Version
Broken version: 2.83 (sub 15), branch: master, commit date: 2020-05-05 22:28, hash: rBc036ef136960
Broken version: 2.90
Worked: ?
Short description of error
Transform fill and Adjust Last Operation panel do not work

Exact steps for others to reproduce the error

  1. open file
    transform-fill_v000.blend804 KBDownload
  2. try changing the mode of transform fill with the Last Operation panel

Notice that it does not work

Do the same with the Tool Sidebar and it work

Step by Step

  1. Start a new 2D animation
  2. Draw a grease Pencil object with a Radial Gradient Fill material
  3. Now edit this object with the transform fill tool and try changing the mode of transform fill with the Last Operation panel

Notice that it does not work

Revisions and Commits

rB Blender
D7741rB825d5c9992b2 Fix T76522: Grease Pencil transform fill and Adjust Last Operation panel issue
D7665rBa116912fd62d Fix (unreported) greasepencil crash calling transform_fill from outside

Related Objects

Event Timeline

dupoxy (dupoxy) created this task.May 7 2020, 11:04 PM
dupoxy (dupoxy) added a project: Grease Pencil.
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.May 8 2020, 10:23 AM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Confirmed, checking...

Philipp Oeser (lichtwerk) added a revision: D7665: Fix (unreported) greasepencil crash calling transform_fill from outside 3DView.May 8 2020, 11:50 AM
Philipp Oeser (lichtwerk) mentioned this in D7665: Fix (unreported) greasepencil crash calling transform_fill from outside 3DView.
dupoxy (dupoxy) updated the task description.May 9 2020, 2:59 PM
Antonio Vazquez (antoniov) closed this task as Resolved.May 11 2020, 4:51 PM
Antonio Vazquez (antoniov) claimed this task.
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).

Just need set View Toolsettings.

Tnaks for the report, but we can close the report because it's not a bug.

Philipp Oeser (lichtwerk) added a comment.May 11 2020, 5:02 PM

Not sure this is resolved:

  • yes, Toolsettings and Active Tool sidebar works [setting it prior is OK]
  • changing it (e.g. Rotate to Scale )in Adjust Last Operation more or less breaks -- it doesnt really make sense to do this even I think [maybe exec should be removed entirely? So we dont have the Adjust Last Operation panel at all?]
  • also: calling Transform Stroke Fill from the menu search F3 cannot be undone Ctrl+Z doesnt do anything...

So there is something wrong with Undo/Redo?

dupoxy (dupoxy) added a comment.May 11 2020, 8:21 PM

Sorry but this does not work as expected.
What should i do reopen a new bug ?

Philipp Oeser (lichtwerk) reopened this task as Confirmed.May 11 2020, 8:42 PM

@Antonio Vazquez (antoniov) : maybe this is a misunderstanding, but yes, I think this is still an issue...

Philipp Oeser (lichtwerk) added a commit: rBa116912fd62d: Fix (unreported) greasepencil crash calling transform_fill from outside.May 11 2020, 8:58 PM
Antonio Vazquez (antoniov) added a comment.May 12 2020, 10:43 AM

sorry..I missunderstood the problem. I going to look again.

Antonio Vazquez (antoniov) changed the subtype of this task from "Report" to "Bug".May 14 2020, 8:09 PM
Antonio Vazquez (antoniov) added a comment.May 15 2020, 11:35 AM

Proposed fix in D7741

Philipp Oeser (lichtwerk) added a revision: D7741: Fix T76522: Grease Pencil transform fill and Adjust Last Operation panel issue [proposal].May 15 2020, 11:39 AM
Antonio Vazquez (antoniov) closed this task as Resolved by committing rB825d5c9992b2: Fix T76522: Grease Pencil transform fill and Adjust Last Operation panel issue.May 26 2020, 11:30 AM
Antonio Vazquez (antoniov) added a commit: rB825d5c9992b2: Fix T76522: Grease Pencil transform fill and Adjust Last Operation panel issue.
Antonio Vazquez (antoniov) added a comment.May 26 2020, 11:30 AM

Fixed with commit 825d5c9992b2

Philipp Oeser (lichtwerk) mentioned this in T80351: Gradients not working on Grease pencil masks.Sep 2 2020, 2:41 PM