Maniphest T76578

Driven bone's visibility in the outliner has no color(purple) indication of their status.
Closed, Resolved
Actions

Assigned To
Nathan Craddock (natecraddock)
Authored By
CobraA (CobraA)
May 9 2020, 4:30 AM
Tags
  • BF Blender
  • Animation & Rigging
  • User Interface
Subscribers
Campbell Barton (campbellbarton)
CobraA (CobraA)
Nathan Craddock (natecraddock)
Sybren A. Stüvel (sybren)

Description

System Information
Windows 10 64 Bits.
Graphics card GeForce GTX 1080 Ti.

Blender Version
Broken: version: 2.90 hash: a1c2441390e6

Short description of error
When you add a driver to bone's 'restrict visibility' there is no purple color indication that it's driven in the outliner.

Exact steps for others to reproduce the error

  • Open the demo file.
  • Scrub through the timeline to see the custom property changing its value, and the visibility changing because there is a driver on it.
  • The driven visiblity Icon in the outliner has no purple color for indicating that it has a driver.

Viz.blend917 KBDownload

Revisions and Commits

rB Blender
D7825rB6f8d99322cf6 Fix T76578: Show bone visibility driver in outliner

Related Objects

Mentioned Here
rB046172755313: Fix T75998: Precision of 'Unit Scale' and 'Grid Scale' are mismatched
rBde53c039adb4: UI: show tool-tips in menu search
rBa1c2441390e6: Windows: Improve private symbol detection

Event Timeline

CobraA (CobraA) created this task.May 9 2020, 4:30 AM
CobraA (CobraA) updated the task description.May 9 2020, 4:32 AM
CobraA (CobraA) renamed this task from Driven bones visibility in the outliner has no color(purple) indication of their status. to Driven bone's visibility in the outliner has no color(purple) indication of their status..May 9 2020, 5:22 AM
CobraA (CobraA) updated the task description.
Eitan Traurig (EitanSomething) added a project: Animation & Rigging.May 10 2020, 3:39 AM
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).May 11 2020, 11:42 AM

@CobraA (CobraA) please don't ask questions and report a bug in the same report. I'll try and answer your questions here, and then remove them from the report to make sure it's clear what it means when the report is closed.

why bones don't have 'eye' Icons as a secondary visibility toggle?

I'm not 100% sure, but I suspect this is due to the way the eye icon works. It is not a property of the object, but of its base (that's the thing that links an object to a scene, and what allows it to be visible in one scene but not the other). Since bones don't have such a base, there is no place to store that eye icon's value.

if you drive the bone's 'restrict visibility' then you can't hide it manually per viewport

Correct.

and if it's hidden and you hit 'Alt+H' then unhide again then it gets selected for some reason.

That's just how Blender works. It always selects unhidden bones/objects.

Sybren A. Stüvel (sybren) updated the task description.May 11 2020, 11:43 AM
Sybren A. Stüvel (sybren) added a project: User Interface.
Sybren A. Stüvel (sybren) changed the task status from Needs Triage to Confirmed.May 11 2020, 11:54 AM

In the 2.83 branch (rB0461727553135f4dee29) and master (rBde53c039adb4b7efe3a) the outliner also doesn't show the puple colour, but the properties panel does show it:

I now realise that the attached demo video is misleading, as the active bone is not the one with the driver on it.

Sybren A. Stüvel (sybren) moved this task from Backlog to Bugs on the Animation & Rigging board.May 11 2020, 11:54 AM
Sybren A. Stüvel (sybren) added subscribers: Nathan Craddock (natecraddock), Campbell Barton (campbellbarton).May 11 2020, 12:33 PM

I did some digging in the outliner code, and it seems to be simply not implemented.

@Zachman @Campbell Barton (campbellbarton) you seem to have worked in the bone-related areas of the outliner. Is this something that's doable? Or shall I file this as a known issue for now?

CobraA (CobraA) added a comment.May 11 2020, 9:59 PM
In T76578#928653, @Sybren A. Stüvel (sybren) wrote:

In the 2.83 branch (rB0461727553135f4dee29) and master (rBde53c039adb4b7efe3a) the outliner also doesn't show the puple colour, but the properties panel does show it:

I now realise that the attached demo video is misleading, as the active bone is not the one with the driver on it.

My bad, the video is from the project while the demo file is the simplified version.

I asked those questions because i didn't know if you guys considere them expected behaviors or bugs/limitations but from your answer it seem impossible to "lift them" due to how Blender works.

Nathan Craddock (natecraddock) claimed this task.May 11 2020, 10:12 PM

@Sybren A. Stüvel (sybren) Yes this is doable, the restriction buttons just need to be connected to the RNA properties.

Partially related question: In fixing this, I noticed a few other visibility toggles would also fail to show keyframes and drivers, is it fine to fix all in a single commit?

Sybren A. Stüvel (sybren) added a comment.May 12 2020, 1:45 PM

@Zachman yeah, I would think so.

Nathan Craddock (natecraddock) added a revision: D7825: Outliner: Show drivers for bone visibility icon.May 23 2020, 12:31 AM
Nathan Craddock (natecraddock) closed this task as Resolved by committing rB6f8d99322cf6: Fix T76578: Show bone visibility driver in outliner.May 23 2020, 6:43 PM
Nathan Craddock (natecraddock) added a commit: rB6f8d99322cf6: Fix T76578: Show bone visibility driver in outliner.