Maniphest T76595

No indication of active keyframe
Closed, ResolvedTO DO
Actions

Assigned To
Hans Goudey (HooglyBoogly)
Authored By
Luciano Muñoz Sessarego (looch)
May 9 2020, 9:12 PM
Tags
  • Animation & Rigging
  • User Interface
  • BF Blender (2.91)
Subscribers
Hans Goudey (HooglyBoogly)
Julian Eisel (Severin)
Luciano Muñoz Sessarego (looch)
Pablo López Soriano (kednar)
RedMser (RedMser)
Sybren A. Stüvel (sybren)

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87

Blender Version
Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-05-08 14:49, hash: rBce76e17584ee

Short description of error
There isnt a color distinguishing the actively selected keyframe which makes it really hard to understand what keyframe are you about to modify it's properties in the N panel

Exact steps for others to reproduce the error

T76595-active-keyframe.blend462 KBDownload

  • Open the attached blend file.
  • See that there is no visual difference between the active key and the other selected keys.

Revisions and Commits

rB Blender
D7737rB983ad4210b9e Fix T76595: Indicate the Active Keyframe in Graph Editor

Event Timeline

Luciano Muñoz Sessarego (looch) renamed this task from No indication of active keyfra,e to No indication of active keyframe.May 9 2020, 9:12 PM
Luciano Muñoz Sessarego (looch) created this task.
Luciano Muñoz Sessarego (looch) assigned this task to Sybren A. Stüvel (sybren).May 9 2020, 9:17 PM
Luciano Muñoz Sessarego (looch) added a project: Animation & Rigging.
Sybren A. Stüvel (sybren) updated the task description.May 11 2020, 11:31 AM
Sybren A. Stüvel (sybren) changed the subtype of this task from "Report" to "Known Issue".
Sybren A. Stüvel (sybren) changed the subtype of this task from "Known Issue" to "Bug".

Marking this as a bug, as the Graph Editor theme settings do have a theme option for "Last Selected Point":

Sybren A. Stüvel (sybren) removed Sybren A. Stüvel (sybren) as the assignee of this task.May 11 2020, 11:33 AM
Sybren A. Stüvel (sybren) added a project: User Interface.
Sybren A. Stüvel (sybren) moved this task from Backlog to Bugs on the Animation & Rigging board.
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).
Hans Goudey (HooglyBoogly) claimed this task.EditedMay 13 2020, 11:10 PM
Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).
In T76595#928629, @Sybren A. Stüvel (sybren) wrote:

Marking this as a bug, as the Graph Editor theme settings do have a theme option for "Last Selected Point":

It looks like it's actually the "first selected" point that's edited in the N-panel.

/* find first selected keyframe for now, and call it the active one
 * - this is a reasonable assumption, given that whenever anyone
 *   wants to edit numerically, there is likely to only be 1 vert selected
 */

Apparently this isn't such a reasonable assumption! I can add an active point to Fcurves. And show that in the "Active Keyframe" panel.

Sybren A. Stüvel (sybren) added a comment.May 15 2020, 9:23 AM

Nice find. Weird implementation, as the active object is the last-selected, not the first-selected. Ah, checking the source, it's actuall the first, selected keyframe (so the one with the smallest frame number).
Also, gotta love those decade-old "for now" comments.

Luciano Muñoz Sessarego (looch) added a comment.May 15 2020, 9:38 AM

we should probably standarize that to the rest of the selections to the last selected right?

Hans Goudey (HooglyBoogly) added a revision: D7737: Fix T76595: Indicate the Active Keyframe in Graph Editor.May 15 2020, 4:03 PM
Julian Eisel (Severin) changed the subtype of this task from "Bug" to "To Do".May 19 2020, 6:09 PM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

Setting this as ToDo, since there is no such thing as an active keyframe yet.
Last Selected Point is apparently an unused option.

Sybren A. Stüvel (sybren) moved this task from Bugs to Known Issues on the Animation & Rigging board.May 22 2020, 3:51 PM
Sybren A. Stüvel (sybren) moved this task from Known Issues to TODOs on the Animation & Rigging board.
Germano Cavalcante (mano-wii) changed the task status from Needs Triage to Confirmed.May 27 2020, 5:39 PM
Julian Eisel (Severin) moved this task from Backlog to Blender 2.90 on the User Interface board.Jun 26 2020, 3:08 PM
Julian Eisel (Severin) edited projects, added BF Blender (2.90); removed BF Blender.
RedMser (RedMser) added a subscriber: RedMser (RedMser).Jul 19 2020, 9:41 PM
Julian Eisel (Severin) moved this task from Blender 2.90 to Blender 2.91 on the User Interface board.Jul 20 2020, 12:58 PM
Julian Eisel (Severin) moved this task from Blender 2.91 to Blender 2.90 on the User Interface board.
Julian Eisel (Severin) moved this task from Blender 2.90 to Blender 2.91 on the User Interface board.
Julian Eisel (Severin) edited projects, added BF Blender (2.91); removed BF Blender (2.90).
Pablo López Soriano (kednar) added a subscriber: Pablo López Soriano (kednar).EditedAug 24 2020, 3:20 PM

I wanted to add a finding: The "Active Keyframe" is not the last selected, but the keyframe closer to the beginning of the timeline.

Sybren A. Stüvel (sybren) moved this task from TODOs to Short Term on the Animation & Rigging board.Oct 1 2020, 4:22 PM
Sybren A. Stüvel (sybren) added a comment.Oct 5 2020, 3:05 PM

I wanted to add a finding: The "Active Keyframe" is not the last selected, but the keyframe closer to the beginning of the timeline.

Yes, this is consistent with what was discussed in earlier comments.

Luciano Muñoz Sessarego (looch) added a comment.Oct 5 2020, 3:52 PM

Did we not agree that the active keyframe should be the last selected?

Hans Goudey (HooglyBoogly) closed this task as Resolved by committing rB983ad4210b9e: Fix T76595: Indicate the Active Keyframe in Graph Editor.Oct 7 2020, 3:28 PM
Hans Goudey (HooglyBoogly) added a commit: rB983ad4210b9e: Fix T76595: Indicate the Active Keyframe in Graph Editor.