Maniphest T76652

Rigify's Quat/Euler Converter is wrongly put in the "view" panel instead of tools.
Closed, ResolvedBUG

Assigned To
Sybren A. Stüvel (sybren)
Authored By
Luciano Muñoz Sessarego (looch)
May 11 2020, 8:54 PM
Tags
  • Animation & Rigging
  • Add-ons (Community)
Subscribers
Dalai Felinto (dfelinto)
Ivan Cappiello (icappiello)
Luciano Muñoz Sessarego (looch)
Sybren A. Stüvel (sybren)
William Reynish (billreynish)

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87

Blender Version
Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-05-10 06:26, hash: rBeaee2b411935
Worked: 2.79x

Short description of error
The "Rigify Quat/Euler Converter" panel is in the view menu of the N panel while if anywhere it should live in the Tool tab instead.

Exact steps for others to reproduce the error
Go to addons.
Turn on rigify.
View 3D > add armature > metarig.
Select the metarig, go to the armatures properties
Under "Rigify Buttons" click on the GENERATE RIG button.
Select the newly created rig.
Press N to open the N panel.
Go to View,
find the right panel in the wrong place :)

Revisions and Commits

rBA Blender Add-ons

Event Timeline

Luciano Muñoz Sessarego (looch) created this task.May 11 2020, 8:54 PM
Luciano Muñoz Sessarego (looch) edited projects, added Animation & Rigging, Add-ons (Community); removed BF Blender.
Luciano Muñoz Sessarego (looch) added a subscriber: Sybren A. Stüvel (sybren).
Ivan Cappiello (icappiello) changed the task status from Needs Triage to Confirmed.EditedMay 12 2020, 12:16 PM
Ivan Cappiello (icappiello) added subscribers: Dalai Felinto (dfelinto), Ivan Cappiello (icappiello).

this was probably done unintentionally.
I recall basic porting from 2.7 to 2.8 was done by @Dalai Felinto (dfelinto). Probably at that time 2.8 ui wasn't retained to be final. Since then nobody ever cared about moving it back to tools since everyone probably thought that dalai did put that there for a particular reason and/or nobody cared about.

This should be definitely moved to "tools" in my opinion.

EDIT:
in 2.79 we used to have it in its own separate panel named "rigify_utils", except for that panel being placed in the toolshelf instead of the properties panel. I don't know if there are some new restrictions to having custom tabs inside panels, but since this is loaded by rigify maybe naming it accordingly would be a good idea from an user experience point of view.

Ivan Cappiello (icappiello) added a comment.EditedMay 12 2020, 12:26 PM

anyway you don't need to do all that stuff to replicate the issue.

given that rigify is loaded as addon

just:

  • add a bone
  • go to pose mode

the converter is meant to be available to all armatures.

Sybren A. Stüvel (sybren) changed the subtype of this task from "Report" to "Bug".May 15 2020, 2:51 PM
In T76652#929676, @Ivan Cappiello (icappiello) wrote:

This should be definitely moved to "tools" in my opinion.

@Ivan Cappiello (icappiello) you are listed as one of the Rigify authors, so I can make & commit those changes immediately if you approve. Personally I would suggest adding a new tab Rigify for this, which would then also get the Rigify Dev tools. See D7745.

Sybren A. Stüvel (sybren) moved this task from Backlog to Bugs on the Animation & Rigging board.May 15 2020, 2:55 PM
Luciano Muñoz Sessarego (looch) added a comment.May 15 2020, 3:07 PM

as Ivan has adviced, and I concurr, this isnt a tool purely for rigiy, it aids the entire animation workflow, i'm surprised it's not part of blender itself, and creating a rigify tab just for this will only add to clutter, it's a tool and i believe it should live under the tools panel....
Not like "workspace" under the tool panel that should definitelly be removed from the n panel completely.

Sybren A. Stüvel (sybren) added a comment.May 15 2020, 3:22 PM

@Luciano Muñoz Sessarego (looch) what about the other panels? There are Rigify Dev Tools (visible when editing a mesh or armature) and Rigify Animation Tools. These were also in the View tab.

Ivan Cappiello (icappiello) added a comment.EditedMay 15 2020, 3:24 PM

@Sybren A. Stüvel (sybren) as stated before, i'd prefer as you already did, "Rigify" or "Rigify Utils".
I agree adding this in blender itself would be nice (and would require some more work on the code in my opinion), but until then i think it's better to be clear about who put that in the ui.

p.s.
originally was implemented as gift for users that were enabling rigify add-on and was also intended to make people curious about what more the add-on was capable of doing.

Ivan Cappiello (icappiello) added a comment.EditedMay 15 2020, 3:29 PM
In T76652#932384, @Sybren A. Stüvel (sybren) wrote:

@Luciano Muñoz Sessarego (looch) what about the other panels? There are Rigify Dev Tools (visible when editing a mesh or armature) and Rigify Animation Tools. These were also in the View tab.

all of these should definitely go under "Rigify"

@Sybren A. Stüvel (sybren) as i said i don't know if there are restrictions on that , maybe @William Reynish (billreynish) can give some hints. I thik would be nice to have JUST "Rigify" and not cluttering the UI with instances of "Rigify+something" depending on context.

Ivan Cappiello (icappiello) added a subscriber: William Reynish (billreynish).May 15 2020, 3:31 PM
Luciano Muñoz Sessarego (looch) added a comment.May 15 2020, 3:32 PM

I dont think so, since you want to access them when animating and that will separate them from the transforms.
otherwise you'll have to change tabs all the time.
That's why i dont thinks so also consider that they only appear when the rig is selected so no bothering other tasks not even other rigs.

Ivan Cappiello (icappiello) added a comment.May 15 2020, 3:35 PM
In T76652#932396, @Luciano Muñoz Sessarego (looch) wrote:

I dont think so, since you want to access them when animating and that will separate them from the transforms.
otherwise you'll have to change tabs all the time.
That's why i dont thinks so also consider that they only appear when the rig is selected so no bothering other tasks not even other rigs.

for that you can "pin" the panel. Right click>pin

Luciano Muñoz Sessarego (looch) added a comment.EditedMay 15 2020, 3:40 PM

i can, 99% of people don't know that pining exist, again,
its a panel that only exist when a rig is selected should be better put there it wont intrude any sort of other workflows.

but at the end of the day i don't make any decisions, is just a suggestion based on experience, do as you guys wish .

Ivan Cappiello (icappiello) added a comment.May 15 2020, 3:47 PM
In T76652#932403, @Luciano Muñoz Sessarego (looch) wrote:

i can, 99% of people don't know that pining exist, again,
its a panel that only exist when a rig is selected should be better put there it wont intrude any sort of other workflows.

As long as it is brought there by rigify it doesn't make sense to me.
You should open a feature request for having it implemented in blender itself, then i'd agree with you on its placement.

but at the end of the day i don't make any decisions, is just a suggestion based on experience, do as you guys wish .

This is an open discussion to explore the potential issues from all the angles.

Luciano Muñoz Sessarego (looch) added a comment.May 15 2020, 3:50 PM

i'm talking about the rigify layers and rigify main properties as follow up of @Sybren A. Stüvel (sybren) 's other question " what about the other panels?" on what to do with the other panels,
Rigify's Quat/Euler Converter should stay in tools.

Sybren A. Stüvel (sybren) added a comment.May 19 2020, 10:06 AM

@Ivan Cappiello (icappiello) if you agree that the panels should all be in a tab named "Rigify", please accept D7745 ;-)

Sybren A. Stüvel (sybren) closed this task as Resolved by committing rBA9a9832d5d7fe: Fix T76652 Rigify's Quat/Euler Converter is wrongly put in the "view" panel….May 19 2020, 12:51 PM
Sybren A. Stüvel (sybren) claimed this task.
Sybren A. Stüvel (sybren) added a commit: rBA9a9832d5d7fe: Fix T76652 Rigify's Quat/Euler Converter is wrongly put in the "view" panel….