Maniphest T76778

Dopesheet "Show Only Errors" filter affects the timeline but cannot be changed there
Closed, ResolvedBUG
Actions

Assigned To
Sybren A. Stüvel (sybren)
Authored By
J-W. Versteegh (JWblender)
May 15 2020, 9:53 AM
Tags
  • BF Blender
  • Animation & Rigging
  • User Interface
Subscribers
J-W. Versteegh (JWblender)
Philipp Oeser (lichtwerk)
Sybren A. Stüvel (sybren)
William Reynish (billreynish)

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 432.00

Blender Version
Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-05-02 11:33, hash: rB1623fdb3bc55
Worked: (newest version of Blender that worked as expected)

Short description of error
After modeling bone-animation and switching to dopesheet, the markers don't show up.

Exact steps for others to reproduce the error
Added rotation-markers with the 'I'-key and tested it.
Switched to dopesheet to edit the markers: none visible, so nothing editable.

Animation markers don't show up.blend705 KBDownload

Revisions and Commits

rB Blender
rB7049d2dc584d Fix T76778: Dopesheet "Show Errors" affects timeline

Related Objects

Mentioned Here
rB4904eadc0f38: Fix T55525: "Only Keyframes from Selected Channels" option in Timeline was…

Event Timeline

J-W. Versteegh (JWblender) created this task.May 15 2020, 9:53 AM
Philipp Oeser (lichtwerk) added projects: Animation & Rigging, User Interface.May 15 2020, 10:48 AM
Philipp Oeser (lichtwerk) added subscribers: William Reynish (billreynish), Sybren A. Stüvel (sybren), Philipp Oeser (lichtwerk).

This file has "Show Only Errors" option turned ON
https://docs.blender.org/manual/en/dev/editors/dope_sheet/introduction.html#filters

Once that is turned OFF, keyframes are visible again.

Assume this is not a real bug, it is weird though that this option spawns across all animation editors.
If it is intended to spawn across all animation editors, it should be visible in the timeline as well [as a minimum in the View menu -- maybe even in the header?]

CC @Sybren A. Stüvel (sybren)
CC @William Reynish (billreynish)

Philipp Oeser (lichtwerk) renamed this task from Markers don't show in the dope sheet to Dopesheet "Show Only Errors" filter affects the timeline but cannot be changed there.May 15 2020, 10:53 AM
Philipp Oeser (lichtwerk) added a comment.May 15 2020, 10:56 AM

There is also this "weirdness" that the Only Selected option seems to be enforced for the timeline?
(this might be by design - havent checked - but with the unwanted side-effect that whenever you turn it off in the dopesheet, change editor to a timeline and back to the dopesheet -> option will be enabled again...)

Philipp Oeser (lichtwerk) added a comment.May 15 2020, 11:09 AM
In T76778#932183, @Philipp Oeser (lichtwerk) wrote:

There is also this "weirdness" that the Only Selected option seems to be enforced for the timeline?
(this might be by design - havent checked - but with the unwanted side-effect that whenever you turn it off in the dopesheet, change editor to a timeline and back to the dopesheet -> option will be enabled again...)

rB4904eadc0f38: Fix T55525: "Only Keyframes from Selected Channels" option in Timeline was… is relevant here.

Anyways, one possibility is to enforce "Show Only Errors" to OFF for the timeline? What about hidden then? Or really expose all filtering for the timeline (and go down the rabbit hole of the comment in rB4904eadc0f38)

This could be marked a Known Issue though or a TODO, it is not really a bug...

Sybren A. Stüvel (sybren) changed the task status from Needs Triage to Confirmed.EditedMay 15 2020, 11:28 AM
Sybren A. Stüvel (sybren) changed the subtype of this task from "Report" to "Bug".

The dopesheet.show_only_errors setting is clearly only saved on the dopesheet, so if that's influencing the timeline editor I would consider that a bug for sure.

There is more weirdness going on, because having a separate dopesheet has no impact on the timeline, regardless of its "Show Only Errors" setting.

Thanks @Philipp Oeser (lichtwerk) for doing that digging. rB4904eadc0f38 shows that there is some code smell here. The dopesheet stores its filter settings in the space data (where it IMO should be), but the timeline has two places where these are set, trying to keep them in sync but failing.

Sybren A. Stüvel (sybren) claimed this task.May 15 2020, 11:41 AM
Sybren A. Stüvel (sybren) closed this task as Resolved by committing rB7049d2dc584d: Fix T76778: Dopesheet "Show Errors" affects timeline.May 15 2020, 12:00 PM
Sybren A. Stüvel (sybren) added a commit: rB7049d2dc584d: Fix T76778: Dopesheet "Show Errors" affects timeline.
J-W. Versteegh (JWblender) added a comment.May 15 2020, 3:48 PM

Changing anything in the filter has no effect;
I still don't see any key-info in the dope-sheet.

Philipp Oeser (lichtwerk) added a comment.May 15 2020, 3:55 PM

@J-W. Versteegh (JWblender) : you should see keyframes if you disable that setting

J-W. Versteegh (JWblender) added a comment.May 17 2020, 10:56 AM

How do I do that?
I enabled and disabled each and every choice in the filter-tab.
No markers visible in both Dopesheet and Timeline.
They are visible however in the Graph Editor.
Selecting and deselecting the bone doesn't help either.
Really stuck here.

Sybren A. Stüvel (sybren) added a comment.May 19 2020, 3:23 PM

@J-W. Versteegh (JWblender) you turned off all the options in "Filter by Type", that's why it doesn't show anything.