Maniphest T80083

Ambient Occlusion shader Max samples value can be set above 16
Closed, Archived
Actions

Assigned To
Philipp Oeser (lichtwerk)
Authored By
Ludvik Koutny (rawalanche)
Aug 24 2020, 7:07 PM
Tags
  • BF Blender
  • Render & Cycles
Subscribers
Ludvik Koutny (rawalanche)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.77

Blender Version
Broken: version: 2.83.5, branch: master (modified), commit date: 2020-08-19 06:07, hash: rBc2b144df395f
Worked: (newest version of Blender that worked as expected)

Short description of error
According to https://developer.blender.org/T80012 , ability to set high amount of samples (above 16) in nodes which use distance tracing to compute the result is an issue, since according to the explanation under the aforementioned task, these nodes are too expensive for any higher value to be used. Ambient Occlusion shader uses also distance tracing, yet the samples value can be set above 16. Therefore it must be a bug.

Exact steps for others to reproduce the error

  1. Open the attached blend file:
    AOSamples.zip91 KBDownload
  2. Notice the AO shader map samples can be set above 16

Result: AO shader map samples can be set above 16
Expected: Based on bug triage staff explanation under https://developer.blender.org/T80012 , no expensive to computer shader nodes should be able to have their samples value set above 16.

Related Objects

Event Timeline

Ludvik Koutny (rawalanche) created this task.Aug 24 2020, 7:07 PM
Philipp Oeser (lichtwerk) added a project: Render & Cycles.Aug 25 2020, 11:00 AM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

I would argue that AO and Bevel are not exactly the same thing, so it might make sense to fire more samples at AO.

Nevertheless, I would rather up the property range for the Bevel node while [@Ludvik Koutny (rawalanche): this would probably solve the isses in T80012, right?] than cap the limit for AO...
D8701: Fix T80012: Bevel Shader node Samples value has too low hardcoded limit

Ludvik Koutny (rawalanche) added a comment.EditedAug 25 2020, 11:21 AM
In T80083#1002224, @Philipp Oeser (lichtwerk) wrote:

I would argue that AO and Bevel are not exactly the same thing, so it might make sense to fire more samples at AO.

Nevertheless, I would rather up the property range for the Bevel node while [@Ludvik Koutny (rawalanche): this would probably solve the isses in T80012, right?] than cap the limit for AO...
D8701: Fix T80012: Bevel Shader node Samples value has too low hardcoded limit

Yes, I reported this just to show how the reason for rejecting T80012 conflicts with common sense and consistency. I of course don't want Max AO samples harcoded limit lowered ;)

Also, in case of of using Bevel just for rendertime bevel, I agree that lower amount of samples may be enough. But the thing here is that Blender gives us a complete node based editor with as low level tools as elementary geometry shading components and vector math / transform nodes. So it doesn't make much sense to make such strong assumptions on how people are going to utilize these shading nodes. Here's an example of the Bevel node creative usage specifically:
https://blenderartists.org/t/quick-procedural-shading-tip-bevel-shader-mask/1248242

Philipp Oeser (lichtwerk) closed this task as Archived.Aug 25 2020, 11:58 AM
Philipp Oeser (lichtwerk) claimed this task.

@Ludvik Koutny (rawalanche) : D8701: Fix T80012: Bevel Shader node Samples value has too low hardcoded limit has been accepted, will commit in a bit (raises the Bevel limit to 128 just like AO, but leaves the UI "soft" limit at 16).

That would leave us with this report being "invalid", but I guess this is what you expected ;)

Ludvik Koutny (rawalanche) added a comment.EditedAug 25 2020, 12:31 PM
In T80083#1002294, @Philipp Oeser (lichtwerk) wrote:

@Ludvik Koutny (rawalanche) : D8701: Fix T80012: Bevel Shader node Samples value has too low hardcoded limit has been accepted, will commit in a bit (raises the Bevel limit to 128 just like AO, but leaves the UI "soft" limit at 16).

That would leave us with this report being "invalid", but I guess this is what you expected ;)

Yup :) Thank you.