Maniphest T80461

Sequencer/preview mode is missing on the toggle view operator
Closed, Archived
Actions

Assigned To
Campbell Barton (campbellbarton)
Authored By
Vincent Girès (VincentG)
Sep 4 2020, 10:24 AM
Tags
  • BF Blender
  • User Interface
  • VFX & Video
  • Video Sequencer
Subscribers
Campbell Barton (campbellbarton)
Peter Fog (tintwotin)
Philipp Oeser (lichtwerk)
Richard Antalik (ISS)
Vincent Girès (VincentG)

Description

System Information
Operating system: Linux-3.10.0-1127.18.2.el7.x86_64-x86_64-with-centos-7.2.1511-Core 64 Bits
Graphics card: GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.36

Blender Version
Broken: version: 2.90.0, branch: master, commit date: 2020-08-31 11:26, hash: rB0330d1af29c0
Worked: 2.85.5 and below
Was changed in rBe43a948a2ca7: Sequencer: view toggle no longer cycles over SEQUENCER_PREVIEW state

Short description of error
Sequencer/preview mode is missing on the toggle view operator

Exact steps for others to reproduce the error
On a sequence editor context, use ctrl + tab or "View > Toggle Sequencer/Preview" operator. On previous blender version, it was toggling between the three modes (preview, sequencer and sequencer/preview). On blender 2.90.0, the "sequencer/preview"mode is missing using the operator.

Related Objects

Mentioned Here
rBe43a948a2ca7: Sequencer: view toggle no longer cycles over SEQUENCER_PREVIEW state

Event Timeline

Vincent Girès (VincentG) created this task.Sep 4 2020, 10:24 AM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Needs Information from Developers.Sep 4 2020, 11:36 AM
Philipp Oeser (lichtwerk) added projects: User Interface, VFX & Video, Video Sequencer.
Philipp Oeser (lichtwerk) added subscribers: Richard Antalik (ISS), Campbell Barton (campbellbarton), Philipp Oeser (lichtwerk).

This was changed in rBe43a948a2ca7: Sequencer: view toggle no longer cycles over SEQUENCER_PREVIEW state

from the commit message:

Switch between PREVIEW/SEQUENCER as the mixed state isn't as useful.

Think we could add the 3rd one back (as in: use context_cycle_enum?), Not sure what the rationale was? [maybe because of the dedicated workspace we have?]
Technically this is not really a bug (as it was done intentionally), but the question is: why?

CC @Campbell Barton (campbellbarton)
CC @Richard Antalik (ISS)

Philipp Oeser (lichtwerk) updated the task description.Sep 4 2020, 11:36 AM
Vincent Girès (VincentG) added a comment.Sep 4 2020, 12:03 PM

I didn't see that change, sorry for the non bug report.
I find the mixed mode quite useful to not get too small panels and very convenient to switch between it with a single shortcut and a single area window.

If it's only a shortcut change, no worries, I can make my own operator but if the goal is to delete the mixed view if the future version, I would really miss it I find much more convenient that having two different areas.

We use extensively the VSE in our studio as a reviewing tool that need quite a lot of custom panels. So having it in two separate areas shows too much tabs.

Here is a dual area display.

The same layout with the mixed view is much more readable.

Peter Fog (tintwotin) added a subscriber: Peter Fog (tintwotin).EditedSep 4 2020, 12:23 PM

Yet another commit from @Campbell Barton (campbellbarton) which unreviewed, untagged and un-discussed removes existing functionality from the VSE. You devs really, really need to have a discussion about this being cool or not?

Campbell Barton (campbellbarton) added a comment.EditedSep 4 2020, 1:48 PM

This is simply a shortcut & menu item, there is no intention to remove mixed-display.

In T80461#1009111, @Philipp Oeser (lichtwerk) wrote:

Not sure what the rationale was?

In general cycling between 3 states is fairly awkward since you need to be aware of the state order, or you cycle until you get to the state you want. Also, if you're using the split-screen it's unlikely you will need to cycle at all, since you have both available.

Toggle shortcuts are for frequently accessed functionality, for example - Ctrl-Tab also toggles between Dope-Sheet and F-Curve editor, we could add the NLA space and cycle between all 3, it could be argued this is even a feature, but in practice it's better to quickly and predictably cycle between two frequently accessed editors.

@Richard Antalik (ISS) what do you think?

Richard Antalik (ISS) added a comment.Sep 4 2020, 2:16 PM

@Vincent Girès (VincentG) you can change sequencer view in enum menu next to other menu items. Is it somehow inconvinient that you can't toggle to this mode with ctrl + tab shortcut?

I guess it would be nice and perhaps better to be able to assign custom keyboard shortcut to individual view modes?

Vincent Girès (VincentG) added a comment.Sep 4 2020, 2:28 PM

No no this is not a problem since I can use a custom operator for that. I just didn't know it was changed on purpose, I didn't see the commit.

Campbell Barton (campbellbarton) closed this task as Archived.Sep 4 2020, 3:17 PM
Campbell Barton (campbellbarton) claimed this task.

Double checked and you can change the operator to wm.context_cycle_enum with wrap to True, it works as before, if you preferred that.

Closing.