Maniphest T80651

Material tab disappears
Closed, Resolved
Actions

Assigned To
Sebastian Parborg (zeddb)
Authored By
Zachary (AFWS)
Sep 10 2020, 2:01 AM
Tags
  • BF Blender
  • User Interface
Subscribers
Brecht Van Lommel (brecht)
Christoph Schmitz (chr.schmitz)
ogierm
Robert Guetzkow (rjg)
Sebastian Parborg (zeddb)
Zachary (AFWS)

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 950M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 452.06

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-09 20:10, hash: rB0721fbb6e1e2

Short description of error
Material tab disappears when adding new object or adding new material on default cube.

Revisions and Commits

rB Blender
rB0f0e7239f027 Fix T80651: Material tab disappears

Related Objects

Mentioned Here
rB8bead3df2ffe: Fix material null pointer reference in buttons_context.c
T80327: Glitches in UI drawing

Event Timeline

Zachary (AFWS) created this task.Sep 10 2020, 2:01 AM
ogierm added a subscriber: ogierm.Sep 10 2020, 4:31 AM

I have this issue aswell on the latest buildbot build (images are missing because of T80327)

Christoph Schmitz (chr.schmitz) added a subscriber: Christoph Schmitz (chr.schmitz).Sep 10 2020, 10:54 AM
Robert Guetzkow (rjg) added subscribers: Sebastian Parborg (zeddb), Robert Guetzkow (rjg).EditedSep 10 2020, 12:22 PM

This appears to be caused by commit rB8bead3df2ffef1fa249b8c852b03cfcca2400c3d, but I'll have to take another look because the added check seems to be correct at first glance. @Sebastian Parborg (zeddb)

Robert Guetzkow (rjg) added a project: Pipeline, Assets & I/O.Sep 10 2020, 12:27 PM
Robert Guetzkow (rjg) changed the task status from Needs Triage to Confirmed.Sep 10 2020, 12:39 PM
Robert Guetzkow (rjg) edited projects, added User Interface; removed Pipeline, Assets & I/O.
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Sep 10 2020, 12:49 PM

The check is not correct. The return value does not indicate if there is a material, but rather if there could be a material and the material tab needs to be shown.

Brecht Van Lommel (brecht) assigned this task to Sebastian Parborg (zeddb).Sep 10 2020, 12:49 PM
Brecht Van Lommel (brecht) triaged this task as High priority.
Robert Guetzkow (rjg) added a comment.EditedSep 10 2020, 12:50 PM

ma in buttons_context_path_material (buttons_context.c) is NULL e.g. when removing a material from a material slot. The material tab still needs to be displayed in this case. So the check in itself is fine, but the return value is wrong.

Sebastian Parborg (zeddb) closed this task as Resolved by committing rB0f0e7239f027: Fix T80651: Material tab disappears.Sep 10 2020, 2:55 PM
Sebastian Parborg (zeddb) added a commit: rB0f0e7239f027: Fix T80651: Material tab disappears.