Maniphest T80855

Right-click on collection in outliner deselects all objects
Closed, Archived

Assigned To
Hans Goudey (HooglyBoogly)
Authored By
Anthony Esau (anthonyesau)
Sep 16 2020, 8:58 PM
Tags
  • BF Blender
  • User Interface
Subscribers
Anthony Esau (anthonyesau)
Germano Cavalcante (mano-wii)
Hans Goudey (HooglyBoogly)
Nathan Craddock (natecraddock)
Zachary (AFWS)

Description

System Information
Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon R9 M295X OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.10.16

Blender Version
Broken: version: 2.90.0, branch: master, commit date: 2020-08-31 11:26, hash: rB0330d1af29c0
Also broken in: 2.83.6, branch: master, commit date: 2020-09-09 07:32, hash: rB8610c697773e

Short description of error
When any objects are already selected and then you right-click on a collection in the outliner then all objects are deselected. I expect this not to affect the selection. This came up while attempting use "Deselect Objects" from the context menu that right-clicking on a collection brings up to remove the objects within that collection from the overall selection. Instead, right-clicking to get the context menu deselected everything.

Exact steps for others to reproduce the error
This can be reproduced from the default startup.

  1. Select all objects in the scene.
  2. Right click on "Collection" in the outliner.

The objects will be deselected immediately upon right-clicking.

Event Timeline

Anthony Esau (anthonyesau) created this task.Sep 16 2020, 8:58 PM
Germano Cavalcante (mano-wii) changed the task status from Needs Triage to Confirmed.Sep 17 2020, 9:40 PM
Germano Cavalcante (mano-wii) changed the subtype of this task from "Report" to "Bug".
Germano Cavalcante (mano-wii) added a project: User Interface.
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

This is indeed strange. And it makes the "Deselect Objects" option obsolete.
And this does not happen in blender 2.83.

In fact it seems to be a regression.

Hans Goudey (HooglyBoogly) moved this task from Backlog to Bugs on the User Interface board.Sep 20 2020, 5:57 PM
Hans Goudey (HooglyBoogly) added subscribers: Nathan Craddock (natecraddock), Hans Goudey (HooglyBoogly).Sep 29 2020, 11:01 PM

@Germano Cavalcante (mano-wii) Are you sure this is a regression? I just tried all the way back to 2.81 and other items are always deselected when right clicking a collection.

The outliner selects on right click so you don't end up in a situation with an active but deselected item. Maybe this could be changed, (Actually I started trying to do this before I realized this was on purpose, progress here P1666) or maybe an exception could be made for collections. But I'm not sure either of those make complete sense.

@zachman Does this make sense to you?

Nathan Craddock (natecraddock) added a comment.Sep 30 2020, 7:15 PM

I also see this exact behavior back to 2.80. This is intentional.

If you right-click select on a selected element the selection remains the same. If you right-click on an unselected element it will become the new selection. This is because the context menu operators usually operate on the selection, so it is required to select the target of the right-click to ensure the operator works correctly.

Hans Goudey (HooglyBoogly) closed this task as Archived.Oct 13 2020, 9:49 PM
Hans Goudey (HooglyBoogly) claimed this task.
Hans Goudey (HooglyBoogly) changed the subtype of this task from "Bug" to "Report".

Okay, I think this information is enough to close this task. Changing this behavior would require some deeper changes to how the outliner decides which item to act on, see the start of the changes in P1666.
But it's not clear that those changes are actually for the better, and either way, they should be done purposefully, not just with the intention of solving one report, potentially then causing other problems.

Germano Cavalcante (mano-wii) added a comment.Oct 13 2020, 10:11 PM

Sorry I didn't answer before, but is it a regression only on windows?
See this GIF, in the right the objects are deselected instantly:

Zachary (AFWS) added a subscriber: Zachary (AFWS).Oct 13 2020, 10:50 PM
In T80855#1033526, @Germano Cavalcante (mano-wii) wrote:

Sorry I didn't answer before, but is it a regression only on windows?
See this GIF, in the right the objects are deselected instantly:

You sure this isn't caused by "Sync Selection"? Disable Sync Selection and it doesn't do this.

Germano Cavalcante (mano-wii) added a comment.Oct 13 2020, 11:02 PM

In fact it is caused by Sync Selection!
Apparently, Blender 2.80 didn't have this option.

Right click changes the selection in the outline, deselecting everything within the collection, this will consequently update the selected objects in the scene.