Maniphest T81135

Graph Editor Expand/Collapse Channels collapsing issue
Confirmed, NormalKNOWN ISSUE

Assigned To
Sergio Rojas (sergiorojas)
Authored By
Philipp Oeser (lichtwerk)
Sep 24 2020, 3:42 PM
Tags
  • BF Blender
  • Animation & Rigging
  • User Interface
Subscribers
Luciano Muñoz Sessarego (looch)
Nisim Joseph (nisimjoseph)
Philipp Oeser (lichtwerk)
Sergio Rojas (sergiorojas)
Sybren A. Stüvel (sybren)

Description

System Information
Operating system: Linux-5.8.4-200.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.66

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-24 12:05, hash: rB7ba30d35d15a
Worked: never

Short description of error
Once Collapse/Expand Channels operator has been used with the All option turned OFF, then the All is turned ON again for Collapse, a following Expand Channels operation will not work anymore

Exact steps for others to reproduce the error

  • Open above .blend
  • Collapse Channels, in the Redo Last Operation panel turn OFF All
  • Expand Channels, in the Redo Last Operation panel turn OFF All
  • Collapse Channels again, in the Redo Last Operation panel turn ON All again
  • Expand Channels will not expand to selected channel anymore

Event Timeline

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Sep 24 2020, 3:42 PM
Philipp Oeser (lichtwerk) created this task.
Philipp Oeser (lichtwerk) added projects: Animation & Rigging, User Interface.
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".
Nisim Joseph (nisimjoseph) added a subscriber: Nisim Joseph (nisimjoseph).Sep 24 2020, 4:38 PM
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).EditedSep 25 2020, 4:55 PM

I did some digging, and it turns out that expand/collapse, visible/invisible, active/inactive, those are all handled in pretty much the same way. When collapsing with "All" disabled, Blender interprets it as "selected elements only", where "elements" are the rows of the dope sheet/graph editor. The problem here is that the row for the object itself is selected whenever the object is selected, and thus the entire object row collapses.

Similarly, when expanding Blender only expands those channels with "data visible", which means "nothing" when everything has been collapsed.

Fixing this will likely require writing specialised code to handle proper collapsing and expanding, instead of trying to reuse the generic code.

Sybren A. Stüvel (sybren) moved this task from Backlog to Bugs on the Animation & Rigging board.Sep 25 2020, 5:06 PM
Sybren A. Stüvel (sybren) changed the subtype of this task from "Bug" to "Known Issue".Oct 12 2020, 4:00 PM
Sybren A. Stüvel (sybren) moved this task from Bugs to Known Issues on the Animation & Rigging board.
Sergio Rojas (sergiorojas) added a subscriber: Sergio Rojas (sergiorojas).Jun 10 2021, 11:51 PM
This comment was removed by Sergio Rojas (sergiorojas).
Sergio Rojas (sergiorojas) added a comment.Jun 11 2021, 12:23 AM

I would like to work on this

Sybren A. Stüvel (sybren) added a comment.Jun 14 2021, 12:05 PM

Excellent! Just claim the task ("Add Action..." box above the comment textarea) and get cracking :)

Sergio Rojas (sergiorojas) added a comment.Jun 16 2021, 7:16 PM

I claim the task

Luciano Muñoz Sessarego (looch) added a subscriber: Luciano Muñoz Sessarego (looch).Jun 16 2021, 7:19 PM

yes! thanks @Sergio Rojas (sergiorojas) !

Sybren A. Stüvel (sybren) assigned this task to Sergio Rojas (sergiorojas).Jun 18 2021, 3:19 PM

@Sergio Rojas (sergiorojas) I'll assign the task to you. Next time you want to claim a task, feel free to use this option and the system will assign it to you automatically:

(it's a bit hidden, I know)

Hans Goudey (HooglyBoogly) moved this task from Backlog to Known Issues on the User Interface board.Mar 30 2022, 8:49 PM