Maniphest T81400

Width space any menu without ... (3 dots)
Closed, ResolvedTO DO

Assigned To
Harley Acheson (harley)
Authored By
Kent Davis (mac4kent)
Oct 2 2020, 10:49 PM
Tags
  • BF Blender
  • User Interface
Subscribers
Ankit Meel (ankitm)
Hans Goudey (HooglyBoogly)
Harley Acheson (harley)
Kent Davis (mac4kent)
Philipp Oeser (lichtwerk)

Description

System Information
Operating system: Darwin-20.1.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 575 OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.0.40

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-10-01 21:21, hash: rBedd1164575fe
Worked: (newest version of Blender that worked as expected)

Short description of error
Width space any menu without ... (3 dots)

Exact steps for others to reproduce the error
MacOS 11 Beta

Width space any menu without ... (3 dots)
See 3 picture you can see ... (3 dots) below

I am deaf/blind (Low vision) on Preferences > Theme on "Text Style" plus Interface on "Resolution Scale (2.00)
Need to fix width to be fit without ...

Revisions and Commits

rB Blender
D9132

Event Timeline

Kent Davis (mac4kent) created this task.Oct 2 2020, 10:49 PM
Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Oct 2 2020, 11:24 PM

I'm not sure how this one will be triaged. Currently popovers don't support dynamic width based on the text, it would be nice to support though.

Just so you know, you can hover over the label with a "..." at the end and it will show the full text in a tooltip. I know that's not a perfect solution, but at least it might help until there is one.

Kent Davis (mac4kent) added a comment.Oct 3 2020, 6:53 AM

No that is not show TOOLTIP while hover mouse cursor.

Hans Goudey (HooglyBoogly) added a comment.Oct 3 2020, 8:05 PM

You're right, sorry about that. It's when you hover over the value / color on the right that the full property name is displayed.

Kent Davis (mac4kent) added a comment.Oct 3 2020, 8:20 PM

How?

Harley Acheson (harley) added a subscriber: Harley Acheson (harley).EditedOct 3 2020, 8:28 PM

@Hans Goudey (HooglyBoogly) - Kent is changing the interface text size in Preferences / Themes / Text Style so that he can have larger text without also having an enlarged vertical line spacing or having huge icons. This seems like a quite a legitimate use case, although I wish we could do this a bit better.

First, I think we should not allow separate sizing of both "Widget" and "Widget Label" as they both have to be the same or things break in the UI anyway.

Then once we did that we'd have a single "points" value that we could use in combination with dpi and/or Resolution scale when sizing menu, popover, and dialog width. In effect change from a popover width that is "800 pixels wide at Resolution Scale 1.0" to being "the width of 40 ems"

Kent Davis (mac4kent) added a comment.Oct 3 2020, 8:30 PM

You did not listen me what I said. I have low vision

Kent Davis (mac4kent) added a comment.Oct 3 2020, 8:31 PM

Need to fix auto width itself in code to fix.

Harley Acheson (harley) added a comment.Oct 3 2020, 8:36 PM

@Kent Davis (mac4kent) - You did not listen me what I said. I have low vision

Yes, I understand that perfectly.

@Kent Davis (mac4kent) - Need to fix auto width itself in code to fix.

Yes, that is in fact exactly what I said, with details on how we could approach doing so.

Kent Davis (mac4kent) added a comment.Oct 3 2020, 8:48 PM

Ok I am use Macintosh MacOS 11 Beta.

Harley Acheson (harley) claimed this task.Oct 4 2020, 2:31 AM

Actually this might be fairly trivial. And would be nice to do for the accessibility issue here, but there are also some internationalization issues it would help with.

Kent Davis (mac4kent) added a comment.Oct 4 2020, 3:56 AM

Ok

Harley Acheson (harley) added a comment.Oct 6 2020, 3:09 AM

Notes to self: A quick look at this and it seems like it might be easy and make a lot of sense. It cannot be part of the sizing of all block though, more a change in the way that we calculate the widths. For this though we'd need to be able to easily compare the current text size against "normal" and that will be available with D9107 in 2.92 (probably).

@Kent Davis (mac4kent) - Hey, I was hoping that you can tell me a few things about how you run your blender:

What is your resolution scale? Edit / Preferences / Interface / Resolution Scale
What is your line width? Edit / Preferences / Interface / Line Width
What the point sizes you set Edit / Preferences / Themes / Text Style

Kent Davis (mac4kent) added a subscriber: Philipp Oeser (lichtwerk).Oct 6 2020, 6:24 AM

@Harley Acheson (harley) I am sorry I do not believe you said "CAN'T" no way.
Everything possible to fix. I has been send report ticket few years and send many tickets.

5K retina display 27" iMac for Mac only. Not for Windows.
Do you have Mac?

Resolution Size 2.00
Line Width your wrong answer.

I can't read "normal size" sorry. They need to work on code to be fit.
@Philipp Oeser (lichtwerk) know.

Harley Acheson (harley) added a comment.Oct 6 2020, 6:46 AM

@Kent Davis (mac4kent) - I am sorry I do not believe you said "CAN'T" no way.

I didn’t say “can’t”.

Thanks for the details of your system and settings, so I can test identically.

I can't read "normal size...

Yes, and I will see if I can improve things for you.

Kent Davis (mac4kent) added a comment.Oct 6 2020, 7:06 AM

Oh ok.
Do you have Macintosh computer?

Kent Davis (mac4kent) added a comment.Oct 6 2020, 7:08 AM


Now you see "Cannot" same "can't"

Harley Acheson (harley) added a comment.Oct 6 2020, 9:55 PM

@Kent Davis (mac4kent) Now you see "Cannot" same "can't"

You are just misinterpreting a comment I made to myself about possible implementation. I am saying that I have to do it one particular way and not in some other way.

Recreating "Before and After" captures based on your images above. The top of each image is the part that you highlighted in blender as it is now. The bottom of each shows how it looks after my own changes I am working on:

Kent Davis (mac4kent) added a comment.Oct 6 2020, 10:26 PM

Now I see before (me) and after (you) I got it. Are you use Macintosh?

(More Space) on System Preferences > Display

Harley Acheson (harley) added a comment.Oct 7 2020, 12:02 AM

A patch can be found here: https://developer.blender.org/D9132

Kent Davis (mac4kent) added a comment.Oct 7 2020, 12:17 AM

You are wrong answer you did not put Mac information.
I can tell this link for Windows only.
Please do focus on Mac.

Harley Acheson (harley) added a comment.Oct 7 2020, 12:38 AM

@Kent Davis (mac4kent) - I can tell this link for Windows only. Please do focus on Mac.

That is incorrect Kent. The display of blender is the same on all platforms and the patch I have created will effect Mac, Windows, Linux, and everything else.

Kent Davis (mac4kent) added a comment.Oct 7 2020, 12:50 AM

No. Windows display and Macintosh display is different. Think about iMac have 5K. do you have Macintosh yourself?

Windows and Linux up to limit number example 2048.

Macintosh can be 6400 x 3600 pixels.
I do ask you. Do you have your iMac yourself?

Harley Acheson (harley) added a comment.Oct 7 2020, 12:54 AM

@Kent Davis (mac4kent) - do ask you. Do you have your iMac yourself?

No, I do not. But as far as your issue is concerned there is no difference. Please stop wasting time with this line of questioning. If you are able to compile blender from source, then please test the linked patch. Otherwise you'll have to wait for others to test, approve, and then hopefully you will find your problem fixed one day in a blender release.

Kent Davis (mac4kent) added a comment.Oct 7 2020, 1:00 AM

I don't know how to fix code inside the Blender 2.91 Alpha

Harley Acheson (harley) added a comment.Oct 7 2020, 1:03 AM

Then you are going to have to trust me that the patch fixes the issue that you show in this ticket, and wait for it to be (hopefully) approved and committed.

Kent Davis (mac4kent) added a comment.Oct 7 2020, 1:06 AM

I am wait for next Daily Build will be October 6, 2020. I am in USA Pacific Time California.

Harley Acheson (harley) added a comment.Oct 7 2020, 1:13 AM

The patch is not committed so it will not be on a daily build. If you watch the patch that it is on you can following its progress from evaluation, through corrections, approval, and committing. It could take days, weeks, or longer depending on how many people test, how busy everyone is, etc.

Kent Davis (mac4kent) added a comment.Oct 7 2020, 1:17 AM

I will not follow patch for Windows only.
I can do follow patch for Macintosh only.
I am wait for some one use Macintosh to answer.

Kent Davis (mac4kent) added a comment.Oct 7 2020, 1:20 AM

I see "wmWindow *window = CTX_wm_window(C);" is not match on Macintosh. I ignore it.

Harley Acheson (harley) added a comment.Oct 7 2020, 1:23 AM

@Kent Davis (mac4kent) - I see "wmWindow *window = CTX_wm_window(C);" is not match on Macintosh. I ignore it.

Ignore whatever you want, but you are still wrong. A "wmWindow" is blender's structure to hold a window on all platforms. It has nothing to do with the Windows operating system. Again, please stop this line of questioning. You are making incorrect assumptions because of a lack of understanding of the blender source code. I don't have time to answer these off-topic questions here.

Kent Davis (mac4kent) added a subscriber: Ankit Meel (ankitm).Oct 9 2020, 6:00 PM

I found your name @Ankit Meel (ankitm) I let you know read above because they focus Windows they don't understand Macintosh. They force me to check link I ignore as well about Windows. Would some one deeply inspect on Mac only. Not for Windows.

Ankit Meel (ankitm) added a comment.Oct 9 2020, 6:11 PM

@Kent Davis (mac4kent) the code is talking about this window https://en.wikipedia.org/wiki/Window_(computing)
not this Windows: https://en.wikipedia.org/wiki/Microsoft_Windows
Also, remember that we have a "Window" menu in all macOS apps :)

Harley Acheson (harley) added a comment.Oct 9 2020, 6:12 PM

@Ankit Meel (ankitm) -

In a nutshell @Kent Davis (mac4kent) increases his Themes/Text Style font points to make everything more readable because of visual problems. And as that point size is increased, independently of Resolution Scale, some things like the width of popovers become too narrow. This patch solves that but for some reason he doesn't believe me (and can't test himself) and thinks this will work only for Windows (because of some object names). Not sure why he thinks I'm lying to him when I am only trying to help him, but it is what it is... LOL

Ankit Meel (ankitm) changed the task status from Needs Triage to Confirmed.Oct 9 2020, 6:36 PM
Ankit Meel (ankitm) added a project: User Interface.
Ankit Meel (ankitm) changed the subtype of this task from "Report" to "To Do".
Kent Davis (mac4kent) added a comment.Oct 9 2020, 10:05 PM

Thank @Ankit Meel (ankitm) see my MacOS 11 Beta on System Preferences > Display > More Space (6400 x 3600)
27" 5K

Hans Goudey (HooglyBoogly) added a revision: D9132: Fix for T81400: Block Width Corrections.Oct 15 2020, 12:19 AM
Kent Davis (mac4kent) added a comment.Oct 15 2020, 1:13 AM

@Hans Goudey (HooglyBoogly) Oh well you did choice for Windows 10 did not show Macintosh. Do you have your own iMac ?

Harley Acheson (harley) added a comment.Oct 15 2020, 2:08 AM

@Kent Davis (mac4kent) - Oh well you did choice for Windows 10 did not show Macintosh. Do you have your own iMac ?

As mentioned, the problem you are reporting is not specific to Macintosh. And the fix referenced affects all platforms, including Macintosh.

Kent Davis (mac4kent) added a comment.Oct 15 2020, 2:59 AM

Windoes 10 and Macintosh is different.

Harley Acheson (harley) added a comment.Oct 15 2020, 3:15 AM

@Kent Davis (mac4kent) - Windoes 10 and Macintosh is different.

That is true, but completely irrelevant. The problem you have reported affects all platforms, and the referenced fix applies to all platforms.

Harley Acheson (harley) added a commit: rBbdad412fa76e: Fix for T81400: Block Width Corrections.Oct 18 2020, 7:33 PM
Hans Goudey (HooglyBoogly) closed this task as Resolved.Oct 18 2020, 8:07 PM
Kent Davis (mac4kent) added a comment.Oct 19 2020, 4:15 AM

@Hans Goudey (HooglyBoogly) Congratulation there for Mac resolve. I can show you screenshot for Mac only.

Harley Acheson (harley) added a comment.Oct 19 2020, 8:45 PM

@Kent Davis (mac4kent) - Congratulation there for Mac resolve. I can show you screenshot for Mac only.

Glad things are working better for you. That one popover though, for "Cursor" is problematic even with default sizes, so I will have to widen that separately. Here it is with default font settings and sizes:

Kent Davis (mac4kent) added a comment.Oct 19 2020, 8:51 PM

@Harley Acheson (harley) Oh I see no problem.

Harley Acheson (harley) added a comment.Oct 19 2020, 9:04 PM

@Kent Davis (mac4kent) - Oh I see no problem.

I just mean that the ellipsis you see after "Inverse Cursor" I also see in regular usage. We should be able to fix that too.

Kent Davis (mac4kent) added a comment.Oct 19 2020, 9:10 PM

Sure no problem.