Maniphest T82154

Compositor Fix SetAlphaOperation
Closed, ResolvedTO DO
Actions

Assigned To
Jeroen Bakker (jbakker)
Authored By
Jeroen Bakker (jbakker)
Oct 27 2020, 4:30 PM
Tags
  • BF Blender (2.92)
Subscribers
Jeroen Bakker (jbakker)
Sergey Sharybin (sergey)
Tokens
"Like" token, awarded by EAW."Pterodactyl" token, awarded by sergey.

Description

The SetAlphaOperation is used incorrectly throughout the code. @Sergey Sharybin (sergey) created a KeyingSetAlphaOperation D9211: Compositor: Ensure keying node result is pre-multiplied that does a proper pre-multiplied set alpha. This task should go over every instance and see if the new operation should be used.

  • Cryptomatte Node
  • Channel Matte
  • Chroma Matte
  • Color Matte
  • Difference Matte
  • Distance Matte
  • Luminance Matte
  • Set Alpha
  • (Keying Node)

I propose to use KeyingSetAlphaOperation for all these nodes. eg. move implementation of the keying set alpha operation to set alpha operation and let the Keying matte node use the set alpha operation again.

Revisions and Commits

rB Blender
D9630rB9dbea1db66da Compositor: Alpha Mode

Related Objects

Event Timeline

Jeroen Bakker (jbakker) created this task.Oct 27 2020, 4:30 PM
Jeroen Bakker (jbakker) updated the task description.
Sergey Sharybin (sergey) awarded a token.Oct 27 2020, 4:32 PM
Evan Wilson (EAW) awarded a token.Oct 27 2020, 10:56 PM
Sergey Sharybin (sergey) mentioned this in T80748: Compositor backdrop handles alpha differently from image editor.Oct 28 2020, 12:34 PM
Jeroen Bakker (jbakker) updated the task description.Nov 4 2020, 8:55 AM
Jeroen Bakker (jbakker) added a revision: D9630: Compositor: Alpha Mode.Nov 23 2020, 12:16 PM
Bastien Montagne (mont29) moved this task from Backlog to bcon2: Features on the BF Blender (2.92) board.Dec 23 2020, 5:20 PM
Jeroen Bakker (jbakker) added a commit: rB9dbea1db66da: Compositor: Alpha Mode.Jan 5 2021, 4:36 PM
Jeroen Bakker (jbakker) closed this task as Resolved.Jan 12 2021, 2:37 PM