Maniphest T84038

Warning almost unreadable due to color scheme
Closed, ResolvedTO DO

Assigned To
Harley Acheson (harley)
Authored By
Vyacheslav (hitrpr)
Dec 22 2020, 5:26 AM
Tags
  • BF Blender
  • User Interface
Subscribers
Hans Goudey (HooglyBoogly)
Harley Acheson (harley)
Julian Eisel (Severin)
Robert Guetzkow (rjg)
Vyacheslav (hitrpr)
Tokens
"Like" token, awarded by hitrpr.

Description

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-20 17:48, hash: rBd283a093d664
Worked: 2.83.9

Short description of error
Warning in the status have white/gray font over yello backgroung.
It is near impossible to read it, esp. it appears in second.

Same issue with default/factory color scheme.

Related Objects

Mentioned In
rB694bc4d040a8: Fix for T84038: Improved Report Warnings
Mentioned Here
rB7fc0053c27e5: UI: Fix T77173: Report Background Colors for 2.83 Release
D7203: UI: Dialog Alert and Info Editor Icon Colors
T68448: Reports & Warnings UI

Event Timeline

Vyacheslav (hitrpr) created this task.Dec 22 2020, 5:26 AM
Robert Guetzkow (rjg) added subscribers: Hans Goudey (HooglyBoogly), Harley Acheson (harley), Robert Guetzkow (rjg).EditedDec 22 2020, 11:16 AM

@Harley Acheson (harley) @Hans Goudey (HooglyBoogly) You both worked on T68448 and this doesn't seem to be significantly better in the current version. It looks like this was improved in 2.83.9, but 2.90.1 and later is back to the worse contrast.

2.83.9:

2.92:

The contrast does seem a bit better than the screenshot posted in the ticket, but with the fade in and the small size at the bottom of the screen, this does seem a bit hard to read.

Robert Guetzkow (rjg) added a project: User Interface.Dec 22 2020, 11:16 AM
Robert Guetzkow (rjg) changed the task status from Needs Triage to Confirmed.Dec 22 2020, 11:19 AM
Robert Guetzkow (rjg) updated the task description.
Hans Goudey (HooglyBoogly) added a comment.Dec 22 2020, 4:14 PM

That's because we decided that I should make a last minute solution just for 2.83 and that we would have a better fix for 2.90. I honestly don't remember what happened to that plan, but the way it turned out should have been predictable anyway.

Harley Acheson (harley) added a comment.Dec 22 2020, 5:15 PM

I think the plans for that blew up because I had two separate patches, one that made changes to Info Editor (that got accepted) and another for the status bar warnings (that wasn't noticed in time).

Both areas use the same color preferences and I had to make changes to them when Info Editor started using them them differently. Rather than color entire rows or text text or icon, it instead only colored the backgrounds of the icons. This gave each row and icon similar strength because the square background stays the same size, but some icons have more or less content (some filled in and others not). But doing it this way also means making all the text colors the same. This way each row looks similar except for the icon.

This worked well for Info Editor but the related issues with the status bar messages were worse and became even worse with the above color changes. That separate patch did a similar thing for those messages. It used color only for the icon background and left the rest of the text similar to the other text on the status bar. With a yellow used for warning there really isn't a way to use that for text color or text background color and have it readable. This did result in these alerts looking a little less alert-y, but seemed okay. It was something new showing up on the status bar, had motion, and the color of the icon background color looked alarming enough.

I didn't revisit that old patch only because I thought someone (can't remember) had some plans for it and they wanted to add new color preferences just for those. I hate the idea of adding yet more preferences for yet more shades of green, red, and yellow so was just waiting for that to happen. Within a unified themed application I can't think of a good reason why the icons you see in Info Editor can't be used as-is on the status bar, especially since they are both the same information and I was trying to connect these two disparate things.

Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).Jan 28 2021, 1:37 AM

Regardless of further changes we wanted to do - why is this issue back? IIRC we added separate theme colors for the warning background. Did that change not get merged back into master?

Hans Goudey (HooglyBoogly) added a comment.Jan 28 2021, 6:21 PM

Right, as the original commit (rB7fc0053c27e5: UI: Fix T77173: Report Background Colors for 2.83 Release) mentions, it was meant to be a temporary solution for the 2.83 release with a better solution for 2.90 (D7203).


The screenshot above looks great to me, and the patch looks relatively straightforward. What about moving forward with that?

Harley Acheson (harley) added a comment.EditedJan 28 2021, 6:48 PM

IIRC we added separate theme colors for the warning background. Did that change not get merged back into master?

As far as I know we at first did add separate theme colors as a temporary fix but that was reverted for some reason so that is not the case now. I wish the revert had a comment for the reason as that might inform this subject a bit. Afterward I thought someone else shoved some change in at the very last minute, but would love that detail too.

I thought I had looked at D7203 after the dust had settled and was disappointed that it was then harder or not viable any more. But can't recall the details.

I'll see if I can get us something like this for Monday (at latest, maybe by Jan 29) so we can take a look at it and see if it still works:

Harley Acheson (harley) claimed this task.Jan 28 2021, 6:49 PM
Julian Eisel (Severin) changed the subtype of this task from "Report" to "To Do".Jan 28 2021, 7:49 PM
Harley Acheson (harley) mentioned this in rB694bc4d040a8: Fix for T84038: Improved Report Warnings.Feb 8 2021, 5:20 PM
Hans Goudey (HooglyBoogly) closed this task as Resolved.Feb 8 2021, 6:15 PM

Harley you did the extra "for" again! Closing this : )

Harley Acheson (harley) added a comment.EditedFeb 8 2021, 6:20 PM

Hey, last time it was using a "-" instead of a ":" so this is an entirely new mistake. LOL

Vyacheslav (hitrpr) awarded a token.Feb 8 2021, 11:04 PM