Maniphest T85383

Generic gizmo tweak - remapping enable/ disable precision
Closed, Archived
Actions

Assigned To
None
Authored By
Hologram (Hologram)
Feb 4 2021, 7:40 PM
Tags
  • BF Blender
Subscribers
Germano Cavalcante (mano-wii)
Hologram (Hologram)

Description

Blender Version
Tested in: 2.83.0 and 2.91.2
Operating system Windows 10.

Short description of error
When remapping enable/disable precision mode in the Generic Gizmo Modal map from Shift to either alt, A, or Grless (\) it does not enable precision mode. Note, these are the only three other buttons I have tested.
This is likely to occur on other keymaps too, see mapping in the screenshot below. Since the right shift key is the default key and hasn't been remapped, it still enables precision mode, so the mode is working on my end. Just not the remapping of the keys.

Exact steps for others to reproduce the error
Move the default cube, hit the assigned hotkey to enable/ disable precision and you'll see that it does not have any influence, whereas it still does when using the right shift button.

Related Objects

Mentioned In
rBb926c9f34587: Transform: Expose the hardcoded Precision Key
Mentioned Here
T68621: Keymap: custom key modifiers work inconsistently

Event Timeline

Hologram (Hologram) created this task.Feb 4 2021, 7:40 PM
Hologram (Hologram) updated the task description.Feb 4 2021, 7:43 PM
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).Feb 5 2021, 10:33 PM

Keymodifiers other than Ctrl, Shift, Alt, OSkey are treated differently.
There is a way to get around this limitation in simple keymaps. See T68621: Keymap: custom key modifiers work inconsistently.
But I'm not sure how it works on modal keymaps.

Germano Cavalcante (mano-wii) closed this task as Archived.Feb 9 2021, 4:04 PM

There is confusion in this report.
In the steps to reproduce the bug you mentioned moving the Cube.
In that case you're looking at the wrong keymap.
The keymaps that affect the modal tool of the move are called "Transform Modal Map".

However, the precision key modal is unfortunately hardcoded. Cannot be customized by the user :\

I don't think it needs to be hardcoded, I will investigate the code.

But I am closing this report as it is not clear what the real bug is since the steps to reproduce the bug show one thing and the description shows another.

Hologram (Hologram) added a comment.Feb 9 2021, 4:09 PM

The confusion is probably stemming from the unavailability of the precision mode within the Transform modal map.
So I presumed this entry within the gizmo tweak modal map was the same thing.
In that case it is indeed likely that by adding the precision mode as user-configurable keymap under the Transform modal map, the issue is fixed.
Could you report back here if you managed to remove the hard-coded limitation?

Germano Cavalcante (mano-wii) mentioned this in rBb926c9f34587: Transform: Expose the hardcoded Precision Key.Feb 9 2021, 4:29 PM
Germano Cavalcante (mano-wii) added a comment.Feb 9 2021, 4:35 PM

The hard-coded limitation has been removed ;)

I am confident that change is safe, but generally this type of change has some unpredictable side effects in other modal keymaps.
I did several tests, but if any problems arise in this area, please report.

Hologram (Hologram) added a comment.Feb 9 2021, 4:38 PM

That's quick, thanks! I'll be sure to properly test this (and report if necessary) after the next release.

Hologram (Hologram) added a comment.EditedFeb 28 2021, 10:13 AM

@Germano Cavalcante (mano-wii) I just tested the enable/ disable precision remapping in 2.92 for the generic gizmo tweak:


Any other key than shift still won't enable/ disable precision, whereas precision is enabled/ disabled using Right shift (since I didn't modify this).
Just to confirm was the fix added to 2.92?