Decentralize .blend I/O for space types.
Closed, ResolvedTO DO
Actions

Assigned To

sayed amin (sayed_amin)

Authored By

	Jacques Lucke (JacquesLucke)
	Mar 9 2021, 12:45 PM

Description

This is a follow up task for T76372.

All the code specific so some space types e.g. in write_area() can be moved to a callback on the space type.

Add read and write callbacks to SpaceType.
Call that from the read/write functions in screen.c.
Split the space-type specific logic of the read/write functions in screen.c into implementations of the callback, assigned as part of the space-type creation (e.g. ED_spacetype_node()).

rB Blender
	D11069	rB808b03da4370 Cleanup: decentralize .blend I/O for space types

Jacques Lucke (JacquesLucke) created this task.Mar 9 2021, 12:45 PM

Julian Eisel (Severin) added a project: Good First Issue.Mar 9 2021, 1:38 PM

Julian Eisel (Severin) updated the task description.Mar 9 2021, 1:43 PM

Julian Eisel (Severin) updated the task description.Mar 9 2021, 2:20 PM

Siddhartha Jejurkar (sidd017) added a subscriber: Siddhartha Jejurkar (sidd017).Mar 10 2021, 5:21 AM

Sugam (magus45) added a subscriber: Sugam (magus45).Mar 14 2021, 2:07 PM

Gauri V Nair (gaurivn) added a subscriber: Gauri V Nair (gaurivn).Mar 14 2021, 11:14 PM

I would like to work on this issue.

RAKSHA ARULOLI (raksha.arul) added a subscriber: RAKSHA ARULOLI (raksha.arul).Apr 5 2021, 12:38 PM

Brennen Green (dreymatic) added a subscriber: Brennen Green (dreymatic).Apr 16 2021, 5:28 AM

Looking for a little more details on the implementation here. I've checked out the relevant code. (screen.c, BKE_screen.h (SpaceType))

What should these callbacks look like/is there a similar implementation I can review elsewhere?

Amber Huo (frosted-mikan) added a subscriber: Amber Huo (frosted-mikan).Apr 25 2021, 12:15 AM

Amber Huo (frosted-mikan) added a revision: D11069: Cleanup: decentralize .blend I/O for space types.Apr 25 2021, 12:23 AM

sayed amin (sayed_amin) claimed this task.Jan 29 2022, 7:06 PM

Kevin Curry (kevin.curry) added a subscriber: Kevin Curry (kevin.curry).Feb 24 2022, 12:42 PM

Kevin Curry (kevin.curry) removed a subscriber: Kevin Curry (kevin.curry).

Kevin Curry (kevin.curry) added a subscriber: Kevin Curry (kevin.curry).

Kévin Dietrich (kevindietrich) added a commit: rB808b03da4370: Cleanup: decentralize .blend I/O for space types.Sep 28 2022, 11:53 AM

Kévin Dietrich (kevindietrich) closed this task as Resolved.Sep 28 2022, 11:56 AM