Maniphest T90415

VSE: Functions missing Cache Invalidation or Preview updates
Closed, ResolvedBUG

Assigned To
Richard Antalik (ISS)
Authored By
Peter Fog (tintwotin)
Aug 3 2021, 11:16 PM
Tags
  • BF Blender
  • Video Sequencer
  • VFX & Video
Subscribers
Philipp Oeser (lichtwerk)
Richard Antalik (ISS)

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 462.59

Blender Version
Broken: version: 3.0.0 Alpha, branch: master (modified), commit date: 2021-08-03 02:22, hash: rB04c75c5ce769

I quickly went through most of the functions which could have these problems, so I might have overlooked some or even added false positives to the lists.

Prefetch Frames should be paused while changing values in all sidebar values including modifiers. Changing sidebar values while Prefetch Frames is on is almost impossible because of delays(this problem was already addressed for numerous functions including Undo and Scrub).

Functions missing Cache invalidation(when Prefetch Frames is on - it doesn't reset, and it should):

  • Movie/Strobe.
  • Movie/Reverse Frames.
  • Swapping Effect inputs in ex. Transitions.
  • Reload Strips.
  • Reload Strips and adjust lengths.
  • Clear Strip Offsets.
  • Swap Strips.

Scene Strips:

  • 3D View object changes in referenced Scene strip needs to invalidate cache.
  • Changing the Post Processing setting in the referenced scene in a scene strip needs to invalidate cache.
  • Changes in Compositor.

Text strip doesn't update while entering text, but do when changing Wrap Width.

Snap Strips to Current Frame, is not caching from the Playhead position.

Modifiers:

  • Curves doesn't update Preview while dragging curve points. Changing Tone doesn't invalidate cache.

As I guess, that the audio isn't stored in the cache, the cache shouldn't be invalidated when changing sound strip values.

A brutal solution: If the sidebar gets focus then stop Prefetch Frames and if anything outside the sequencer, file browser and preferences gets focus then invalidate cache....

An unrelated note: Shouldn't Mirror X/Y be for the Source and not the transformed position? I guess users do not want to work will all of the transform values mirrored if their source material is mirrored.

Revisions and Commits

rB Blender
D13101

Event Timeline

Peter Fog (tintwotin) created this task.Aug 3 2021, 11:16 PM
Peter Fog (tintwotin) added projects: Video Sequencer, VFX & Video.
Richard Antalik (ISS) added a subscriber: Richard Antalik (ISS).Aug 4 2021, 12:15 AM

Thanks for nice list.

I don't quite understand Reload Strips - where can it fail?

Text strip doesn't update while entering text

This is correct behavior

As I guess, that the audio isn't stored in the cache, the cache shouldn't be invalidated when changing sound strip values.
That is correct, but I can't cause sound strip to invalidate cache. What would be steps?

An unrelated note: Shouldn't Mirror X/Y be for the Source and not the transformed position? I guess users do not want to work will all of the transform values mirrored if their source material is mirrored.

Probably it should apply for source.

Richard Antalik (ISS) changed the task status from Needs Triage to Confirmed.Aug 4 2021, 12:15 AM
Richard Antalik (ISS) changed the subtype of this task from "Report" to "Bug".
Peter Fog (tintwotin) updated the task description.Aug 4 2021, 8:11 AM
Peter Fog (tintwotin) added a comment.EditedAug 4 2021, 8:18 AM

It's Strip/Input/Reload Strips - it doesn't invalidate cache, and it should, since I guess that function can be used to swap between folders of the similar named material but with ex. diffent render states/bitrates etc.

On audio, I just wanted to get confirmed that audio changes shouldn't invalidate cache. So all is good.

Peter Fog (tintwotin) added a comment.Aug 4 2021, 11:34 AM

One more: Changing the Post Processing setting in the referenced scene in a scene strip.

Peter Fog (tintwotin) updated the task description.Aug 4 2021, 11:35 AM
Peter Fog (tintwotin) updated the task description.Aug 4 2021, 11:46 AM
Peter Fog (tintwotin) updated the task description.Aug 4 2021, 8:56 PM
Peter Fog (tintwotin) removed a subscriber: Peter Fog (tintwotin).Sep 3 2021, 6:34 PM
Peter Fog (tintwotin) closed this task as Archived.Oct 26 2021, 8:50 AM

As I do not have anymore time or motivation for a continued investment in the Blender project, I'm giving up on this report for now.

Philipp Oeser (lichtwerk) reopened this task as Confirmed.Oct 26 2021, 9:17 AM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Sorry to hear (thx again reporting). In my opinion we should not sweep this under the carpet (esp. since this already been confirmed), there is still a chance to get this fixed in the future and others might be affected by this issue as well.
Feel free to unsubscribe though.

Richard Antalik (ISS) moved this task from Backlog to 3.0 bugs on the Video Sequencer board.Nov 3 2021, 5:05 AM
Richard Antalik (ISS) moved this task from 3.0 bugs to Fix needs review on the Video Sequencer board.Nov 4 2021, 9:18 AM
Richard Antalik (ISS) closed this task as Resolved by committing rB7e148c45c89a: Fix T90415: Missing cache invalidation.Nov 15 2021, 8:33 PM
Richard Antalik (ISS) claimed this task.
Richard Antalik (ISS) added a commit: rB7e148c45c89a: Fix T90415: Missing cache invalidation.