Maniphest T93314

Video editor thumbnails don't show at the default zoom level
Closed, Resolved
Actions

Assigned To
Richard Antalik (ISS)
Authored By
Wouter Stomp (wouterstomp)
Nov 22 2021, 11:27 PM
Tags
  • BF Blender
  • Video Sequencer
Subscribers
Peter Fog (tintwotin)
Richard Antalik (ISS)
Wouter Stomp (wouterstomp)

Description

System Information
Operating system: macOS-12.0.1-arm64-arm-64bit 64 Bits
Graphics card: Apple M1 Max Apple 4.1 Metal - 76.1

Blender Version
Broken: version: 3.0.0 Beta, branch: master, commit date: 2021-11-19 19:57, hash: rBfb0ea94c6303
Worked: -

Short description of error
With the default zoom level (at least on my 16" MacBook Pro) when you turn on thumbnails for the strips in the video editor, nothing happens. Only once you zoom in further than the default level thumbnails start to appear. At the default zoom level the strips still seem more than large enough at that zoom level to show useful thumbnails.

(as a sidenote, for the thumbnails it would be very helpful if the text bar above the thumbnails would be transparent on top of the thumbnails so they can be somewhat larger)

Exact steps for others to reproduce the error
Go to the video editing workspace
Add a video strip
Enable the thumbnail overlay

Revisions and Commits

rB Blender
rBe29026bb4b4d Fix T93314: Thumbnails not drawn with default scale
rB7d1a10a9bbf3 Fix T93314: Thumbnails not drawn with default scale

Related Objects

Mentioned In
T93479: 3.0 Potential candidates for corrective releases
Mentioned Here
rBdaaa43232d34: Fix T92445: Thumbnail height without overlay text
M1: Bevel Tool Toolbar Layout - Multiple Overflow Popovers

Event Timeline

Wouter Stomp (wouterstomp) created this task.Nov 22 2021, 11:27 PM
Wouter Stomp (wouterstomp) added a project: Video Sequencer.
Richard Antalik (ISS) changed the task status from Needs Triage to Needs Information from User.Nov 23 2021, 7:53 AM
Richard Antalik (ISS) added a subscriber: Richard Antalik (ISS).

I can imagine this to be an issue as current threshold is relatively close to default zoom level. Can you share resolution and DPI of your display? Possibly screenshot would be fine, I can count pixels myself then.

In any case to confirm, that new threshold is correct, can you test custom build to make sure I get it correct?

Wouter Stomp (wouterstomp) added a comment.Nov 23 2021, 8:43 AM

3456 x 2234 with 254 pixels per inch (with the default (2x?) macOS scaling on top of that)

I can test a custom build for you yes. Isn’t it possible to not have a threshold at all? Even when very small the thumbnails can convey useful information to discern one strip from another.

Richard Antalik (ISS) added a comment.Nov 23 2021, 8:54 AM

Thanks for info. Having no threshold may cause performance issues, so not sure about that. I think some limit is good for "overall look", but will consult this aspect.

Peter Fog (tintwotin) added a subscriber: Peter Fog (tintwotin).Nov 23 2021, 10:31 AM

On a HD screen on Windows the thumbnails would be useable with a much lower no-draw-limit(default zoom level):

Richard Antalik (ISS) closed this task as Resolved by committing rB7d1a10a9bbf3: Fix T93314: Thumbnails not drawn with default scale.Dec 6 2021, 5:02 PM
Richard Antalik (ISS) claimed this task.
Richard Antalik (ISS) added a commit: rB7d1a10a9bbf3: Fix T93314: Thumbnails not drawn with default scale.
Richard Antalik (ISS) added a comment.Dec 6 2021, 5:09 PM

Sorry I am not sure if I checked this with older build or just assumed this was problem only on high DPI screens. I have bisected this to daaa43232d34, so this was unintended change.

@Wouter Stomp (wouterstomp) please check latest alpha build and let me know if this threshold works for you. I have lowered it to point where I can barely tell what content is even though I shot footage myself.

Richard Antalik (ISS) mentioned this in T93479: 3.0 Potential candidates for corrective releases.Dec 6 2021, 5:29 PM
Wouter Stomp (wouterstomp) added a comment.Dec 7 2021, 7:56 PM

They are visible at the default zoom level now, nevertheless, in my opinion they still disappear way too early. See the screenshot, although you can't really tell what happens in the thumbnails, they are still very helpful to identify one strip from another, and to identify scene changes in the strip. The screenshot is at the zoom level just before the thumbnails disappear, even at half that size they would still be useful.

Richard Antalik (ISS) added a comment.Dec 8 2021, 8:25 PM

Thanks for screenshot. here threshold is about 18px, on your screen it's about 40, so it would probably make sense to not consider DPI.

Wouter Stomp (wouterstomp) added a comment.Dec 8 2021, 8:40 PM

18px sounds reasonable :-)

Philipp Oeser (lichtwerk) added a commit: rBe29026bb4b4d: Fix T93314: Thumbnails not drawn with default scale.Jan 10 2022, 5:04 PM