Maniphest T93368

File Browser drag and drop not working (when dragging with Display as Thumbnails)
Closed, Resolved
Actions

Assigned To
Harley Acheson (harley)
Authored By
Adrian Kulawik (Adrian1819)
Nov 25 2021, 8:18 AM
Tags
  • User Interface
  • BF Blender (3.0)
Subscribers
Adrian Kulawik (Adrian1819)
Germano Cavalcante (mano-wii)
Harley Acheson (harley)
Philipp Oeser (lichtwerk)
Pratik Borhade (PratikPB2123)

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 960M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2021-11-25 17:33, hash: rB7b5a6f452aa5
Broken: version: 3.0.0 Beta, branch: master, commit date: 2021-11-24 23:03, hash: rB8f2db94627d5
Caused by rBbbadee6fc105: UI: Blend File Icons Thumbnail View

Short description of error
Drag and Drop in File Browser don't work in latest version of Blender 3.0

  1. Display as a Vertical list Working
  2. Display as Horizontal list Working
  3. Display as Thumbnails not work at all.

Exact steps for others to reproduce the error
File Browser - Try to drag 3D model blend file to scene from File Browser.
In Version from 23.11.2020 everything is working with File Browser drag and drop to scene.

BrokenWorking

Revisions and Commits

rB Blender
D13383rB3788003cdaeb Fix T93368: Dragging Blends Without Previews

Related Objects

Mentioned In
T93399: Bug in Blender 3.0 and 3.1 File Browser Display Mode Issue
Mentioned Here
rBbbadee6fc105: UI: Blend File Icons Thumbnail View
rB7b5a6f452aa5: Merge branch 'blender-v3.0-release'
T93399: Bug in Blender 3.0 and 3.1 File Browser Display Mode Issue

Event Timeline

Adrian Kulawik (Adrian1819) created this task.Nov 25 2021, 8:18 AM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Needs Information from User.Nov 25 2021, 9:56 AM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Cannot reproduce here:

Please try with File → Defaults → Load Factory Settings to see if you still can reproduce this issue.
Also: what exactly "does not work"? You cannot drag at all? error on drop? Please try to be more specific

Adrian Kulawik (Adrian1819) added a comment.Nov 25 2021, 5:23 PM

Hi,
I just tested version from today with clear Blender 3D in Windows.

No Menu

Version from 23.11.2021:

Adrian Kulawik (Adrian1819) added a comment.Nov 25 2021, 5:35 PM

Ok, I found issue.
Problem is in Display Mode:
1.) Display as a Vertical list Working
2.) Display as Horizontal list Working

3.)Display as Thumbnails not work at all.

Adrian Kulawik (Adrian1819) added a comment.Nov 25 2021, 5:36 PM

Philipp Oeser (lichtwerk) changed the task status from Needs Information from User to Needs Triage.Nov 25 2021, 5:39 PM
Philipp Oeser (lichtwerk) added a comment.Nov 26 2021, 11:34 AM

Still cannot repro on linux, but this has been reported again in T93399: Bug in Blender 3.0 and 3.1 File Browser Display Mode Issue.

Philipp Oeser (lichtwerk) renamed this task from File Browser Issue to File Browser drag and drop not working (when dragging with Display as Thumbnails).Nov 26 2021, 11:34 AM
Philipp Oeser (lichtwerk) updated the task description.
Philipp Oeser (lichtwerk) updated the task description.
Philipp Oeser (lichtwerk) updated the task description.Nov 26 2021, 11:37 AM
Philipp Oeser (lichtwerk) mentioned this in T93399: Bug in Blender 3.0 and 3.1 File Browser Display Mode Issue.
Philipp Oeser (lichtwerk) merged a task: T93399: Bug in Blender 3.0 and 3.1 File Browser Display Mode Issue.
Philipp Oeser (lichtwerk) added a subscriber: Pratik Borhade (PratikPB2123).
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.EditedNov 26 2021, 11:43 AM

I can reproduce on windows. Will check.

Pratik Borhade (PratikPB2123) added a comment.EditedNov 26 2021, 11:51 AM

@Philipp Oeser (lichtwerk) , I can only reproduce if .blend file is compressed. Can you redo with compressed file?

Will bisect.

Philipp Oeser (lichtwerk) added a comment.Nov 26 2021, 12:10 PM

Nope, cannot repro (even with compressed)

Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).Nov 26 2021, 1:23 PM

It's working fine for me. Compressed or not.
Maybe more details are needed to reproduce the problem? Since it depends on compression, it can depend on other things as well.
Windows also has a security system when dropping things in an application running as an admin. Make sure this is not the case. (See https://superuser.com/questions/59051/drag-and-drop-file-into-application-under-run-as-administrator).

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: Radeon (TM) RX 480 Graphics ATI Technologies Inc. 4.5.14760 Core Profile Context 20.45.37.01 27.20.14537.1001

Pratik Borhade (PratikPB2123) added a subscriber: Harley Acheson (harley).Nov 26 2021, 1:41 PM

Git bisect pointed me to this commit: rBbbadee6fc105: UI: Blend File Icons Thumbnail View

Windows also has a security system when dropping things

Not sure if that's the case. If so, that should also affect older builds, no?

cc @Harley Acheson (harley)

Pratik Borhade (PratikPB2123) added a project: User Interface.Nov 26 2021, 1:41 PM
Pratik Borhade (PratikPB2123) added a comment.Nov 26 2021, 2:04 PM

For test purpose I used this file:

1-2-3.blend93 KBDownload

BrokenWorking
Philipp Oeser (lichtwerk) added a comment.Nov 26 2021, 2:14 PM

Interesting, I can see the preview on that 1-2-3.blend (whereas for @Pratik Borhade (PratikPB2123), this seems to only resolve to the document icon...):

Philipp Oeser (lichtwerk) triaged this task as High priority.Nov 26 2021, 2:22 PM

Dont want to spread paranoia, but this seems to be a thing -- even though I cannot reproduce this myself, but it has been confirmed and been reported multiple times -- (and it would be a pity to ship 3.0 with it), so I think this deserves a look prior release (will dare setting it to High prio).

Harley Acheson (harley) claimed this task.Nov 26 2021, 5:08 PM

I see it. The drop that is not working is Blend files without preview. These items get a different icon.

blend_file_drop_poll() is called to see if this is something we can drop. It is only checking if the icon was ICON_FILE_BLEND.

But this icon now looks like a blender logo inside a document. Julian didn't like how that icon looked when inside the large document in thumbnail view. So I made it be just the blender logo, but then it fails the poll checking for that one icon.

The way this poll function works this means that you also can't drag and drop backup (blend1) files.

Will submit a patch right away

Pratik Borhade (PratikPB2123) updated the task description.Nov 26 2021, 5:36 PM
Pratik Borhade (PratikPB2123) added a revision: D13383: Fix T93368: Dragging Blends Without Previews.Nov 26 2021, 5:40 PM
Germano Cavalcante (mano-wii) added a comment.Nov 26 2021, 6:16 PM

Still normal here with the file attached.

Harley Acheson (harley) added a comment.Nov 26 2021, 6:29 PM

@Germano Cavalcante (mano-wii) This problem should only be when dragging blends in Thumbnail view that do not have previews.

Julian Eisel (Severin) moved this task from Backlog to Blender 3.0 on the User Interface board.Nov 26 2021, 6:55 PM
Julian Eisel (Severin) edited projects, added BF Blender (3.0); removed BF Blender.
Julian Eisel (Severin) closed this task as Resolved by committing rB3788003cdaeb: Fix T93368: Dragging Blends Without Previews.Nov 30 2021, 3:41 PM
Julian Eisel (Severin) added a commit: rB3788003cdaeb: Fix T93368: Dragging Blends Without Previews.