Maniphest T93401

The X or Delete button does not work in the outliner (Blender File)
Needs Information from Developers, Normal
Actions

Assigned To
None
Authored By
Oxicid (Oxicid)
Nov 26 2021, 11:39 AM
Tags
  • BF Blender
  • User Interface
Subscribers
Ludvik Koutny (rawalanche)
Oxicid (Oxicid)
Philipp Oeser (lichtwerk)
Pratik Borhade (PratikPB2123)

Description

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.68

Blender Version
Broken: version: 2.93.6, branch: master, commit date: 2021-11-16 14:54, hash: rBc842a90e2fa1
Worked: (newest version of Blender that worked as expected)

Short description of error
[The X or Delete button does not work in the outliner (Blender File)]

Exact steps for others to reproduce the error

  • Open default startup file
  • Outliner → Display Mode → Blender File
  • In outliner Brush → RMB → Delete → RMB → Assign Shortcut → X
  • Attempt to delete any brush with hotkey (will not delete brush)
  • Change hotkey (eg ⇧+X) and now attempt to delete brush with hotkey

when you press X items in:

BrokenBrushes, Cameras, Images, Lights, Line Styles, Materials, Meshes, Palettes, Workspaces, Worlds
workedCollections, Objects, Scenes

Delete _X_ Button.blend.py7 KBDownload

Delete _X_ Button.blend765 KBDownload
]

Related Objects

Mentioned In
T94660: Delete operator in Blender File mode of Outliner Editor can not be mapped to a hotkey
Mentioned Here
rB26c0ca3aa7f4: Outliner: Unified delete hierarchy operator

Event Timeline

Oxicid (Oxicid) created this task.Nov 26 2021, 11:39 AM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Nov 26 2021, 12:21 PM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Nov 26 2021, 12:46 PM
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) added a project: User Interface.
Philipp Oeser (lichtwerk) changed the task status from Confirmed to Needs Information from Developers.Nov 26 2021, 1:59 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Think this has caused confusion before (but it is still working somewhat as intended).

Underlying issue is that Delete is not the same for all IDs.

Collections and object have a unified delete operator since rB26c0ca3aa7f4: Outliner: Unified delete hierarchy operator: Outliner_OT_delete
The context menu still does this differently (see OUTLINER_IDOP_DELETE , id_delete_fn).
The X icon is not too helpful here (since it implies that might be a shortcut).

If you assign X to the context menu Delete, this conflicts with the X that is already assigned to Outliner_OT_delete.
And you still end up calling Outliner_OT_delete [which does not work on anything but collections and objects].
I never really fully understood priorities in shortcuts, so assigning a shortcut that is already taken elsewhere might work, often times it does not though (and the "original" operator is still called).

So, while the order/priorities of shortcuts is not entirely clear to me, I think this report just boils down to the fact that we have conflicting shortcuts here.
To fully classify this, I guess we still need input from User Interface devs (but to me, this does not look like a bug).

Philipp Oeser (lichtwerk) mentioned this in T94660: Delete operator in Blender File mode of Outliner Editor can not be mapped to a hotkey.Jan 5 2022, 3:33 PM
Philipp Oeser (lichtwerk) merged a task: T94660: Delete operator in Blender File mode of Outliner Editor can not be mapped to a hotkey.
Philipp Oeser (lichtwerk) added a subscriber: Ludvik Koutny (rawalanche).
Ludvik Koutny (rawalanche) added a comment.Jan 5 2022, 4:00 PM

So if this is not a bug, then what is the proper way to assign delete operator to any keyboard shortcut which would work in Blender File mode?

Philipp Oeser (lichtwerk) added a comment.Jan 5 2022, 4:01 PM

⇧+X will work

Ludvik Koutny (rawalanche) added a comment.Jan 5 2022, 4:21 PM
In T93401#1283314, @Philipp Oeser (lichtwerk) wrote:

⇧+X will work

Ah, yes, it does. Confusingly, though, inability to assign same keyboard shortcut to conceptually the same operation should be considered a bug. Otherwise, by the same logic, users should not be able to use Delete key to both delete objects in object mode and mesh elements in mesh edit mode, since both are different operators yet both of these are called in the different modes of the same editor.