Maniphest T93430

Custom node sockets don't get relinked when dropping a node on an existing link
Closed, Resolved

Assigned To
Omar Emara (OmarSquircleArt)
Authored By
Joshua Knauber (JoshuaKnauber)
Nov 27 2021, 4:44 PM
Tags
  • BF Blender
Subscribers
Joshua Knauber (JoshuaKnauber)
Philipp Oeser (lichtwerk)
Pratik Borhade (PratikPB2123)
Valeri Barashkov (valera)
Tokens
"Like" token, awarded by valera.

Description

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49

Blender Version
Broken: version: 3.0.0 Release Candidate, branch: master, commit date: 2021-11-25 17:24, hash: rB2fb8c6805a98
Worked: version: 3.0.0 Beta, branch: master, commit date: 2021-11-07 23:44, hash: rB56ee96349dce (maybe also with a bit newer versions, that was the last one I was using before updating to the release candidate)

Short description of error
When creating custom python nodes that have only custom sockets, the node can't be dropped onto an existing link. This is not the case if the node has normal blender sockets, only with custom ones. It also doesn't happen if the node has blender and custom sockets as the blender sockets will be connected and the custom ones ignored.

Exact steps for others to reproduce the error

  • Open the attached file and run the script in the text editor (this is the default custom node template with the blender internal sockets removed from the demo node)
  • Drop the free floating node in the custom node editor onto the link between the other two nodes
  • The node will not be linked up with the other nodes

If the same process is repeated in the version marked as working above the node is connected to the other two. If the same thing is done with the original default custom node template, the custom sockets will be ignored and the blender internal sockets will connect.

Revisions and Commits

rB Blender
D13403
D13403

Event Timeline

Joshua Knauber (JoshuaKnauber) created this task.Nov 27 2021, 4:44 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Nov 28 2021, 5:29 PM
Valeri Barashkov (valera) awarded a token.Nov 28 2021, 11:58 PM
Omar Emara (OmarSquircleArt) added a commit: rBab2a7aa0da81: Fix T93438: Auto linking do not work for custom sockets.Nov 29 2021, 11:35 AM
Pratik Borhade (PratikPB2123) closed this task as Resolved.Nov 29 2021, 1:40 PM
Pratik Borhade (PratikPB2123) assigned this task to Omar Emara (OmarSquircleArt).
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).

Can confirm this has been fixed by: rBab2a7aa0da81: Fix T93438: Auto linking do not work for custom sockets

Will close the report. Feel free to reopen if you are still able to reproduce. And thanks for the report :)

Pratik Borhade (PratikPB2123) added a subscriber: Valeri Barashkov (valera).
Valeri Barashkov (valera) added a comment.Dec 10 2021, 5:03 PM

@Pratik Borhade (PratikPB2123) @Omar Emara (OmarSquircleArt)

This is still broken for my add-on in 3.0.0, can you take a look at it please?

Omar Emara (OmarSquircleArt) added a comment.Dec 10 2021, 5:11 PM

@Valeri Barashkov (valera) This fix didn't make it in 3.0 unfortunately, we only fixed it a few days before the 3.0 release.

Joshua Knauber (JoshuaKnauber) added a comment.Dec 10 2021, 5:14 PM
This comment was removed by Joshua Knauber (JoshuaKnauber).
Pratik Borhade (PratikPB2123) added a comment.Dec 10 2021, 5:16 PM

@Philipp Oeser (lichtwerk) , would it be safe to add this fix for 3.0.1? (Commit did not break anything so far)

Valeri Barashkov (valera) added a comment.Dec 10 2021, 6:17 PM
In T93430#1270259, @Omar Emara (OmarSquircleArt) wrote:

@Valeri Barashkov (valera) This fix didn't make it in 3.0 unfortunately, we only fixed it a few days before the 3.0 release.

This should definitely be in 3.0.1, thanks for the fix much appreciated!

Philipp Oeser (lichtwerk) added a commit: rB61fe0d626441: Fix T93438: Auto linking do not work for custom sockets.Jan 11 2022, 9:00 AM