Maniphest T93573

Regression: Selection outline of curves in edit mode
Closed, ResolvedBUG
Actions

Assigned To
Hans Goudey (HooglyBoogly)
Authored By
David Kozma (kynu)
Dec 2 2021, 3:15 PM
Tags
  • Modeling
  • EEVEE & Viewport
  • Geometry Nodes
  • Nodes & Physics
  • BF Blender (3.1)
Subscribers
Aleksandr (viadvena)
Brecht Van Lommel (brecht)
David Kozma (kynu)
Hans Goudey (HooglyBoogly)
item412 (item412)
Johnny Varila (zoni527)
Philipp Oeser (lichtwerk)
Pratik Borhade (PratikPB2123)
Tokens
"Burninate" token, awarded by viadvena.

Description

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76

Blender Version
Broken: version: 3.0.0 Release Candidate, branch: master, commit date: 2021-11-25 17:24, hash: rB2fb8c6805a98
Worked: (newest version of Blender that worked as expected)

Caused by rBb9febb54a492: Geometry Nodes: Support modifier on curve objects

Short description of error
If I add extrude or bevel to any curve, it keeps showing the object selection too!

The bug is present from sometime September. My end of August build is fine but end of September build is already buggy.

Exact steps for others to reproduce the error
Add any curves, add extrude and / or bevel to it then go to edit mode.

T93573.blend800 KBDownload

Also: that selection outline should not look like that in editmode

Revisions and Commits

rB Blender
D14229rB2b3367cdf869 Fix T93573: Curve evaluated mesh selected in edit mode
D14226rB216a215ba58a Fix T93573: Remove outline from instances in edit mode

Related Objects

Event Timeline

David Kozma (kynu) created this task.Dec 2 2021, 3:15 PM
David Kozma (kynu) updated the task description.
Philipp Oeser (lichtwerk) added projects: Modeling, EEVEE & Viewport.Dec 2 2021, 3:25 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Can confirm.
Objectmode lacks the line as well.

Philipp Oeser (lichtwerk) added a comment.Dec 2 2021, 3:27 PM

Also: that selection outline should not look like that in editmode

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Dec 2 2021, 3:29 PM
Philipp Oeser (lichtwerk) updated the task description.Dec 2 2021, 3:33 PM
David Kozma (kynu) added a comment.Dec 2 2021, 3:34 PM

yes, it shouldn't be there at all : )

thanks for confirming

Philipp Oeser (lichtwerk) triaged this task as High priority.Dec 2 2021, 4:16 PM
Philipp Oeser (lichtwerk) updated the task description.
Philipp Oeser (lichtwerk) added a subscriber: Hans Goudey (HooglyBoogly).

CC @Hans Goudey (HooglyBoogly)

Philipp Oeser (lichtwerk) mentioned this in T93479: 3.0 Potential candidates for corrective releases.Dec 2 2021, 4:17 PM
Philipp Oeser (lichtwerk) mentioned this in T93756: Regression: Hiding all points of a spline in curve edit mode does not hide splines.Dec 6 2021, 4:33 PM
Philipp Oeser (lichtwerk) added a project: Geometry Nodes.Dec 7 2021, 8:38 AM
Philipp Oeser (lichtwerk) updated the task description.Dec 21 2021, 2:21 PM
Philipp Oeser (lichtwerk) mentioned this in T94300: Text object has orange outlines in edit mode with solid rendering.
Philipp Oeser (lichtwerk) merged a task: T94300: Text object has orange outlines in edit mode with solid rendering.
Philipp Oeser (lichtwerk) added a subscriber: Johnny Varila (zoni527).
Pratik Borhade (PratikPB2123) mentioned this in T94500: Selection Outline remains present in Edit Mode for curves.Dec 31 2021, 7:23 AM
Pratik Borhade (PratikPB2123) merged a task: T94500: Selection Outline remains present in Edit Mode for curves.
Pratik Borhade (PratikPB2123) added subscribers: item412 (item412), Pratik Borhade (PratikPB2123).
Pratik Borhade (PratikPB2123) renamed this task from Curve Edit mode visibility bug when any kind of geometry is generated for it to Regression: Selection outline of curves in edit mode.Dec 31 2021, 7:29 AM
Pratik Borhade (PratikPB2123) mentioned this in T94742: Curve Outline in Edit mode doesn't off.Jan 9 2022, 6:50 AM
Pratik Borhade (PratikPB2123) merged a task: T94742: Curve Outline in Edit mode doesn't off.
Pratik Borhade (PratikPB2123) added a subscriber: Aleksandr (viadvena).
Hans Goudey (HooglyBoogly) added a comment.Jan 11 2022, 8:29 PM

This is because the evaluated mesh from a curve object is handled as an instance internally, and instance outlines don't turn off when in edit mode. So I see two options:

  1. Turn off instance outlines when in edit mode.
  2. Handle the instances that come from other geometry component types (points from mesh objects, meshes from curve objects, etc.) differently, only disable the edit mode outlines for them.
David Kozma (kynu) added a comment.Jan 11 2022, 11:44 PM

Hi Hans, I posted the bug originally.
I'm surprised these are related but no, you definitely shouldn't show outlines of any selected instances (in edit mode) either.
So if it's possible please solve this bug with turning those OFF.

I'm planning to report a much more complex visibility issue regarding instances and collection instances.
This above would be at least one less issue for them.

Philipp Oeser (lichtwerk) mentioned this in T93180: Selection outline of instances in edit mode.Jan 19 2022, 9:06 AM
Aaron Carlisle (Blendify) changed the subtype of this task from "Report" to "Bug".Jan 21 2022, 10:41 PM
Philipp Oeser (lichtwerk) added a project: Nodes & Physics.Feb 18 2022, 4:17 PM
Aleksandr (viadvena) awarded a token.Feb 18 2022, 8:20 PM
Brecht Van Lommel (brecht) edited projects, added BF Blender (3.1); removed BF Blender.Feb 28 2022, 5:56 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Tagging high priority bugs with 3.1 so we get an overview of the work remaining for that release. If the module owner does not consider this planned for 3.1, please change the tag to 3.2 or lower the priority to normal.

Brecht Van Lommel (brecht) moved this task from Backlog to bcon3: Bugs on the BF Blender (3.1) board.Feb 28 2022, 6:13 PM
Hans Goudey (HooglyBoogly) claimed this task.Mar 2 2022, 1:48 PM
Hans Goudey (HooglyBoogly) edited projects, added BF Blender (3.2); removed BF Blender (3.1).

I'll see if I can find the overlay code that chooses where to make the outline. Due to 3.1's current state of high priority fixes only, I'll make the patch for 3.2 though, since this bug isn't new in 3.1,

David Kozma (kynu) added a comment.EditedMar 2 2022, 2:01 PM

Sorry Hans but just because it's not new it doesn't mean it's not high priority.
Please (really please!) try to squeeze in the fix if possible, this is a huge visibility bug and it makes working with curves much harder.
It gives me real pain to imagine more months of delay in fixing it (I've encountered it since November and reported it in December)

Also regression fixes should always be high priority. This worked perfectly before. Please don't ship a broken 3.1 in this regard.

Aleksandr (viadvena) added a comment.Mar 2 2022, 3:15 PM

Agree with @David Kozma (kynu) , this bug is really too long living

Hans Goudey (HooglyBoogly) added a revision: D14226: Fix T93573: Remove outline from instances in edit mode.Mar 2 2022, 4:07 PM
Hans Goudey (HooglyBoogly) edited projects, added BF Blender (3.1); removed BF Blender (3.2).

Okay, fair enough. Since I've found a simple fix I think it's okay to target this at 3.1.

Hans Goudey (HooglyBoogly) moved this task from Backlog/Bugs to In Progress on the Geometry Nodes board.Mar 2 2022, 4:24 PM
Hans Goudey (HooglyBoogly) closed this task as Resolved by committing rB216a215ba58a: Fix T93573: Remove outline from instances in edit mode.Mar 2 2022, 4:50 PM
Hans Goudey (HooglyBoogly) added a commit: rB216a215ba58a: Fix T93573: Remove outline from instances in edit mode.
David Kozma (kynu) added a comment.Mar 2 2022, 4:57 PM

thank you. <3
I'll test it in the next build

Philipp Oeser (lichtwerk) reopened this task as Confirmed.Mar 2 2022, 6:12 PM

Seems like this is not solved for me. Still looks like this:


Should look like this

Hans Goudey (HooglyBoogly) added a comment.Mar 2 2022, 6:23 PM

Oh shoot, you're right. The change doesn't affect wireframes. I'll see if that's also simple to solve.

Hans Goudey (HooglyBoogly) mentioned this in D14229: Fix T93573: Curve evaluated mesh selected in edit mode.Mar 2 2022, 7:35 PM
Hans Goudey (HooglyBoogly) added a revision: D14229: Fix T93573: Curve evaluated mesh selected in edit mode.
Hans Goudey (HooglyBoogly) updated the task description.Mar 2 2022, 11:25 PM

I split the curve line issue to T96138

Hans Goudey (HooglyBoogly) moved this task from In Progress to Waiting for Feedback/Review on the Geometry Nodes board.Mar 2 2022, 11:55 PM
Thomas Dinges (dingto) moved this task from bcon3: Bugs to bcon4: Show Stoppers on the BF Blender (3.1) board.Mar 6 2022, 2:10 PM
Hans Goudey (HooglyBoogly) closed this task as Resolved by committing rB2b3367cdf869: Fix T93573: Curve evaluated mesh selected in edit mode.Mar 7 2022, 8:55 PM
Hans Goudey (HooglyBoogly) added a commit: rB2b3367cdf869: Fix T93573: Curve evaluated mesh selected in edit mode.