Maniphest T93635

Group input names are being generated incorrectly
Closed, Archived
Actions

Assigned To
None
Authored By
michael campbell (3di)
Dec 4 2021, 8:50 AM
Tags
  • BF Blender
  • Geometry Nodes
Subscribers
Hans Goudey (HooglyBoogly)
michael campbell (3di)
Wannes Malfait (Wannes)

Description

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2021-12-02 18:49, hash: rB56ff9540307e
Worked: (newest version of Blender that worked as expected)

Event Timeline

michael campbell (3di) created this task.Dec 4 2021, 8:50 AM
michael campbell (3di) added projects: Geometry Nodes, Nodes.
Wannes Malfait (Wannes) added a subscriber: Wannes Malfait (Wannes).Dec 4 2021, 2:38 PM

I don't see this as a bug, more like a feature request in my opinion. When you make a node group, the only thing that's consistent across copies of the node groups, is what's inside the node group. So in that sense the most logical way to make the node group socket names is to take the socket names from what's inside the node group and not from what's outside the node group at the time of creation. Maybe I misunderstood the problem.

michael campbell (3di) added a comment.Dec 4 2021, 4:46 PM
In T93635#1264747, @Wannes Malfait (Wannes) wrote:

I don't see this as a bug, more like a feature request in my opinion. When you make a node group, the only thing that's consistent across copies of the node groups, is what's inside the node group. So in that sense the most logical way to make the node group socket names is to take the socket names from what's inside the node group and not from what's outside the node group at the time of creation. Maybe I misunderstood the problem.

How do you know what to plug into 10 fac sockets when you re-use the group? Surely you'd prefer the name of the data the inputs need rather than 10 facs?

michael campbell (3di) added a comment.Dec 5 2021, 12:26 PM
This comment was removed by michael campbell (3di).
michael campbell (3di) added a comment.Dec 5 2021, 12:50 PM
This comment was removed by michael campbell (3di).
Hans Goudey (HooglyBoogly) closed this task as Archived.Dec 6 2021, 5:32 AM
Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).

I see how it would be helpful in this situation, but I also don't think this is a bug. A node connected to the group input is more of a special case, since that's the only place you name sockets. In this case it could try to be smart and use the names on the other side of the input links, but what if the sockets on the right side of those links _also_ has names? It's just not an obvious situation honestly.
Could be that changing the behavior is helpful here, but it's more of the sort of thing that belongs in a more thought-out proposal that considers the upsides and downsides, not just one case.

Thanks anyway for the report.

michael campbell (3di) added a comment.Dec 6 2021, 7:41 AM

No worries, thanks. I was thinking maybe it would always try to take the names from sockets which have been user specified, such as group inputs/outputs.

Hans Goudey (HooglyBoogly) removed a project: Nodes.May 16 2022, 11:03 AM