Maniphest T93642

transform.edge_crease ignores Factor when used as with hotkey
Closed, Resolved
Actions

Assigned To
Germano Cavalcante (mano-wii)
Authored By
Aivis Ozols (Positivity)
Dec 4 2021, 11:39 AM
Tags
  • BF Blender
  • Modeling
Subscribers
Aivis Ozols (Positivity)
Germano Cavalcante (mano-wii)
Philipp Oeser (lichtwerk)
Tokens
"Love" token, awarded by Positivity.

Description

System Information
Operating system: Windows 10
Graphics card: RTX 2070

Blender Version
Broken: Blender 3.0.0
Worked: Blender 2.93 and before

Short description of error
transform.edge_crease is ignoring set Factor in Keymap settings!
If I set Factor to be 0.9 and then when I press hotkey and release it, factor value is not set on edge, this worked perfectly in previous Blender versions!
Same issue if I try to remove edge crease with Factor of -1
This worked in all previous Blender versions, and allowed for pre-defined Factor strength be set with single key press!

I added an image with keymap settings and blender version !
Video is showing how it need to function and was functioning in Blender 2.93.5 and previous versions !

Exact steps for others to reproduce the error
Open Blender 3.0.0
Open Keymap
Make new Keymap or use existing one with " transform.edge_crease"
Set Factor to .9 in keymap settings
tick "Confirm on Release" in keymap settings
Make a Cube in viewport, enter edit mode, select edge, and Tap your new made or existing key for "transform.edge_crease"
You will see that Factor is not updated with value set in keymap settings !!!

Same process to test Factor -1, for removal of crease!

Revisions and Commits

rB Blender
rBf32b63ec583c Fix T93642: value used as transform offset is ignored in some modes

Related Objects

Mentioned Here
rBdc2d18018171: Bump version to 3.0.1 release
rB0e86c60c28b6: Geometry Nodes: String to Curves Line/Pivot Point

Event Timeline

Aivis Ozols (Positivity) created this task.Dec 4 2021, 11:39 AM
Germano Cavalcante (mano-wii) changed the task status from Needs Triage to Confirmed.Dec 8 2021, 5:08 PM
Germano Cavalcante (mano-wii) added a project: Modeling.
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

Thanks for the report.

It is strange to execute a modal operator (whose final value depends on the mouse position) with the final value pre-established.
In this case, should the operation really be modal?

I'm confirming the report as a bug as the behavior changed and because of the strangeness of a modal operation with pre-established final values.

Germano Cavalcante (mano-wii) closed this task as Resolved by committing rBf32b63ec583c: Fix T93642: value used as transform offset is ignored in some modes.Dec 8 2021, 6:22 PM
Germano Cavalcante (mano-wii) claimed this task.
Germano Cavalcante (mano-wii) added a commit: rBf32b63ec583c: Fix T93642: value used as transform offset is ignored in some modes.
Aivis Ozols (Positivity) awarded a token.Dec 8 2021, 7:49 PM
Aivis Ozols (Positivity) added a comment.Jan 27 2022, 12:07 AM

@Germano Cavalcante (mano-wii) Hey, I finaly got to download blender 3.0.1, however, when I tested this, it still won't work. Same steps that I described above with key and factor and I still can't set value with the key press !

Is this fix not in blender 3.0.1 ? or maybe I need to do something else for Factor to work in "transform.edge_crease" ???

Germano Cavalcante (mano-wii) reopened this task as Needs Information from Developers.Jan 27 2022, 12:37 AM
In T93642#1295569, @Aivis Ozols (Positivity) wrote:

Is this fix not in blender 3.0.1 ? ...

To make sure try the latest daily build: https://builder.blender.org/download/

Aivis Ozols (Positivity) added a comment.EditedJan 27 2022, 9:19 AM

I just tested and yes, sadly it is not included in blender-3.0.1-stable+v30.dc2d18018171 it is only included in blender-3.1.0-alpha+master.0e86c60c28b6 .... :( really sad
I like working with stable versions so 3.1.0 alpha is not option :(

But Thank you, I will just wait for stable release of 3.1.0

Philipp Oeser (lichtwerk) closed this task as Resolved.Jan 27 2022, 9:29 AM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Yep, fix is not included in 3.0.1.

@Germano Cavalcante (mano-wii) : though I go over fixes to include in LTS, this was not case entirely for the 3.0.1 corrective release [devs added fixes there themselves mostly. Whenever we do another corrective release, maybe we should define exactly who is responsible in that case]

In any case, now that 3.0.1 is out, the fix is not included (sorry), we'll have to either dare using Alpha (or wait for 3.1 release which is scheduled for March 9).
Will close (since there is not much we can do here now).

Germano Cavalcante (mano-wii) added a comment.Jan 27 2022, 2:57 PM

This report is not exactly about a bug. It's about a behavior that changed in edge_crease due to a problematic change that was carelessly added in some version of 2.8x and therefore removed and limited to just a few transform modes.
I didn't really see a need for a backport.
The commit is not exactly a "Fix", it's more: "Support offset for more transform modes"

Germano Cavalcante (mano-wii) added a comment.EditedJan 27 2022, 2:59 PM

Ooops, I don't know how that Needs Information from Developers came out!