Maniphest T93899

"Animate Property" UI-dot-button does not insert key when the input is a Color [field, constant is OK]
Closed, ResolvedBUG
Actions

Assigned To
Hans Goudey (HooglyBoogly)
Authored By
Julio Cargnin Pereira (juliocargnin)
Dec 9 2021, 2:07 PM
Tags
  • BF Blender
  • User Interface
  • Nodes & Physics
  • Geometry Nodes
Subscribers
Dalai Felinto (dfelinto)
Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Julio Cargnin Pereira (juliocargnin)
Kristian Halvorsen (krisoyo)
Philipp Oeser (lichtwerk)
Pratik Borhade (PratikPB2123)

Description

System Information
Operating system: Linux-5.15.5-76051505-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.86

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: rBf1cca3055776
Worked: (newest version of Blender that worked as expected)

Short description of error
The ui-buttom that enables to insert a key-frame does not work when the input is a Color for the parameter exposed on the Geometry Nodes Modifier.
Exact steps for others to reproduce the error

  1. In Geometry Nodes Editor, create a parameter Color to your Group Input Node and Connect it to the Group Output Node.
  2. Try to press the dot-like button in the modifiers tab for the Color Attribute just exposed.
  3. Nothing will happen but the expected behavior would be keying the current state of the Color.

Revisions and Commits

rB Blender
rB3d9f0280ff1b Fix T93899: Incorrect decorator buttons for geometry nodes vector/colors

Related Objects

Event Timeline

Julio Cargnin Pereira (juliocargnin) created this task.Dec 9 2021, 2:07 PM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Dec 9 2021, 4:29 PM
Philipp Oeser (lichtwerk) claimed this task.
Philipp Oeser (lichtwerk) added projects: User Interface, Nodes & Physics, Geometry Nodes.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Will check (this was working at some point, see rB570331ca96a5: Fix T92928: Geometry nodes animation decorator wrong for vectors)

Philipp Oeser (lichtwerk) added a comment.Dec 9 2021, 4:43 PM

Note: this is only failing for fields, constant colors connected there can be animated without problems

Philipp Oeser (lichtwerk) renamed this task from "Animate Property" UI-dot-button does not insert key when the input is a Color to "Animate Property" UI-dot-button does not insert key when the input is a Color [field, constant is OK].Dec 9 2021, 4:43 PM
Philipp Oeser (lichtwerk) changed the task status from Confirmed to Needs Information from Developers.Dec 13 2021, 8:48 AM
Philipp Oeser (lichtwerk) removed Philipp Oeser (lichtwerk) as the assignee of this task.
Philipp Oeser (lichtwerk) added subscribers: Hans Goudey (HooglyBoogly), Jacques Lucke (JacquesLucke), Dalai Felinto (dfelinto).

Since this is only failing for fields, I suggest taking a step back and ask the following question(s):

  • if we create a group input, should it not default to being a single value/vector/color (circle socket icon)?
    • the default is a single value/vector/color in the modifier UI (only if you toggle to an attribute, this becomes a field)
    • even if you connect a "field-aware" socket to the group input node, it defaults to taking a single value/vector/color
  • also the icons in the Geometry Nodes Editor sidebar, Group tab, Input should change? (these stay circle icons all the time, however if an attribute is used as input, shouldnt these be diamonds as well? -- just as the Group Input node itself does?)

Would be happy to work on above changes, but I think it does not make sense to keyframe something that is marked with a diamond icon.
So will step down until this (design) question can be agreed upon.

CC @Hans Goudey (HooglyBoogly)
CC @Jacques Lucke (JacquesLucke)
CC @Dalai Felinto (dfelinto)

Philipp Oeser (lichtwerk) mentioned this in T93974: Color input on Geometry Nodes Modifier causes console to print "Could not find button with matching property to decorate" on each UI update..Dec 13 2021, 8:56 AM
Philipp Oeser (lichtwerk) merged a task: T93974: Color input on Geometry Nodes Modifier causes console to print "Could not find button with matching property to decorate" on each UI update..
Philipp Oeser (lichtwerk) mentioned this in T93873: GeoNode color attribute swatch on modifier frontend behaves wrong.
Philipp Oeser (lichtwerk) added subscribers: Kristian Halvorsen (krisoyo), Pratik Borhade (PratikPB2123).
Philipp Oeser (lichtwerk) mentioned this in D13168: UI: Use actual socket shapes in `widget_nodesocket` [WIP].Dec 13 2021, 10:08 AM
In T93899#1271233, @Philipp Oeser (lichtwerk) wrote:
  • also the icons in the Geometry Nodes Editor sidebar, Group tab, Input should change? (these stay circle icons all the time, however if an attribute is used as input, shouldnt these be diamonds as well? -- just as the Group Input node itself does?)

Note there is a patch [WIP] for this see D13168: UI: Use actual socket shapes in `widget_nodesocket` [WIP]

Jacques Lucke (JacquesLucke) added a comment.Dec 13 2021, 12:24 PM

the default is a single value/vector/color in the modifier UI (only if you toggle to an attribute, this becomes a field)

One important aspect you might be missing is that a node group does not know how it is used. For example, the node group does not know and should not care whether a single value or an attribute field is passed in from the modifier. The node group therefore has to deal with the case that both could be passed in by default (note that this could even happen when the node group is used in multiple modifiers). We could think about adding an option to turn a field input into a single value input. That might be useful in some cases, but generally, it should not be required.

Would be happy to work on above changes, but I think it does not make sense to keyframe something that is marked with a diamond icon.

It's a diamond/field within the node group. At the place where the node group is used, this value is exposed as "could be a field but can also be single value" (diamond with dot). Therefore it makes perfect sense to animate the single value.

I don't know what is causing the issue in this report exactly, but keyframing the value in the modifier should work regardless of whether it is a field or single value in the node group.

Julio Cargnin Pereira (juliocargnin) added a comment.Dec 13 2021, 12:43 PM

“…but keyframing the value in the modifier should work regardless”

It is possible to animate the color only if you right click an chose from the menu or pressing “i” hovering over.

I thought this was just a simple UI task but it seems to have escalate…

Jacques Lucke (JacquesLucke) added a comment.Dec 13 2021, 12:48 PM

I agree, it should be simple ui task, not sure how simple it is in practice, haven't looked into it more yet.

Philipp Oeser (lichtwerk) claimed this task.Dec 13 2021, 12:55 PM

OK, will check again.

Philipp Oeser (lichtwerk) removed Philipp Oeser (lichtwerk) as the assignee of this task.Jan 18 2022, 9:06 PM

Will have to concentrate on triaging for a while (and step down).

Hans Goudey (HooglyBoogly) changed the task status from Needs Information from Developers to Confirmed.Apr 28 2022, 8:44 PM
Hans Goudey (HooglyBoogly) claimed this task.
Hans Goudey (HooglyBoogly) changed the subtype of this task from "Report" to "Bug".
Hans Goudey (HooglyBoogly) closed this task as Resolved by committing rB3d9f0280ff1b: Fix T93899: Incorrect decorator buttons for geometry nodes vector/colors.Apr 28 2022, 8:46 PM
Hans Goudey (HooglyBoogly) added a commit: rB3d9f0280ff1b: Fix T93899: Incorrect decorator buttons for geometry nodes vector/colors.