Maniphest T94115

Selecting current action in Undo History Undoes all the History
Closed, Resolved
Actions

Assigned To
Campbell Barton (campbellbarton)
Authored By
Konstantins Visnevskis (kivig)
Dec 15 2021, 3:51 PM
Tags
  • BF Blender
  • Core
Subscribers
Campbell Barton (campbellbarton)
Konstantins Visnevskis (kivig)
Macreen Smith (MacSmitty)
Pratik Borhade (PratikPB2123)

Description

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.39

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: rBf1cca3055776
Caused by rB1b4d5c7a3559: Undo System: avoid redundant decoding on undo

Short description of error
Clicking on current action in the Undo History panel Undoes all the History.

Exact steps for others to reproduce the error

  • Do something (move a cube)
  • Do something more (move a cube more)
  • Edit->Undo History->Choose the current action -> All the actions get undone.

Revisions and Commits

rB Blender
rB50ecf9dcf5cd Fix T94115: Selecting current action in undo history undoes all
rB0f589f8d3ccc Fix T94115: Selecting current action in undo history undoes all

Related Objects

Mentioned In
T93479: 3.0 Potential candidates for corrective releases
Mentioned Here
rB1b4d5c7a3559: Undo System: avoid redundant decoding on undo

Event Timeline

Konstantins Visnevskis (kivig) created this task.Dec 15 2021, 3:51 PM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).EditedDec 15 2021, 4:43 PM

Hi, thanks for the report. Not bisected yet (Will do tomorrow) but probably introduced by rB1b4d5c7a35597a70411515f721a405416244b540

(Broken between rB62d9dabc7db4 - rB118803893e65)

Macreen Smith (MacSmitty) added a subscriber: Macreen Smith (MacSmitty).Dec 15 2021, 7:46 PM

Tried this out and got the same general results. Only have screenshots because trying to capture it in video format didn't work for me.

Pratik Borhade (PratikPB2123) triaged this task as High priority.Dec 16 2021, 8:51 AM
Pratik Borhade (PratikPB2123) updated the task description.
Pratik Borhade (PratikPB2123) added a project: Core.
Pratik Borhade (PratikPB2123) added a subscriber: Campbell Barton (campbellbarton).

Caused by rB1b4d5c7a3559: Undo System: avoid redundant decoding on undo

cc @Campbell Barton (campbellbarton)

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Dec 16 2021, 10:41 AM
Campbell Barton (campbellbarton) claimed this task.Dec 16 2021, 12:25 PM
Campbell Barton (campbellbarton) closed this task as Resolved by committing rB0f589f8d3ccc: Fix T94115: Selecting current action in undo history undoes all.Dec 16 2021, 1:42 PM
Campbell Barton (campbellbarton) added a commit: rB0f589f8d3ccc: Fix T94115: Selecting current action in undo history undoes all.
Campbell Barton (campbellbarton) mentioned this in T93479: 3.0 Potential candidates for corrective releases.Dec 16 2021, 1:42 PM
Philipp Oeser (lichtwerk) added a commit: rB50ecf9dcf5cd: Fix T94115: Selecting current action in undo history undoes all.Jan 11 2022, 9:33 AM